Skip to content

Conversation

@tuna1207
Copy link
Member

@tuna1207 tuna1207 commented Feb 2, 2026

Description

This PR improves the Shield subscription payment flow by clearing the cached payment method after payment fail/cancel

Problem:

  • When a user started a payment (card/crypto) but cancelled or the payment failed, the cached lastSelectedPaymentMethod would persist. This could cause issues when the user returns to the Shield plan page, as the stale cached data might not represent the best payment option for them.
    Additionally, when clearing the cache, the UI would auto-switch the payment method unexpectedly due to a useEffect dependency on lastUsedPaymentDetails.
    Solution:
  • Clear the cached payment method in the background service (subscription-service.ts) after every payment flow failure, or cancellation, ensures metrics are captured before clearing.
  • Added a hasInitializedPaymentMethod ref in shield-plan.tsx to track if initial payment method selection is done, preventing auto-switching after cancel/failure.
  • Updated @metamask/subscription-controller to v5.4.2 which includes the clearLastSelectedPaymentMethod method.

Open in GitHub Codespaces

Changelog

CHANGELOG entry: reset shield default payment method to most suitable one (crypto) if available after payment flow cancel

Related issues

Fixes:

Manual testing steps

  1. Go to Shield plan page (Settings > Transaction Shield > Subscribe)
  2. Select card payment method and click Continue
  3. Cancel the payment flow
  4. Verify that the payment method selection remains on card
  5. reopen shield plan page, crypto should be auto selected if available
  6. Complete a successful subscription and verify the flow works correctly

Screenshots/Recordings

Before

After

Screen.Recording.2026-02-02.at.17.01.00.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Touches Shield subscription payment flows (card and crypto) and the UI default-payment selection logic, so regressions could affect the checkout retry experience. Changes are small and covered by an updated unit test around timeout/failure behavior.

Overview
Improves Shield subscription retry behavior after failed/cancelled payments. The subscription background service now calls SubscriptionController:clearLastSelectedPaymentMethod on card checkout errors (including polling timeout/cancel) and on crypto approval failures, after tracking failure metrics.

Updates the SubscriptionService messenger/type allowlists to include the new controller action and extends tests to assert the cache clear happens.

Prevents unexpected UI switching. ShieldPlan adds a useRef guard so the initial auto-selection (crypto vs card) only runs once, and clicking Continue now sets this flag before starting the subscription flow.

Written by Cursor Bugbot for commit dc1fc54. This will update automatically on new commits. Configure here.

@metamaskbot metamaskbot added the team-onboarding Onboarding team label Feb 2, 2026
@github-actions github-actions bot added the size-S label Feb 2, 2026
@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Feb 2, 2026

✨ Files requiring CODEOWNER review ✨

🔐 @MetaMask/web3auth (1 files, +29 -2)
  • 📁 ui/
    • 📁 pages/
      • 📁 shield-plan/
        • 📄 shield-plan.tsx +29 -2

@tuna1207 tuna1207 added area-shield team-shield Shield team and removed team-onboarding Onboarding team labels Feb 2, 2026
@tuna1207 tuna1207 marked this pull request as ready for review February 2, 2026 10:11
@tuna1207 tuna1207 requested a review from a team as a code owner February 2, 2026 10:11
@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Feb 2, 2026

Builds ready [b7d7db4]
UI Startup Metrics (1265 ± 111 ms)
PlatformBuildTypePageMetricTest Title (ms)Persona (ms)Mean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--1265990152711113491442
load--1065846131710811501244
domContentLoaded--1059839131210811451236
domInteractive--241584162170
firstPaint--1965812652241861062
backgroundConnect--21219129814217238
firstReactRender--1693031822
initialActions--107112
loadScripts--86265111091099481039
setupStore--1262241421
numNetworkReqs--221584191578
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--19001543278617119892171
load--1081949193516310641466
domContentLoaded--1064940192415810501446
domInteractive--37192013135130
firstPaint--215701948261231431
backgroundConnect--32728454747330442
firstReactRender--24165782444
initialActions--103112
loadScripts--82470716031448161184
setupStore--1665571826
numNetworkReqs--1325126355151253
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--822678107984874988
load--68760689674742840
domContentLoaded--68260088773738831
domInteractive--251587182279
firstPaint--1026330950121203
backgroundConnect--40191672945115
firstReactRender--16103651727
initialActions--106113
loadScripts--67959888472736823
setupStore--1152941221
numNetworkReqs--221581181575
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--1240860184220313981619
load--72662810911097251024
domContentLoaded--71761810851097121014
domInteractive--38182123433113
firstPaint--1516853180201292
backgroundConnect--15813433243156302
firstReactRender--23173332529
initialActions--103111
loadScripts--71461510771087091006
setupStore--1355351418
numNetworkReqs--80481844269174
19--------
FirefoxBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--14391132213818615131812
load--1149971175612712071453
domContentLoaded--1148971175612712061452
domInteractive--70332164391171
firstPaint--------
backgroundConnect--67252475178200
firstReactRender--13104351324
initialActions--2024223
loadScripts--1114955172711011721293
setupStore--185319381240
numNetworkReqs--241285192079
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--27211919676664427343894
load--13281061491547013442193
domContentLoaded--13281061491447013442193
domInteractive--1173558792114343
firstPaint--------
backgroundConnect--34412613742863981048
firstReactRender--20133742226
initialActions--214123
loadScripts--1264989488444811942031
setupStore--1548788209172651
numNetworkReqs--71351884396183
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--16111348208618716812043
load--13821151187513114631626
domContentLoaded--13821150187513114631626
domInteractive--822921445119161
firstPaint--------
backgroundConnect--70232374996180
firstReactRender--14103531419
initialActions--102022
loadScripts--13421135176711114091519
setupStore--155140211162
numNetworkReqs--231292191778
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--30092133738470331904186
load--16841245590758918272636
domContentLoaded--16831245590758918272636
domInteractive--11833559111118440
firstPaint--------
backgroundConnect--3211191084233336897
firstReactRender--21143452530
initialActions--208123
loadScripts--16301180587957717962565
setupStore--2126965255385767
numNetworkReqs--69361854293182
19--------
📊 Page Load Benchmark Results

Current Commit: b7d7db4 | Date: 2/2/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.01s (±94ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 703ms (±92ms) 🟢 | historical mean value: 721ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 80ms (±55ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.01s 94ms 964ms 1.75s 1.23s 1.75s
domContentLoaded 703ms 92ms 663ms 1.43s 910ms 1.43s
firstPaint 80ms 55ms 64ms 624ms 88ms 624ms
firstContentfulPaint 80ms 55ms 64ms 624ms 88ms 624ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs
  • background: 304 Bytes (0.01%)
  • ui: 195 Bytes (0%)
  • common: 535 Bytes (0.01%)

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Feb 2, 2026

Builds ready [d18ff24]
UI Startup Metrics (1362 ± 112 ms)
PlatformBuildTypePageMetricTest Title (ms)Persona (ms)Mean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--13621070164011214301556
load--1155909140611012261340
domContentLoaded--1148906140010912191333
domInteractive--2817101182583
firstPaint--1556734766200278
backgroundConnect--23821631414241269
firstReactRender--17113751826
initialActions--109113
loadScripts--92669011771109961110
setupStore--1474161625
numNetworkReqs--221584171577
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--257215556232108926425116
load--1120917192814411841410
domContentLoaded--1103909191014011611383
domInteractive--37191662835122
firstPaint--217691929210240404
backgroundConnect--69829338616777092360
firstReactRender--23154252533
initialActions--103112
loadScripts--86168015761259181117
setupStore--1466471629
numNetworkReqs--1254925349157220
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--784636101483842943
load--64456690374703776
domContentLoaded--63855889173699764
domInteractive--241497172070
firstPaint--11556905107138254
backgroundConnect--40171372845111
firstReactRender--14103641622
initialActions--104112
loadScripts--63655688872697762
setupStore--1062841021
numNetworkReqs--221593191582
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--1292882189325615201700
load--70260810731146971039
domContentLoaded--69360310571146861034
domInteractive--35171242534107
firstPaint--145571065121184280
backgroundConnect--1495425628156218
firstReactRender--22164242430
initialActions--102112
loadScripts--69060210481126841025
setupStore--1142241317
numNetworkReqs--1494834160177274
19--------
FirefoxBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--15361174250122616281923
load--1234993208018312941626
domContentLoaded--1233993207918312941626
domInteractive--803629750103176
firstPaint--------
backgroundConnect--722827349119158
firstReactRender--16115291445
initialActions--2042523
loadScripts--1193978205117412541504
setupStore--175220291247
numNetworkReqs--231282191879
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--27301926434945829413665
load--13131094230426313861961
domContentLoaded--13131094230426313851960
domInteractive--15755931144161420
firstPaint--------
backgroundConnect--4001231233276563983
firstReactRender--22145872332
initialActions--207123
loadScripts--12561066224523912871928
setupStore--12012721153115545
numNetworkReqs--86382505190221
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--16371356221318117141996
load--14001146182412714581610
domContentLoaded--14001146182212714581610
domInteractive--802842154114140
firstPaint--------
backgroundConnect--64231994178154
firstReactRender--14114841418
initialActions--103122
loadScripts--13631131178611314261574
setupStore--184242381190
numNetworkReqs--221287161876
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--30692152831869833074014
load--16041286631952716922099
domContentLoaded--16041286631952716922099
domInteractive--14532679121155461
firstPaint--------
backgroundConnect--43413314993115821154
firstReactRender--24156882533
initialActions--213122
loadScripts--15431199624450916531892
setupStore--16010838201204688
numNetworkReqs--85392544791215
19--------
📊 Page Load Benchmark Results

Current Commit: d18ff24 | Date: 2/2/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.00s (±39ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 693ms (±36ms) 🟢 | historical mean value: 721ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 78ms (±10ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.00s 39ms 962ms 1.27s 1.04s 1.27s
domContentLoaded 693ms 36ms 666ms 949ms 722ms 949ms
firstPaint 78ms 10ms 64ms 152ms 88ms 152ms
firstContentfulPaint 78ms 10ms 64ms 152ms 88ms 152ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs
  • background: 304 Bytes (0.01%)
  • ui: 169 Bytes (0%)
  • common: 535 Bytes (0.01%)

@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Feb 2, 2026

Builds ready [f11ccdd]
UI Startup Metrics (1356 ± 129 ms)
PlatformBuildTypePageMetricTest Title (ms)Persona (ms)Mean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--13561049171812914291556
load--1160907150112612461357
domContentLoaded--1154903149512612381352
domInteractive--2615101182273
firstPaint--195661126190213377
backgroundConnect--23221431515234266
firstReactRender--17113251927
initialActions--104112
loadScripts--937690128212610241129
setupStore--1263651522
numNetworkReqs--211577161572
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--18751521225914319552134
load--1068942162413210691449
domContentLoaded--1051935153513010541438
domInteractive--35181452533107
firstPaint--211691542194245410
backgroundConnect--32128546735332409
firstReactRender--22154562339
initialActions--107112
loadScripts--81570512491188271172
setupStore--1673661830
numNetworkReqs--1182726256148244
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--807652102894861981
load--66257190577725819
domContentLoaded--65656689674721796
domInteractive--241495172172
firstPaint--1065632154137209
backgroundConnect--43171392860102
firstReactRender--1593541622
initialActions--104111
loadScripts--65356489473716788
setupStore--1164251120
numNetworkReqs--221586181577
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--1203848166420313811599
load--6675801066117656996
domContentLoaded--6585751059117650989
domInteractive--3216189272995
firstPaint--137621066117173240
backgroundConnect--16213938243160289
firstReactRender--21153132329
initialActions--101011
loadScripts--6555731052115648981
setupStore--1043541215
numNetworkReqs--1304727760158263
19--------
FirefoxBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--15101214262021915911843
load--12181019228717512591428
domContentLoaded--12181019228717512591428
domInteractive--78372194196154
firstPaint--------
backgroundConnect--732819749101184
firstReactRender--16104381441
initialActions--102022
loadScripts--11771004225616812211366
setupStore--156102151344
numNetworkReqs--241287202085
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--25701928778365625993553
load--12531023208424012201844
domContentLoaded--12531016208424012201844
domInteractive--1113853785112301
firstPaint--------
backgroundConnect--241113948172228631
firstReactRender--21137092237
initialActions--214123
loadScripts--11901005199619811811622
setupStore--1459720182211610
numNetworkReqs--71382194593187
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--16421349215917617751974
load--14071181180413014911679
domContentLoaded--14061181180413014901678
domInteractive--882923344130144
firstPaint--------
backgroundConnect--742323749119175
firstReactRender--1494751420
initialActions--103122
loadScripts--13611159166410814261575
setupStore--164273321257
numNetworkReqs--231279181977
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--29802094435057834514127
load--16031242270137318242510
domContentLoaded--16021241270037318242510
domInteractive--983065396101239
firstPaint--------
backgroundConnect--3541191526283350921
firstReactRender--22156772330
initialActions--217123
loadScripts--15491226267735617042487
setupStore--1809901233263752
numNetworkReqs--70341874391184
19--------
📊 Page Load Benchmark Results

Current Commit: f11ccdd | Date: 2/2/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.03s (±97ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 725ms (±123ms) 🟢 | historical mean value: 719ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 86ms (±106ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.03s 97ms 1.01s 1.96s 1.04s 1.96s
domContentLoaded 725ms 123ms 696ms 1.93s 729ms 1.93s
firstPaint 86ms 106ms 56ms 1.14s 88ms 1.14s
firstContentfulPaint 86ms 106ms 56ms 1.14s 88ms 1.14s
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs
  • background: 304 Bytes (0.01%)
  • ui: 169 Bytes (0%)
  • common: 535 Bytes (0.01%)

@chaitanyapotti chaitanyapotti added this pull request to the merge queue Feb 3, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 3, 2026
@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Feb 3, 2026

Builds ready [dc1fc54]
UI Startup Metrics (1413 ± 108 ms)
PlatformBuildTypePageMetricTest Title (ms)Persona (ms)Mean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--14131173174810814771608
load--1210999149810412831388
domContentLoaded--1203984146810412761385
domInteractive--271693182479
firstPaint--163681203122201303
backgroundConnect--23821530017244270
firstReactRender--19104872134
initialActions--1012215
loadScripts--982773123310410481162
setupStore--1353661525
numNetworkReqs--211578171572
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--21721614497745722612842
load--12031030183416412351664
domContentLoaded--11851018181416312191647
domInteractive--37191672839113
firstPaint--218711719222252316
backgroundConnect--3972872867335362595
firstReactRender--25165782847
initialActions--1011214
loadScripts--93778514961499741373
setupStore--1773971935
numNetworkReqs--1365925149160245
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--89669912971309671173
load--76161812101258181046
domContentLoaded--75561312021258121040
domInteractive--2816114202485
firstPaint--1136434350155203
backgroundConnect--3419121203681
firstReactRender--16113861731
initialActions--103112
loadScripts--75361112001248041037
setupStore--1163241218
numNetworkReqs--221587181578
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--1243853164521414581599
load--70661611791097001006
domContentLoaded--6976071174109685998
domInteractive--35171622834105
firstPaint--1376348582177271
backgroundConnect--15712936247153324
firstReactRender--22183732429
initialActions--102111
loadScripts--6946051164107683990
setupStore--1244351418
numNetworkReqs--1364834162165267
19--------
FirefoxBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--17201385244321218552105
load--14421208200216615511770
domContentLoaded--14401208199516615501770
domInteractive--843530550121160
firstPaint--------
backgroundConnect--892921251140186
firstReactRender--13102931318
initialActions--102012
loadScripts--13881181196714314671650
setupStore--135101131334
numNetworkReqs--231284181877
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--30292238915480931114458
load--16381284705664716522559
domContentLoaded--16371283705664716482555
domInteractive--13636991138132479
firstPaint--------
backgroundConnect--314120928232309869
firstReactRender--18145451925
initialActions--206122
loadScripts--15921262703363815662424
setupStore--109677818094685
numNetworkReqs--76382124398177
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--17301440242818518432092
load--14891218199814216081758
domContentLoaded--14881218199814216081758
domInteractive--903028551132170
firstPaint--------
backgroundConnect--67271843872161
firstReactRender--15122531620
initialActions--102022
loadScripts--14531192185412915361672
setupStore--194339371550
numNetworkReqs--231283192079
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--29862280793472730493991
load--16611304636962717212333
domContentLoaded--16601304636862717192332
domInteractive--12236589112117470
firstPaint--------
backgroundConnect--292119950202304897
firstReactRender--23166992438
initialActions--203123
loadScripts--16071278633761516501922
setupStore--1739797213276698
numNetworkReqs--76352474688181
19--------
📊 Page Load Benchmark Results

Current Commit: dc1fc54 | Date: 2/3/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.03s (±45ms) 🟡 | historical mean value: 1.02s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 716ms (±34ms) 🟢 | historical mean value: 712ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 76ms (±13ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.03s 45ms 1.00s 1.30s 1.05s 1.30s
domContentLoaded 716ms 34ms 694ms 976ms 736ms 976ms
firstPaint 76ms 13ms 60ms 192ms 84ms 192ms
firstContentfulPaint 76ms 13ms 60ms 192ms 84ms 192ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs
  • background: 304 Bytes (0.01%)
  • ui: 169 Bytes (0%)
  • common: 20 Bytes (0%)

@chaitanyapotti chaitanyapotti added this pull request to the merge queue Feb 3, 2026
Merged via the queue into main with commit 5ac3e8c Feb 3, 2026
179 checks passed
@chaitanyapotti chaitanyapotti deleted the feat/subscription-state-after-exiting-modal branch February 3, 2026 10:54
@github-actions github-actions bot locked and limited conversation to collaborators Feb 3, 2026
@metamaskbot metamaskbot added the release-13.18.0 Issue or pull request that will be included in release 13.18.0 label Feb 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-shield release-13.18.0 Issue or pull request that will be included in release 13.18.0 size-S team-shield Shield team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants