fix: Prevent Snap crashing when clicking buttons without names cp-13.17.0 #39727

FrederikBolding · 2026-02-03T09:47:12Z

Description

Fixes an issue introduced in aa3b155 that caused Snaps to crash when using buttons without names. We changed the fallback for value to null which gets passed as a parameter to onUserInput. This is invalid and crashes the Snap.

Changelog

CHANGELOG entry: Prevent Snap crashing when clicking buttons without names

Related issues

https://consensyssoftware.atlassian.net/browse/WPC-362

Manual testing steps

Install the following Snap: https://snaps.metamask.io/snap/npm/quai-snap/
Go to its home page
Click send
Fill out the form with some bogus values (your own address and some value)
Click send
Check that the Snap does not crash in the console

Note

Low Risk
Low risk, targeted change to Snap onUserInput event payloads; main risk is subtle behavior change if any Snap relied on a value field for ButtonClickEvent.

Overview
Prevents Snaps from crashing when a submit Button has no name by ensuring ButtonClickEvent requests never include a value field (including null) in the onUserInput payload.

Adds a regression test covering form submission with an unnamed submit button, asserting the emitted button-click event omits name and value while form submission still includes the form value map.

^{Written by Cursor Bugbot for commit 95c6fad. This will update automatically on new commits. Configure here.}

metamaskbotv2 · 2026-02-03T09:47:53Z

✨ Files requiring CODEOWNER review ✨

🫰 @MetaMask/core-platform (2 files, +79 -1)

📁 ui/
- 📁 components/
  - 📁 app/
    - 📁 snaps/
      - 📁 snap-ui-renderer/
        
        📁 components/
        
        📄 form.test.ts +74 -0
- 📁 contexts/
  - 📁 snaps/
    - 📄 snap-interface.tsx +5 -1

ui/components/app/snaps/snap-ui-renderer/components/form.test.ts

ui/contexts/snaps/snap-interface.tsx

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

ui/components/app/snaps/snap-ui-renderer/components/form.test.ts

metamaskbotv2 · 2026-02-03T10:59:09Z

Builds ready [95c6fad]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

UI Startup Metrics (1422 ± 95 ms)

Platform	BuildType	Page	Metric	Test Title (ms)	Persona (ms)	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	0	-	-	-	-	-	-	-	-
			1	-	-	-	-	-	-	-	-
			2	-	-	-	-	-	-	-	-
			3	-	-	-	-	-	-	-	-
			4	-	-	-	-	-	-	-	-
			5	-	-	-	-	-	-	-	-
			6	-	-	-	-	-	-	-	-
			7	-	-	-	-	-	-	-	-
			8	-	-	-	-	-	-	-	-
			9	-	-	-	-	-	-	-	-
			10	-	-	-	-	-	-	-	-
			11	-	-	-	-	-	-	-	-
			12	-	-	-	-	-	-	-	-
			13	-	-	-	-	-	-	-	-
			14	-	-	-	-	-	-	-	-
			15	-	-	-	-	-	-	-	-
			16	-	-	-	-	-	-	-	-
			17	-	-	-	-	-	-	-	-
			18	-	-	-	-	-	-	-	-
			uiStartup	-	-	1422	1194	1716	95	1495	1561
			load	-	-	1215	1001	1461	92	1287	1329
			domContentLoaded	-	-	1209	997	1452	92	1279	1323
			domInteractive	-	-	27	16	98	18	24	76
			firstPaint	-	-	167	67	1341	133	207	274
			backgroundConnect	-	-	240	220	282	13	247	269
			firstReactRender	-	-	18	10	46	6	20	34
			initialActions	-	-	1	0	9	1	1	3
			loadScripts	-	-	984	777	1225	91	1054	1103
			setupStore	-	-	13	6	33	6	17	27
			numNetworkReqs	-	-	22	15	79	17	15	71
			19	-	-	-	-	-	-	-	-
	Browserify	Power User Home	0	-	-	-	-	-	-	-	-
			1	-	-	-	-	-	-	-	-
			2	-	-	-	-	-	-	-	-
			3	-	-	-	-	-	-	-	-
			4	-	-	-	-	-	-	-	-
			5	-	-	-	-	-	-	-	-
			6	-	-	-	-	-	-	-	-
			7	-	-	-	-	-	-	-	-
			8	-	-	-	-	-	-	-	-
			9	-	-	-	-	-	-	-	-
			10	-	-	-	-	-	-	-	-
			11	-	-	-	-	-	-	-	-
			12	-	-	-	-	-	-	-	-
			13	-	-	-	-	-	-	-	-
			14	-	-	-	-	-	-	-	-
			15	-	-	-	-	-	-	-	-
			16	-	-	-	-	-	-	-	-
			17	-	-	-	-	-	-	-	-
			18	-	-	-	-	-	-	-	-
			uiStartup	-	-	1943	1609	2653	162	2001	2263
			load	-	-	1121	994	1943	157	1104	1569
			domContentLoaded	-	-	1104	985	1927	151	1090	1548
			domInteractive	-	-	33	18	154	23	31	95
			firstPaint	-	-	208	69	1954	238	235	338
			backgroundConnect	-	-	318	284	487	32	333	376
			firstReactRender	-	-	24	15	43	6	27	39
			initialActions	-	-	1	0	5	1	1	3
			loadScripts	-	-	868	753	1644	139	850	1267
			setupStore	-	-	15	7	53	6	17	27
			numNetworkReqs	-	-	125	49	258	54	152	241
			19	-	-	-	-	-	-	-	-
	Webpack	Standard Home	0	-	-	-	-	-	-	-	-
			1	-	-	-	-	-	-	-	-
2			-	-	-	-	-	-	-	-
3			-	-	-	-	-	-	-	-
4			-	-	-	-	-	-	-	-
5			-	-	-	-	-	-	-	-
6			-	-	-	-	-	-	-	-
7			-	-	-	-	-	-	-	-
8			-	-	-	-	-	-	-	-
9			-	-	-	-	-	-	-	-
10			-	-	-	-	-	-	-	-
11			-	-	-	-	-	-	-	-
12			-	-	-	-	-	-	-	-
13			-	-	-	-	-	-	-	-
14			-	-	-	-	-	-	-	-
15			-	-	-	-	-	-	-	-
16			-	-	-	-	-	-	-	-
17			-	-	-	-	-	-	-	-
18			-	-	-	-	-	-	-	-
uiStartup			-	-	881	681	1390	128	964	1106
load			-	-	744	611	1117	114	833	1014
domContentLoaded			-	-	737	607	1111	113	821	1009
domInteractive			-	-	28	17	93	19	24	86
firstPaint			-	-	125	63	856	93	162	241
backgroundConnect			-	-	38	18	151	25	46	115
firstReactRender			-	-	17	11	34	6	19	31
initialActions			-	-	1	0	4	1	1	2
loadScripts			-	-	734	605	1109	113	818	1007
setupStore			-	-	13	7	56	7	13	23
numNetworkReqs			-	-	22	15	85	18	15	79
19			-	-	-	-	-	-	-	-
Webpack	Power User Home	0	-	-	-	-	-	-	-	-
		1	-	-	-	-	-	-	-	-
		2	-	-	-	-	-	-	-	-
		3	-	-	-	-	-	-	-	-
		4	-	-	-	-	-	-	-	-
		5	-	-	-	-	-	-	-	-
		6	-	-	-	-	-	-	-	-
		7	-	-	-	-	-	-	-	-
		8	-	-	-	-	-	-	-	-
		9	-	-	-	-	-	-	-	-
		10	-	-	-	-	-	-	-	-
		11	-	-	-	-	-	-	-	-
		12	-	-	-	-	-	-	-	-
		13	-	-	-	-	-	-	-	-
		14	-	-	-	-	-	-	-	-
		15	-	-	-	-	-	-	-	-
		16	-	-	-	-	-	-	-	-
		17	-	-	-	-	-	-	-	-
		18	-	-	-	-	-	-	-	-
		uiStartup	-	-	1254	855	2238	230	1409	1670
		load	-	-	708	618	1085	110	701	1030
		domContentLoaded	-	-	698	610	1080	110	694	1024
		domInteractive	-	-	35	17	218	33	31	109
		firstPaint	-	-	136	64	524	87	161	291
		backgroundConnect	-	-	159	130	354	47	159	315
		firstReactRender	-	-	23	18	40	4	25	30
		initialActions	-	-	1	0	2	1	1	1
		loadScripts	-	-	696	608	1073	108	692	1017
		setupStore	-	-	12	5	43	5	13	18
		numNetworkReqs	-	-	130	46	265	62	160	257
		19	-	-	-	-	-	-	-	-
Firefox	Browserify	Standard Home	0	-	-	-	-	-	-	-	-
			1	-	-	-	-	-	-	-	-
			2	-	-	-	-	-	-	-	-
			3	-	-	-	-	-	-	-	-
			4	-	-	-	-	-	-	-	-
			5	-	-	-	-	-	-	-	-
			6	-	-	-	-	-	-	-	-
			7	-	-	-	-	-	-	-	-
			8	-	-	-	-	-	-	-	-
			9	-	-	-	-	-	-	-	-
			10	-	-	-	-	-	-	-	-
			11	-	-	-	-	-	-	-	-
			12	-	-	-	-	-	-	-	-
			13	-	-	-	-	-	-	-	-
			14	-	-	-	-	-	-	-	-
			15	-	-	-	-	-	-	-	-
			16	-	-	-	-	-	-	-	-
			17	-	-	-	-	-	-	-	-
			18	-	-	-	-	-	-	-	-
			uiStartup	-	-	1669	1348	2191	156	1768	1929
			load	-	-	1410	1175	1795	131	1499	1670
			domContentLoaded	-	-	1409	1175	1795	131	1499	1670
			domInteractive	-	-	77	37	177	36	101	146
			firstPaint	-	-	-	-	-	-	-	-
			backgroundConnect	-	-	84	29	323	52	122	189
			firstReactRender	-	-	12	10	23	2	13	14
			initialActions	-	-	1	0	2	1	2	2
			loadScripts	-	-	1361	1159	1690	111	1408	1576
			setupStore	-	-	19	6	217	38	13	66
			numNetworkReqs	-	-	24	11	91	20	19	83
			19	-	-	-	-	-	-	-	-
	Browserify	Power User Home	0	-	-	-	-	-	-	-	-
			1	-	-	-	-	-	-	-	-
			2	-	-	-	-	-	-	-	-
			3	-	-	-	-	-	-	-	-
			4	-	-	-	-	-	-	-	-
			5	-	-	-	-	-	-	-	-
			6	-	-	-	-	-	-	-	-
			7	-	-	-	-	-	-	-	-
			8	-	-	-	-	-	-	-	-
			9	-	-	-	-	-	-	-	-
			10	-	-	-	-	-	-	-	-
			11	-	-	-	-	-	-	-	-
			12	-	-	-	-	-	-	-	-
			13	-	-	-	-	-	-	-	-
			14	-	-	-	-	-	-	-	-
			15	-	-	-	-	-	-	-	-
			16	-	-	-	-	-	-	-	-
			17	-	-	-	-	-	-	-	-
			18	-	-	-	-	-	-	-	-
			uiStartup	-	-	2959	2182	4920	601	2980	4503
			load	-	-	1597	1221	2987	356	1676	2492
			domContentLoaded	-	-	1596	1221	2987	355	1676	2486
			domInteractive	-	-	123	36	743	114	125	370
			firstPaint	-	-	-	-	-	-	-	-
			backgroundConnect	-	-	305	116	1379	286	280	1012
			firstReactRender	-	-	17	14	64	5	18	21
			initialActions	-	-	2	1	2	0	2	2
			loadScripts	-	-	1543	1199	2569	316	1595	2371
			setupStore	-	-	127	7	794	188	137	627
			numNetworkReqs	-	-	71	35	200	42	94	180
			19	-	-	-	-	-	-	-	-
	Webpack	Standard Home	0	-	-	-	-	-	-	-	-
			1	-	-	-	-	-	-	-	-
2			-	-	-	-	-	-	-	-
3			-	-	-	-	-	-	-	-
4			-	-	-	-	-	-	-	-
5			-	-	-	-	-	-	-	-
6			-	-	-	-	-	-	-	-
7			-	-	-	-	-	-	-	-
8			-	-	-	-	-	-	-	-
9			-	-	-	-	-	-	-	-
10			-	-	-	-	-	-	-	-
11			-	-	-	-	-	-	-	-
12			-	-	-	-	-	-	-	-
13			-	-	-	-	-	-	-	-
14			-	-	-	-	-	-	-	-
15			-	-	-	-	-	-	-	-
16			-	-	-	-	-	-	-	-
17			-	-	-	-	-	-	-	-
18			-	-	-	-	-	-	-	-
uiStartup			-	-	1681	1393	2201	182	1830	2027
load			-	-	1444	1199	1825	133	1524	1711
domContentLoaded			-	-	1444	1199	1824	133	1524	1710
domInteractive			-	-	102	29	311	49	133	199
firstPaint			-	-	-	-	-	-	-	-
backgroundConnect			-	-	69	23	217	48	88	185
firstReactRender			-	-	14	11	49	4	15	18
initialActions			-	-	1	0	3	1	2	2
loadScripts			-	-	1407	1171	1808	121	1469	1654
setupStore			-	-	17	6	184	27	12	67
numNetworkReqs			-	-	23	12	82	17	18	75
19			-	-	-	-	-	-	-	-
Webpack	Power User Home	0	-	-	-	-	-	-	-	-
		1	-	-	-	-	-	-	-	-
		2	-	-	-	-	-	-	-	-
		3	-	-	-	-	-	-	-	-
		4	-	-	-	-	-	-	-	-
		5	-	-	-	-	-	-	-	-
		6	-	-	-	-	-	-	-	-
		7	-	-	-	-	-	-	-	-
		8	-	-	-	-	-	-	-	-
		9	-	-	-	-	-	-	-	-
		10	-	-	-	-	-	-	-	-
		11	-	-	-	-	-	-	-	-
		12	-	-	-	-	-	-	-	-
		13	-	-	-	-	-	-	-	-
		14	-	-	-	-	-	-	-	-
		15	-	-	-	-	-	-	-	-
		16	-	-	-	-	-	-	-	-
		17	-	-	-	-	-	-	-	-
		18	-	-	-	-	-	-	-	-
		uiStartup	-	-	3147	2211	9531	1142	3283	4401
		load	-	-	1797	1304	7150	947	1828	2820
		domContentLoaded	-	-	1796	1303	7150	948	1827	2820
		domInteractive	-	-	178	33	5708	568	119	490
		firstPaint	-	-	-	-	-	-	-	-
		backgroundConnect	-	-	319	111	1362	271	298	960
		firstReactRender	-	-	22	15	68	8	24	31
		initialActions	-	-	2	1	7	1	2	3
		loadScripts	-	-	1746	1285	7118	946	1734	2793
		setupStore	-	-	144	8	736	193	184	663
		numNetworkReqs	-	-	70	35	229	43	85	180
		19	-	-	-	-	-	-	-	-

📊 Page Load Benchmark Results

Current Commit: 95c6fad | Date: 2/3/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±39ms) 🟡 | historical mean value: 1.02s ⬆️ (historical data)
domContentLoaded-> current mean value: 725ms (±36ms) 🟢 | historical mean value: 712ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 77ms (±12ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	39ms	1.01s	1.33s	1.06s	1.33s
domContentLoaded	725ms	36ms	701ms	997ms	745ms	997ms
firstPaint	77ms	12ms	64ms	192ms	84ms	192ms
firstContentfulPaint	77ms	12ms	64ms	192ms	84ms	192ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs

background: 58 Bytes (0%)
ui: 43 Bytes (0%)
common: 20 Bytes (0%)

FrederikBolding temporarily deployed to pr-comment February 3, 2026 09:47 — with GitHub Actions Inactive

metamaskbot added the team-core-platform Core Platform team label Feb 3, 2026

github-actions bot added the size-XS label Feb 3, 2026

metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Feb 3, 2026

FrederikBolding changed the title ~~fix: Prevent Snap crashing when clicking buttons without names~~ fix: Prevent Snap crashing when clicking buttons without names cp-13.17.0 Feb 3, 2026

FrederikBolding commented Feb 3, 2026

View reviewed changes

ui/components/app/snaps/snap-ui-renderer/components/form.test.ts Outdated Show resolved Hide resolved

FrederikBolding had a problem deploying to pr-comment February 3, 2026 10:00 — with GitHub Actions Error

FrederikBolding marked this pull request as ready for review February 3, 2026 10:00

FrederikBolding requested a review from a team as a code owner February 3, 2026 10:00

FrederikBolding temporarily deployed to pr-comment February 3, 2026 10:00 — with GitHub Actions Inactive

FrederikBolding requested review from GuillaumeRx and Mrtenz February 3, 2026 10:01

Mrtenz reviewed Feb 3, 2026

View reviewed changes

ui/contexts/snaps/snap-interface.tsx Show resolved Hide resolved

FrederikBolding temporarily deployed to pr-comment February 3, 2026 10:07 — with GitHub Actions Inactive

Mrtenz previously approved these changes Feb 3, 2026

View reviewed changes

FrederikBolding requested a review from Mrtenz February 3, 2026 10:07

FrederikBolding enabled auto-merge February 3, 2026 10:08

github-actions bot added size-S and removed size-XS labels Feb 3, 2026

FrederikBolding added 4 commits February 3, 2026 11:11

fix: Prevent Snap crashing when clicking buttons without names

ebe109a

Reverse condition

04c4226

Add separate test

815e9fc

Add comment

39c6a7d

FrederikBolding force-pushed the fb/snaps-ui-crash branch from a95a429 to 39c6a7d Compare February 3, 2026 10:11

FrederikBolding temporarily deployed to pr-comment February 3, 2026 10:11 — with GitHub Actions Inactive

GuillaumeRx previously approved these changes Feb 3, 2026

View reviewed changes

cursor bot reviewed Feb 3, 2026

View reviewed changes

ui/components/app/snaps/snap-ui-renderer/components/form.test.ts Outdated Show resolved Hide resolved

Remove unused var

95c6fad

FrederikBolding dismissed GuillaumeRx’s stale review via 95c6fad February 3, 2026 10:24

FrederikBolding dismissed Mrtenz’s stale review via 95c6fad February 3, 2026 10:24

FrederikBolding temporarily deployed to pr-comment February 3, 2026 10:24 — with GitHub Actions Inactive

FrederikBolding requested a review from GuillaumeRx February 3, 2026 10:27

GuillaumeRx approved these changes Feb 3, 2026

View reviewed changes

cryptodev-2s approved these changes Feb 3, 2026

View reviewed changes

FrederikBolding temporarily deployed to pr-comment February 3, 2026 10:54 — with GitHub Actions Inactive

FrederikBolding added this pull request to the merge queue Feb 3, 2026

Merged via the queue into main with commit 094fa7f Feb 3, 2026
179 checks passed

FrederikBolding deleted the fb/snaps-ui-crash branch February 3, 2026 11:38

github-actions bot locked and limited conversation to collaborators Feb 3, 2026

metamaskbot added the release-13.18.0 Issue or pull request that will be included in release 13.18.0 label Feb 3, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Prevent Snap crashing when clicking buttons without names cp-13.17.0 #39727

fix: Prevent Snap crashing when clicking buttons without names cp-13.17.0 #39727

FrederikBolding commented Feb 3, 2026 •

edited by cursor bot

Loading

Uh oh!

metamaskbotv2 bot commented Feb 3, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

cursor bot left a comment

Uh oh!

Uh oh!

metamaskbotv2 bot commented Feb 3, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

fix: Prevent Snap crashing when clicking buttons without names cp-13.17.0 #39727

fix: Prevent Snap crashing when clicking buttons without names cp-13.17.0 #39727

Conversation

FrederikBolding commented Feb 3, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Uh oh!

metamaskbotv2 bot commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

metamaskbotv2 bot commented Feb 3, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

FrederikBolding commented Feb 3, 2026 •

edited by cursor bot

Loading

metamaskbotv2 bot commented Feb 3, 2026 •

edited

Loading