feat: Improve account from/to display on confirmation page#40200
Open
feat: Improve account from/to display on confirmation page#40200
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (6 files, +847 -467)
🧪 @MetaMask/qa (1 files, +11 -6)
|
ui/pages/confirmations/components/confirm/info/token-transfer/transaction-flow-section.tsx
Outdated
Show resolved
Hide resolved
ui/pages/confirmations/components/confirm/info/token-transfer/transaction-flow-section.tsx
Outdated
Show resolved
Hide resolved
ui/pages/confirmations/components/confirm/info/token-transfer/transaction-flow-section.test.tsx
Show resolved
Hide resolved
Contributor
Builds ready [b2b247b]
UI Startup Metrics (1392 ± 102 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
…/metamask-extension into confirm_acc_section_fix
ui/pages/confirmations/components/confirm/info/token-transfer/transaction-flow-section.tsx
Outdated
Show resolved
Hide resolved
ui/pages/confirmations/components/confirm/info/token-transfer/transaction-flow-section.tsx
Outdated
Show resolved
Hide resolved
…/metamask-extension into confirm_acc_section_fix
Contributor
Builds ready [9e0f7bc]
⚡ Performance Benchmarks (1368 ± 101 ms)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
ui/pages/confirmations/components/confirm/info/token-transfer/transaction-flow-section.tsx
Show resolved
Hide resolved
…/metamask-extension into confirm_acc_section_fix
Contributor
Builds ready [28e76cf]
⚡ Performance Benchmarks (1363 ± 102 ms)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
ui/pages/confirmations/components/confirm/info/token-transfer/transaction-flow-section.tsx
Show resolved
Hide resolved
ui/pages/confirmations/components/confirm/info/token-transfer/transaction-flow-section.tsx
Show resolved
Hide resolved
Contributor
Builds ready [66459a0]
⚡ Performance Benchmarks (1369 ± 97 ms)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improvements in account from / to section on top of confirmation page.
Changelog
CHANGELOG entry:
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/7004
Manual testing steps
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Touches confirmation UI rendering and how addresses/names are displayed and interacted with; mistakes could confuse users or break petname/save flows, but no core transaction/auth logic changes.
Overview
Improves the confirmations From/To transaction flow header by switching to a new
ConfirmInfoRowAddressDisplaycomponent that renders checksum addresses with middle truncation, trust/identicon cues, optional avatars, and a clickable (non-account) display name that opensNameDetails.Updates
TransactionFlowSectionto useuseDisplayName(including wallet subtitle support) and a new vertical layout with separate sender/recipient rows and avatars, and adjusts E2E/unit tests and snapshots to assert against the newconfirm-info-row-display-nameelement/behavior.Written by Cursor Bugbot for commit 66459a0. This will update automatically on new commits. Configure here.