chore: bump @metamask/core-backend and set up ApiPlatformClient#40262
Merged
chore: bump @metamask/core-backend and set up ApiPlatformClient#40262
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
n3ps
commented
Feb 20, 2026
| }; | ||
|
|
||
| export const queries = { | ||
| transactions: ( |
Contributor
There was a problem hiding this comment.
I wonder if we should have a dedicated directory for TQ primitives outside of ui/helpers/ e.g. ui/queries/
Contributor
Author
There was a problem hiding this comment.
Next PR! Have follow ups to this file too
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
n3ps
commented
Feb 20, 2026
| queryKey, | ||
| queryFn: ({ pageParam, signal }) => { | ||
| const { queryFn: fetchPage } = | ||
| apiClient.accounts.getV4MultiAccountTransactionsQueryOptions( |
Contributor
Author
There was a problem hiding this comment.
- Replaced with apiClient which abstracts the API details
Contributor
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/core-extension-ux (1 files, +28 -32)
📜 @MetaMask/policy-reviewers (12 files, +168 -8)
Tip Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers. |
Contributor
Builds ready [ce4be31]
UI Startup Metrics (1290 ± 89 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
n3ps
commented
Feb 20, 2026
| "@metamask/contract-metadata": "^2.5.0", | ||
| "@metamask/controller-utils": "^11.18.0", | ||
| "@metamask/core-backend": "^5.0.0", | ||
| "@metamask/core-backend": "^6.0.0", |
Contributor
Author
There was a problem hiding this comment.
Main point of interest
n3ps
commented
Feb 20, 2026
| * Cached API client instance. | ||
| */ | ||
| let apiClient: ApiPlatformClient | null = null; | ||
| let apiClient: AssetsControllerOptions['queryApiClient'] | null = null; |
Contributor
Author
There was a problem hiding this comment.
Interim since asset-controller needs a version bump of core-backend
MajorLift
previously approved these changes
Feb 20, 2026
Contributor
MajorLift
left a comment
MajorLift
left a comment
There was a problem hiding this comment.
Approving for @MetaMask/policy-reviewers
Comment on lines
+1863
to
+1874
| "@metamask/core-backend>@tanstack/query-core": { | ||
| "globals": { | ||
| "AbortController": true, | ||
| "addEventListener": true, | ||
| "clearInterval": true, | ||
| "clearTimeout": true, | ||
| "console.error": true, | ||
| "document": true, | ||
| "removeEventListener": true, | ||
| "setInterval": true, | ||
| "setTimeout": true | ||
| }, |
Contributor
There was a problem hiding this comment.
Overrides for @tanstack/query-core v5 already applied in main for all builds (search results):
"@metamask/core-backend>@tanstack/query-core": {
"globals": {
"document": false,
"document.visibilityState": true,
"addEventListener": false
}
},
Comment on lines
+742
to
+746
| "@metamask/core-backend": { | ||
| "globals": { | ||
| "URL": true, | ||
| "fetch": true | ||
| }, |
Contributor
There was a problem hiding this comment.
Safe:
- Internal packages.
- Required for key functionality as data service.
Comment on lines
+1123
to
+1130
| "@metamask/assets-controller>@metamask/core-backend": { | ||
| "globals": { | ||
| "URL": true, | ||
| "WebSocket": true, | ||
| "clearTimeout": true, | ||
| "fetch": true, | ||
| "setTimeout": true | ||
| }, |
Contributor
There was a problem hiding this comment.
Safe:
- Internal packages.
- Required for key functionality as data service.
Contributor
Builds ready [8265865]
⚡ Performance Benchmarks (1603 ± 126 ms)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
Builds ready [870c57a]
⚡ Performance Benchmarks (1352 ± 103 ms)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
MajorLift
previously approved these changes
Feb 20, 2026
Contributor
MajorLift
left a comment
MajorLift
left a comment
There was a problem hiding this comment.
Could we edit the commit message (pr title) to something like
refactor: bump
@metamask/core-backendto^6.0.0and set upApiPlatformClientfor transactions query
and also fill out the pr description changelog as well? (with the package bump noted)
This should be helpful for the release engineer and for ppl creating core releases who might need to find the commit where the core-backend bump landed.
Otherwise lgtm!
n3ps
changed the title
n3ps
changed the title
NidhiKJha
previously approved these changes
Feb 20, 2026
vinnyhoward
approved these changes
Feb 20, 2026
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
MajorLift
approved these changes
Feb 20, 2026
Contributor
Builds ready [6a5dd10]
⚡ Performance Benchmarks (1404 ± 110 ms)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
| return (method: string): Promise<T | undefined | string> => { | ||
| if (method === 'getBearerToken') { | ||
| return Promise.resolve('mock-bearer-token-for-tests'); | ||
| } |
There was a problem hiding this comment.
Hardcoded mock shadows custom getBearerToken in test requests
Low Severity
The hardcoded getBearerToken check in createMockImplementation takes precedence over the requests map. Any future test passing { getBearerToken: customValue } in the requests argument will have that value silently ignored. The intercept belongs after the requests lookup (as a fallback) rather than before it.
Contributor
Builds ready [e998768]
⚡ Performance Benchmarks (1353 ± 87 ms)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
metamaskbot
added
the
release-13.21.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Start using the typed getV4MultiAccountTransactionsQueryOptions from core-backend
Part 1 of moving into using a shared query configuration
Part 2 needs an update on core-backend to handle RQ v4/v5 differences
Changelog
CHANGELOG entry: chore: bump @metamask/core-backend and set up ApiPlatformClient
Related issues
Fixes: N/A
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Changes the transaction activity data-fetching path and upgrades a core dependency, which could affect query keys/pagination and auth token handling despite being largely a refactor.
Overview
Upgrades
@metamask/core-backendto^6.0.0and shifts multiaccount transaction fetching to usecreateApiPlatformClient+ the typedgetV4MultiAccountTransactionsQueryOptionsrather than a hand-rolledfetchwrapper.This removes the shared
shared/lib/api-client.tsandshared/lib/multichain/queries.ts, adds UI-scopedui/helpers/api-client.tsandui/helpers/queries.ts, and updates the Activity v2 hooks to build CAIP-formatted account addresses and prefetch via the new query options.Updates
assets-controller-initto type/cast its cached API client asAssetsControllerOptions['queryApiClient'], adjusts integration test mocks to return a token forgetBearerToken, and tightens LavaMoat policies to attributecore-backendaccess through@metamask/assets-controller(plus MV3 allowances for@metamask/core-backend).Written by Cursor Bugbot for commit e998768. This will update automatically on new commits. Configure here.