release(runway): cherry-pick feat: cp-13.20.0 added vertical scroll to drawer#40326
Merged
chloeYue merged 2 commits intorelease/13.20.0from Feb 23, 2026
Merged
Conversation
…o drawer (#40301) This PR is to add vertical scroll to drawer ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: adds vertical scroll to drawer ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to small window size for full screen 2. check drawer is scrollable ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** https://github.com/user-attachments/assets/05057dc9-feec-4742-8460-da12c21436d1 ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > UI-only styling/layout changes localized to the global menu drawer; main risk is regressions in drawer sizing/positioning across fullscreen vs sidepanel views. > > **Overview** > Improves `GlobalMenuDrawer` fullscreen positioning by consistently applying a `90px` top offset (for the logo) to both the backdrop and the drawer panel, and by explicitly pinning the panel with `top`/`bottom` instead of relying on `h-full`/`inset` classes. > > Updates the drawer’s internal flex layout (`min-h-0`, `flex-shrink-0`, and `overflow-y-auto` + padding) so long content can scroll vertically and the header/close button stays fixed without causing overflow glitches. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit b58db8a. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Contributor
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/core-extension-ux (1 files, +13 -12)
|
Contributor
Builds ready [21f3243]
UI Startup Metrics (1362 ± 99 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
|
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
Builds ready [9d2b59a]
UI Startup Metrics (1362 ± 101 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to add vertical scroll to drawer
Changelog
CHANGELOG entry: adds vertical scroll to drawer
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Screen.Recording.2026-02-20.at.6.03.35.PM.mov
Pre-merge author checklist
Docs and MetaMask
Extension Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Note
Low Risk
CSS/layout-only changes scoped to the global menu drawer; main risk is minor visual regressions across fullscreen/sidepanel breakpoints.
Overview
Adjusts
GlobalMenuDrawerlayout/styling to support reliable vertical scrolling and proper sizing in fullscreen vs sidepanel.This refines fullscreen top offset handling (explicit 90px logo offset), ensures the drawer panel always spans
top/bottom, and addsmin-h-0,flex-shrink-0, and bottom padding so the header stays fixed while the content area scrolls correctly.Written by Cursor Bugbot for commit 9d2b59a. This will update automatically on new commits. Configure here.
cb1f3f9