Skip to content

Comments

test: remove withSolanaAccountSnap as we have default Multichain support in all our e2e#40327

Draft
seaona wants to merge 5 commits intomainfrom
refactor-withsolanaaccount
Draft

test: remove withSolanaAccountSnap as we have default Multichain support in all our e2e#40327
seaona wants to merge 5 commits intomainfrom
refactor-withsolanaaccount

Conversation

@seaona
Copy link
Member

@seaona seaona commented Feb 23, 2026

Description

This PR removes the withSolanaAccountSnapmethod, as we have default Multichain support in all our e2e, so we don't need the duplicated setup (which is already set by default).
This simplifies test setup and makes them also easier to debug and maintain.

Open in GitHub Codespaces

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@metamaskbot metamaskbot added the team-qa QA team label Feb 23, 2026
@seaona seaona added skip-e2e-quality-gate no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed e2e-maintenance and removed team-qa QA team labels Feb 23, 2026
@seaona seaona self-assigned this Feb 23, 2026
@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Feb 23, 2026

✨ Files requiring CODEOWNER review ✨

🫰 @MetaMask/core-platform (1 files, +11 -4)
  • 📁 test/
    • 📁 e2e/
      • 📁 flask/
        • 📁 snaps/
          • 📄 test-snap-protocol.spec.ts +11 -4

🧪 @MetaMask/qa (3 files, +44 -3)
  • 📁 test/
    • 📁 e2e/
      • 📁 page-objects/
        • 📁 flows/
          • 📄 add-account.flow.ts +40 -0
        • 📁 pages/
          • 📁 home/
            • 📄 homepage.ts +4 -1
            • 📄 non-evm-homepage.ts +0 -2

👨‍🔧 @MetaMask/wallet-integrations (2 files, +46 -27)
  • 📁 test/
    • 📁 e2e/
      • 📁 flask/
        • 📁 multichain-api/
          • 📁 non-evm/
            • 📄 wallet_createSession.spec.ts +22 -12
            • 📄 wallet_invokeMethod.spec.ts +24 -15

@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Feb 23, 2026

Builds ready [c4700df]
⚡ Performance Benchmarks (1353 ± 98 ms)
👆 Interaction Benchmarks
ActionMetricMean (ms)Std Dev (ms)P75 (ms)P95 (ms)
Load New Accountload_new_account2646271271
total2646271271
Confirm Txconfirm_tx6033260366036
total6033260366036
Bridge User Actionsbridge_load_page1998204210
bridge_load_asset_picker19111197209
bridge_search_token6911691693
total10731210751092
🔌 Startup Benchmarks
BuildMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
Chrome Browserify Startup Standard HomeuiStartup1353115815939813941536
load113995313348711871308
domContentLoaded113194713268611811300
domInteractive251596192180
firstPaint195601205167211282
backgroundConnect20218624310205220
firstReactRender17124941825
initialActions104113
loadScripts9467591138869991116
setupStore1275161318
numNetworkReqs312297212290
Chrome Browserify Startup Power User HomeuiStartup19941387870996718853580
load11581021180114711671484
domContentLoaded11431013172914111541473
domInteractive3518188273571
firstPaint232702372232265309
backgroundConnect42527235854563291192
firstReactRender25175382841
initialActions105112
loadScripts92579414911399401259
setupStore1563661831
numNetworkReqs64351492669129
Chrome Webpack Startup Standard HomeuiStartup8556941307998991056
load731615113689788859
domContentLoaded725610112788782851
domInteractive271588192377
firstPaint1116242260136201
backgroundConnect26194362938
firstReactRender17123652027
initialActions103112
loadScripts723609111987780844
setupStore1153251320
numNetworkReqs3122101212588
Chrome Webpack Startup Power User HomeuiStartup1235944255221113151646
load71261511181067031006
domContentLoaded7036081105106692999
domInteractive35181542732108
firstPaint1356357788146297
backgroundConnect17512850958171311
firstReactRender22173432428
initialActions102011
loadScripts7006061087104690989
setupStore1364561418
numNetworkReqs1133627055149220
Firefox Browserify Startup Standard HomeuiStartup16321361286723816592108
load13781166264620614171645
domContentLoaded13771161264620714171645
domInteractive8027137213587140
firstPaint------
backgroundConnect57272772961100
firstReactRender13111911415
initialActions103112
loadScripts13511151262420113921599
setupStore176186241536
numNetworkReqs3220100212793
Firefox Browserify Startup Power User HomeuiStartup27832008415741529263588
load15951339248526816242203
domContentLoaded15951339248526816182203
domInteractive14035776133131440
firstPaint------
backgroundConnect3131101011253374916
firstReactRender201465101926
initialActions213122
loadScripts15551316246125815822154
setupStore1327815188127603
numNetworkReqs68291593587142
Firefox Webpack Startup Standard HomeuiStartup18141464336932618152130
load15041247297622615131662
domContentLoaded15041247297622615131662
domInteractive124301607159133232
firstPaint------
backgroundConnect66282353174122
firstReactRender17122631824
initialActions103122
loadScripts14791226295922714911640
setupStore37614191422157
numNetworkReqs312091172777
Firefox Webpack Startup Power User HomeuiStartup27952083577549129573630
load16391315426037417112151
domContentLoaded16381315426037417102151
domInteractive15932836157160586
firstPaint------
backgroundConnect3291171370270357983
firstReactRender22166362530
initialActions203123
loadScripts15951286422336016652049
setupStore16710691187203567
numNetworkReqs75302273897143
🧭 User Journey Benchmarks
BenchmarkMetricMean (ms)Std Dev (ms)P75 (ms)P95 (ms)
Onboarding Import WalletimportWalletToSocialScreen2191219220
srpButtonToSrpForm9319393
confirmSrpToPwForm2112222
pwFormToMetricsScreen1501515
metricsToWalletReadyScreen1611717
doneButtonToHomeScreen63269599752
openAccountMenuToAccountListLoaded78582878587901
total88537888658976
Onboarding New WalletcreateWalletToSocialScreen2215225228
srpButtonToPwForm1041105107
createPwToRecoveryScreen8088
skipBackupToMetricsScreen3413435
agreeButtonToOnboardingSuccess1611717
doneButtonToAssetList7492008681026
total113420212581412
Asset DetailsassetClickToPriceChart49125471
total49125471
Solana Asset DetailsassetClickToPriceChart4945253
total4945253
Import Srp HomeloginToHomeScreen20256020692087
openAccountMenuAfterLogin5125254
homeAfterImportWithNewWallet290323831543223
total503022051395344
Send TransactionsopenSendPageFromHome27103939
selectTokenToSendFormLoaded1901919
reviewTransactionToConfirmationPage8564857861
total90511912919
SwapopenSwapPageFromHome1177121126
fetchAndDisplaySwapQuotes46617347294735
total47777848424861
🌐 Dapp Page Load Benchmarks

Current Commit: c4700df | Date: 2/23/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.06s (±47ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 747ms (±61ms) 🟢 | historical mean value: 727ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 91ms (±128ms) 🟢 | historical mean value: 80ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.06s 47ms 1.04s 1.44s 1.08s 1.44s
domContentLoaded 747ms 61ms 719ms 1.30s 758ms 1.30s
firstPaint 91ms 128ms 64ms 1.36s 88ms 1.36s
firstContentfulPaint 91ms 128ms 64ms 1.36s 88ms 1.36s
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs
  • background: 58 Bytes (0%)
  • ui: 5 Bytes (0%)
  • common: 20 Bytes (0%)

@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Feb 23, 2026

Builds ready [f67bab3]
⚡ Performance Benchmarks (1394 ± 109 ms)
👆 Interaction Benchmarks
ActionMetricMean (ms)Std Dev (ms)P75 (ms)P95 (ms)
Load New Accountload_new_account29018298312
total29018298312
Confirm Txconfirm_tx6054260536056
total6054260536056
Bridge User Actionsbridge_load_page27715286297
bridge_load_asset_picker22034232271
bridge_search_token73830756790
total12175812501285
🔌 Startup Benchmarks
BuildMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
Chrome Browserify Startup Standard HomeuiStartup13941165165410914731585
load1191984140510212661371
domContentLoaded1184977140010112591360
domInteractive2716115202481
firstPaint1426836772198251
backgroundConnect20218624110205226
firstReactRender18133342026
initialActions108112
loadScripts998791121110110781173
setupStore1364261524
numNetworkReqs312291192585
Chrome Browserify Startup Power User HomeuiStartup2437140710649169221844502
load11801016163413412191518
domContentLoaded11641008162513412011510
domInteractive3519169263395
firstPaint209821556162264351
backgroundConnect840255879814953432667
firstReactRender24155272538
initialActions104112
loadScripts95881014231299891268
setupStore1675491833
numNetworkReqs72351632781128
Chrome Webpack Startup Standard HomeuiStartup87267511581079391074
load75160092794823892
domContentLoaded74559792293812887
domInteractive2815107212485
firstPaint1206137466152227
backgroundConnect26187882740
firstReactRender18124171934
initialActions103112
loadScripts74159592092810885
setupStore1174551224
numNetworkReqs322290202586
Chrome Webpack Startup Power User HomeuiStartup1229929241828012931775
load721626106996731969
domContentLoaded710621105797719962
domInteractive3518122213490
firstPaint1586268698212322
backgroundConnect187145951112169298
firstReactRender22174942428
initialActions102011
loadScripts707619104595716955
setupStore1244661417
numNetworkReqs1244523940146190
Firefox Browserify Startup Standard HomeuiStartup16881424282022917162081
load14241195256720214691668
domContentLoaded14221195256620314691667
domInteractive923087899106169
firstPaint------
backgroundConnect5931149196490
firstReactRender14112011416
initialActions102022
loadScripts13961174246019514431627
setupStore217293361639
numNetworkReqs311999202787
Firefox Browserify Startup Power User HomeuiStartup27792079674750029363298
load16121317543142716881934
domContentLoaded16111316543142716871934
domInteractive15136521117154398
firstPaint------
backgroundConnect3051131197225371782
firstReactRender18147471922
initialActions207122
loadScripts15771294540142516501908
setupStore1089689146107468
numNetworkReqs72272104087160
Firefox Webpack Startup Standard HomeuiStartup17651483332731817662096
load14781274297125414821586
domContentLoaded14771274297025414821585
domInteractive953022640131158
firstPaint------
backgroundConnect63241943368138
firstReactRender17136571624
initialActions107122
loadScripts14531252293725214571542
setupStore227185291782
numNetworkReqs312097172768
Firefox Webpack Startup Power User HomeuiStartup27532086617549528803545
load15931311483340116352089
domContentLoaded15931305483340116352089
domInteractive14232775143150394
firstPaint------
backgroundConnect3571093494410398906
firstReactRender21158172329
initialActions203122
loadScripts15231287256821916062003
setupStore17510752185230586
numNetworkReqs69292254086145
🧭 User Journey Benchmarks
BenchmarkMetricMean (ms)Std Dev (ms)P75 (ms)P95 (ms)
Onboarding Import WalletimportWalletToSocialScreen2192221222
srpButtonToSrpForm9529597
confirmSrpToPwForm2212323
pwFormToMetricsScreen1601616
metricsToWalletReadyScreen1701717
doneButtonToHomeScreen127111112801420
openAccountMenuToAccountListLoaded711910172627262
total881914388359047
Onboarding New WalletcreateWalletToSocialScreen2245228230
srpButtonToPwForm1012102105
createPwToRecoveryScreen8088
skipBackupToMetricsScreen3413535
agreeButtonToOnboardingSuccess1501515
doneButtonToAssetList62011629629
total9981410141014
Asset DetailsassetClickToPriceChart60218085
total60218085
Solana Asset DetailsassetClickToPriceChart5926162
total5926162
Import Srp HomeloginToHomeScreen221116422812436
openAccountMenuAfterLogin3633641
homeAfterImportWithNewWallet263433928223205
total48258449344934
Send TransactionsopenSendPageFromHome1701718
selectTokenToSendFormLoaded2102121
reviewTransactionToConfirmationPage8541855855
total8987907907
SwapopenSwapPageFromHome13520141163
fetchAndDisplaySwapQuotes46258445784771
total47309547154881
🌐 Dapp Page Load Benchmarks

Current Commit: f67bab3 | Date: 2/23/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±61ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 730ms (±71ms) 🟢 | historical mean value: 729ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 89ms (±125ms) 🟢 | historical mean value: 80ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 61ms 1.01s 1.43s 1.09s 1.43s
domContentLoaded 730ms 71ms 702ms 1.27s 772ms 1.27s
firstPaint 89ms 125ms 56ms 1.34s 84ms 1.34s
firstContentfulPaint 89ms 125ms 56ms 1.34s 84ms 1.34s
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -204 Bytes (0%)
  • ui: -3 Bytes (0%)
  • common: 3.06 KiB (0.03%)

@seaona seaona changed the title test: refactor withsolanaaccount test: remove withSolanaAccountSnap as we have default Multichain support in all our e2e Feb 23, 2026
@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Feb 23, 2026

Builds ready [c7d5849]
⚡ Performance Benchmarks (1390 ± 92 ms)
👆 Interaction Benchmarks
ActionMetricMean (ms)Std Dev (ms)P75 (ms)P95 (ms)
Load New Accountload_new_account2645265271
total2645265271
Confirm Txconfirm_tx6056560616064
total6056560616064
Bridge User Actionsbridge_load_page24413254258
bridge_load_asset_picker1673171171
bridge_search_token7064708711
total11192111331145
🔌 Startup Benchmarks
BuildMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
Chrome Browserify Startup Standard HomeuiStartup1390118716279214401550
load118599113828212371320
domContentLoaded117798613748212281311
domInteractive2817117202384
firstPaint150651202129204262
backgroundConnect21019128617213239
firstReactRender18135251924
initialActions106114
loadScripts98778511878310371127
setupStore1263141418
numNetworkReqs312289192283
Chrome Browserify Startup Power User HomeuiStartup2977141710368196838818158
load11911003187213312131476
domContentLoaded1172995180612411891420
domInteractive3318184273090
firstPaint222831557226265374
backgroundConnect12382488658174118353473
firstReactRender23154262634
initialActions105112
loadScripts97179016051219881227
setupStore1564471631
numNetworkReqs80331562594116
Chrome Webpack Startup Standard HomeuiStartup85068611221019151073
load72360692989783865
domContentLoaded71760192087779859
domInteractive2715115212381
firstPaint1125840064139212
backgroundConnect28178593143
firstReactRender19124572133
initialActions106112
loadScripts71559991886777856
setupStore1252641221
numNetworkReqs3122100212590
Chrome Webpack Startup Power User HomeuiStartup1296925262727113831728
load76667012831177641022
domContentLoaded75566312721177481014
domInteractive41191472937124
firstPaint1627075799180366
backgroundConnect2071361568189176337
firstReactRender23193632530
initialActions103111
loadScripts75266112631157461006
setupStore1354561519
numNetworkReqs86391792896150
Firefox Browserify Startup Standard HomeuiStartup18121454289525218082417
load15211233231419915332027
domContentLoaded15201233231420015322026
domInteractive1003338161132238
firstPaint------
backgroundConnect71332583568142
firstReactRender15122111517
initialActions106122
loadScripts14901214228419414991945
setupStore238195281956
numNetworkReqs321995202784
Firefox Browserify Startup Power User HomeuiStartup28632100806666829783529
load16471319657158916182188
domContentLoaded16461319657158916182188
domInteractive179451829219170425
firstPaint------
backgroundConnect4031261493291541924
firstReactRender18146761825
initialActions203122
loadScripts16031285653358615902146
setupStore17610750198246586
numNetworkReqs84332113797167
Firefox Webpack Startup Standard HomeuiStartup16701415317824616931977
load14181189287222214491548
domContentLoaded14171188287122214481547
domInteractive893036756127185
firstPaint------
backgroundConnect57242083259103
firstReactRender15122831520
initialActions102112
loadScripts13941168283721914241520
setupStore186139201447
numNetworkReqs301995172772
Firefox Webpack Startup Power User HomeuiStartup27941931612647529663469
load16241301477240516442186
domContentLoaded16241300477240516442185
domInteractive185501001175220573
firstPaint------
backgroundConnect42412714163036061076
firstReactRender21157472229
initialActions204123
loadScripts15791284474240415712164
setupStore15716725182196590
numNetworkReqs84332404881216
🧭 User Journey Benchmarks
BenchmarkMetricMean (ms)Std Dev (ms)P75 (ms)P95 (ms)
Onboarding Import WalletimportWalletToSocialScreen2191220220
srpButtonToSrpForm9419495
confirmSrpToPwForm2212223
pwFormToMetricsScreen1501516
metricsToWalletReadyScreen1611618
doneButtonToHomeScreen87527711911217
openAccountMenuToAccountListLoaded732652876797834
total872010187878849
Onboarding New WalletcreateWalletToSocialScreen2192219223
srpButtonToPwForm1042106106
createPwToRecoveryScreen8088
skipBackupToMetricsScreen3413436
agreeButtonToOnboardingSuccess1511516
doneButtonToAssetList60817607635
total992239831031
Asset DetailsassetClickToPriceChart4173852
total4173852
Solana Asset DetailsassetClickToPriceChart4614647
total4614647
Import Srp HomeloginToHomeScreen18712618921904
openAccountMenuAfterLogin4124243
homeAfterImportWithNewWallet258019627672779
total449517046464669
Send TransactionsopenSendPageFromHome1811719
selectTokenToSendFormLoaded1901919
reviewTransactionToConfirmationPage8483850852
total8968902908
SwapopenSwapPageFromHome1169124126
fetchAndDisplaySwapQuotes4572345724575
total4689946944700
🌐 Dapp Page Load Benchmarks

Current Commit: c7d5849 | Date: 2/23/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±39ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 725ms (±36ms) 🟢 | historical mean value: 735ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 78ms (±11ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 39ms 1.01s 1.33s 1.06s 1.33s
domContentLoaded 725ms 36ms 697ms 995ms 746ms 995ms
firstPaint 78ms 11ms 60ms 176ms 84ms 176ms
firstContentfulPaint 78ms 11ms 60ms 176ms 84ms 176ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 52.02 KiB (1.2%)
  • ui: -146 Bytes (0%)
  • common: 11.28 KiB (0.1%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e-maintenance no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed size-XL skip-e2e-quality-gate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants