test: remove withSolanaAccountSnap as we have default Multichain support in all our e2e#40327
Draft
test: remove withSolanaAccountSnap as we have default Multichain support in all our e2e#40327
withSolanaAccountSnap as we have default Multichain support in all our e2e#40327Conversation
Contributor
✨ Files requiring CODEOWNER review ✨🫰 @MetaMask/core-platform (1 files, +11 -4)
🧪 @MetaMask/qa (3 files, +44 -3)
👨🔧 @MetaMask/wallet-integrations (2 files, +46 -27)
|
Contributor
Builds ready [c4700df]
⚡ Performance Benchmarks (1353 ± 98 ms)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
Contributor
Builds ready [f67bab3]
⚡ Performance Benchmarks (1394 ± 109 ms)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
withSolanaAccountSnap as we have default Multichain support in all our e2e
Contributor
Builds ready [c7d5849]
⚡ Performance Benchmarks (1390 ± 92 ms)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the
withSolanaAccountSnapmethod, as we have default Multichain support in all our e2e, so we don't need the duplicated setup (which is already set by default).This simplifies test setup and makes them also easier to debug and maintain.
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist