Skip to content

Comments

fix: align date year format cp-13.20.0#40329

Merged
n3ps merged 1 commit intomainfrom
n3ps/fix-date-year
Feb 23, 2026
Merged

fix: align date year format cp-13.20.0#40329
n3ps merged 1 commit intomainfrom
n3ps/fix-date-year

Conversation

@n3ps
Copy link
Contributor

@n3ps n3ps commented Feb 23, 2026

Description

Align the current and previous year format

Fixes a pre-existing bug that surfaced now that more rows are rendered

Open in GitHub Codespaces

Changelog

CHANGELOG entry: fix: activity year format

Related issues

Fixes: #40285

Manual testing steps

  1. Go to Activity tab
  2. Scroll past the year

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Single UI formatting change limited to activity date header rendering; no data, auth, or business-logic impact.

Overview
Aligns Activity list date headers to always include the year by changing the formatDateWithYearContext fallback format from MMM d to MMM d, y in activity-v2.

This fixes inconsistent display when scrolling across year boundaries (current year vs previous years).

Written by Cursor Bugbot for commit a1023e5. This will update automatically on new commits. Configure here.

@n3ps n3ps requested a review from a team as a code owner February 23, 2026 14:53
@n3ps n3ps added the team-core-extension-ux Core Extension UX team label Feb 23, 2026
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Feb 23, 2026

✨ Files requiring CODEOWNER review ✨

👨‍🔧 @MetaMask/core-extension-ux (1 files, +1 -1)
  • 📁 ui/
    • 📁 components/
      • 📁 multichain/
        • 📁 activity-v2/
          • 📄 activity-list.tsx +1 -1

@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Feb 23, 2026

Builds ready [a1023e5]
⚡ Performance Benchmarks (1395 ± 117 ms)
👆 Interaction Benchmarks
ActionMetricMean (ms)Std Dev (ms)P75 (ms)P95 (ms)
Load New Accountload_new_account29832322340
total29832322340
Confirm Txconfirm_tx6030460316036
total6030460316036
Bridge User Actionsbridge_load_page22425239264
bridge_load_asset_picker20836250252
bridge_search_token71821742746
total11506212091221
🔌 Startup Benchmarks
BuildMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
Chrome Browserify Startup Standard HomeuiStartup13951186182411714511612
load118598914919812441373
domContentLoaded117798314849712361354
domInteractive2716103192382
firstPaint156651197132205316
backgroundConnect20818437923209240
firstReactRender2013243231927
initialActions106113
loadScripts98779412889610461163
setupStore1364061522
numNetworkReqs312291192285
Chrome Browserify Startup Power User HomeuiStartup16701321217313317191918
load1111987157512311031454
domContentLoaded1092979156710910931374
domInteractive301988123251
firstPaint183691112123239311
backgroundConnect27824537121285318
firstReactRender26155992945
initialActions104112
loadScripts89578813481088931182
setupStore1775891839
numNetworkReqs5536129185597
Chrome Webpack Startup Standard HomeuiStartup81566211001018651004
load69957994489768847
domContentLoaded69457493889761840
domInteractive271599222289
firstPaint12657801114155250
backgroundConnect26156182942
firstReactRender17124052026
initialActions104112
loadScripts69157393588759834
setupStore1163041117
numNetworkReqs3122101212593
Chrome Webpack Startup Power User HomeuiStartup1206873163615212921517
load71061510741027011013
domContentLoaded70060910631026911004
domInteractive35171332634107
firstPaint1366549582156285
backgroundConnect17013030841172271
firstReactRender22173032428
initialActions103112
loadScripts698607105099689994
setupStore1355261420
numNetworkReqs1063825751137230
Firefox Browserify Startup Standard HomeuiStartup17211481291222817372124
load14491226267919714871663
domContentLoaded14471221267919714861662
domInteractive92341380136107138
firstPaint------
backgroundConnect64312833364116
firstReactRender14121911416
initialActions102122
loadScripts14201203265319314611599
setupStore2471743716142
numNetworkReqs321996212794
Firefox Browserify Startup Power User HomeuiStartup26742093348234827733380
load15851296224127217152139
domContentLoaded15851296224127217152139
domInteractive12738646133113506
firstPaint------
backgroundConnect232102836191202787
firstReactRender191469101827
initialActions207122
loadScripts15471274218825716812091
setupStore1197719162127544
numNetworkReqs58231453583135
Firefox Webpack Startup Standard HomeuiStartup16931448305722517221913
load14341207276221014561627
domContentLoaded14331206276121014551627
domInteractive832923253115195
firstPaint------
backgroundConnect58262072766107
firstReactRender15122631625
initialActions102012
loadScripts14081194272620614301556
setupStore196157231562
numNetworkReqs301988162772
Firefox Webpack Startup Power User HomeuiStartup27532042446246728163783
load16321355281831617742343
domContentLoaded16321355281831617742343
domInteractive12632738134110414
firstPaint------
backgroundConnect2391141143190220719
firstReactRender22156072430
initialActions217123
loadScripts15921323279130616972267
setupStore21971191263348792
numNetworkReqs58271903784132
🧭 User Journey Benchmarks
BenchmarkMetricMean (ms)Std Dev (ms)P75 (ms)P95 (ms)
Onboarding Import WalletimportWalletToSocialScreen2172219219
srpButtonToSrpForm9129293
confirmSrpToPwForm2102121
pwFormToMetricsScreen1501515
metricsToWalletReadyScreen1501616
doneButtonToHomeScreen113230313951427
openAccountMenuToAccountListLoaded702412270157207
total88074288648864
Onboarding New WalletcreateWalletToSocialScreen2201221222
srpButtonToPwForm1062108108
createPwToRecoveryScreen8099
skipBackupToMetricsScreen3613739
agreeButtonToOnboardingSuccess1701717
doneButtonToAssetList103634313181420
total143034117031807
Asset DetailsassetClickToPriceChart4464353
total4464353
Solana Asset DetailsassetClickToPriceChart4604646
total4604646
Import Srp HomeloginToHomeScreen19649820522056
openAccountMenuAfterLogin4544851
homeAfterImportWithNewWallet23854124252428
total445616545324694
Send TransactionsopenSendPageFromHome1711818
selectTokenToSendFormLoaded2132125
reviewTransactionToConfirmationPage8450845845
total89312903910
SwapopenSwapPageFromHome12713132150
fetchAndDisplaySwapQuotes527385362376395
total540085963556545
🌐 Dapp Page Load Benchmarks

Current Commit: a1023e5 | Date: 2/23/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±38ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 731ms (±35ms) 🟢 | historical mean value: 728ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 78ms (±11ms) 🟢 | historical mean value: 80ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 38ms 1.02s 1.33s 1.07s 1.33s
domContentLoaded 731ms 35ms 707ms 989ms 746ms 989ms
firstPaint 78ms 11ms 64ms 176ms 84ms 176ms
firstContentfulPaint 78ms 11ms 64ms 176ms 84ms 176ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs
  • background: 58 Bytes (0%)
  • ui: 8 Bytes (0%)
  • common: 20 Bytes (0%)

@n3ps n3ps changed the title fix: align date year format fix: align date year format cp-13.20.0 Feb 23, 2026
@n3ps n3ps added this pull request to the merge queue Feb 23, 2026
Merged via the queue into main with commit 04adfb2 Feb 23, 2026
355 of 358 checks passed
@n3ps n3ps deleted the n3ps/fix-date-year branch February 23, 2026 16:36
@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2026
@metamaskbot metamaskbot added the release-13.21.0 Issue or pull request that will be included in release 13.21.0 label Feb 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.21.0 Issue or pull request that will be included in release 13.21.0 size-XS team-core-extension-ux Core Extension UX team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Activity - Missing year field for transactions from previous years (ie 2025)

4 participants