perf: remove identities, lostIdentities, selectedAddress states from the PreferencesController#40417
Open
perf: remove identities, lostIdentities, selectedAddress states from the PreferencesController#40417
identities, lostIdentities, selectedAddress states from the PreferencesController#40417Conversation
… from the PreferencesController
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/extension-platform (2 files, +2 -8)
🧪 @MetaMask/qa (2 files, +2 -8)
👨🔧 @MetaMask/wallet-integrations (3 files, +14 -20)
|
hmalik88
changed the title
identities, lostIdentities, selectedAddress states from the PreferencesControlleridentities, lostIdentities, selectedAddress states from the PreferencesController
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
Builds ready [a30ed7d]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
Contributor
Builds ready [9622aa5]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
hmalik88
commented
Feb 27, 2026
| }); | ||
| }); | ||
|
|
||
| describe('setAccountLabel', () => { |
Contributor
Author
There was a problem hiding this comment.
Removed the test for this since it used identities, this method is also unused and only called in dead code. Will remove this in a follow up PR since removing in this PR blows the scope up too much.
Contributor
Builds ready [bd972df]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
Contributor
Builds ready [cd18de6]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
Contributor
Builds ready [096d879]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
Contributor
Builds ready [883e033]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removed usage of
identities,lostIdentities,selectedAddressstates across the extension. The main driver for this change was to prevent the preferences controller from iterating through the accounts in the accounts controller every time there was a state change. This was done to keep the identities states in sync with the internal accounts, identities is an artifact of how we used to handle accounts and these states can safely be removed.Changelog
CHANGELOG entry: null
Related issues
Fixes: N/A
Manual testing steps
Screenshots/Recordings
N/A
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Touches account-selection and metrics/backup codepaths while removing widely-referenced state fields, so regressions would mainly show up as wrong selected account or missing account counts in events/fixtures. Migration
198mitigates stale persisted data risk by deleting obsolete fields from stored state.Overview
Stops mirroring accounts inside
PreferencesController. The controller no longer maintains/syncsidentities,lostIdentities, orselectedAddress(including removing the AccountsController state-change subscription and deprecated selected-address helpers), and Sentry state filters/types are updated accordingly.Moves remaining consumers to
internalAccounts. Metrics (DappViewed), RPC handler tracking, account import flow, and account selection during hardware unlock/new/import now derive totals/selection viaAccountsControllerinstead of preferences state.Cleans persisted/test data. Adds migration
198to delete the obsolete preferences fields from storage, and updates backup/fixtures/mocks/tests/storybook data to stop generating or asserting on those properties.Written by Cursor Bugbot for commit bd972df. This will update automatically on new commits. Configure here.