fix: unified swaps activity list items by micaelae · Pull Request #40459 · MetaMask/metamask-extension

micaelae · 2026-02-26T19:58:48Z

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before/After

	BEFORE	AFTER
Transactions submitted locally
Transactions submitted on other clients
Bridge details (other client)
Bridge details (local)
Swap details (other client)
Swap details (local)

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

metamaskbotv2 · 2026-02-26T19:59:42Z

✨ Files requiring CODEOWNER review ✨

👨‍🔧 @MetaMask/core-extension-ux (5 files, +54 -9)

📁 ui/
- 📁 components/
  - 📁 app/
    - 📁 transaction-list/
      - 📄 transaction-list.test.js +2 -1
  - 📁 multichain/
    - 📁 activity-v2/
      - 📄 activity-details-modal-adapter.tsx +13 -1
      - 📄 activity-list-item.tsx +7 -1
      - 📄 activity-list.tsx +1 -0
      - 📄 hooks.ts +31 -6

🔄 @MetaMask/swaps-engineers (9 files, +2221 -251)

📁 test/
- 📁 data/
  - 📁 bridge/
    - 📄 mock-bridge-store.ts +1753 -0
📁 ui/
- 📁 ducks/
  - 📁 bridge-status/
    - 📄 selectors.ts +51 -1
- 📁 hooks/
  - 📁 bridge/
    - 📄 useBridgeActivity.ts +90 -0
    - 📄 useBridgeTxHistoryData.ts +29 -13
- 📁 pages/
  - 📁 bridge/
    - 📁 hooks/
      - 📄 useBridgeTokenDisplayData.ts +21 -15
    - 📁 transaction-details/
      - 📄 index.scss +0 -4
      - 📄 transaction-details.tsx +254 -211
    - 📁 utils/
      - 📄 tx-details.ts +22 -7
      - 📄 index.scss +1 -0

metamaskbotv2 · 2026-02-26T20:30:34Z

Builds ready [f1dff9e]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 287 268 320 19 298 320
total 287 268 320 19 298 320
Confirm Tx confirm_tx 6077 6067 6087 7 6079 6087
total 6077 6067 6087 7 6079 6087
Bridge User Actions bridge_load_page 209 185 245 22 219 245
bridge_load_asset_picker 220 212 229 7 225 229
bridge_search_token 710 707 718 5 707 718
total 1130 1109 1149 16 1139 1149

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1443 1204 1884 111 1471 1659
load 1221 1011 1553 99 1243 1412
domContentLoaded 1213 1006 1543 98 1238 1393
domInteractive 30 17 128 21 26 83
firstPaint 172 70 1187 132 214 373
backgroundConnect 218 199 383 20 220 243
firstReactRender 20 12 47 6 21 33
initialActions 1 0 5 1 2 4
loadScripts 1010 808 1332 96 1040 1187
setupStore 13 6 60 7 15 21
numNetworkReqs 31 22 88 19 22 84
Power User Home uiStartup 1685 1353 2354 156 1716 2017
load 1107 987 1687 155 1090 1567
domContentLoaded 1091 972 1681 150 1079 1527
domInteractive 33 18 161 24 31 89
firstPaint 193 63 1674 192 228 328
backgroundConnect 285 249 391 24 293 332
firstReactRender 24 15 51 7 25 37
initialActions 1 0 7 1 1 2
loadScripts 890 781 1456 144 874 1308
setupStore 16 7 43 7 17 34
numNetworkReqs 59 34 165 28 56 135

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 217 215 218 1 218 218
srpButtonToSrpForm 90 89 90 0 90 90
confirmSrpToPwForm 21 21 21 0 21 21
pwFormToMetricsScreen 15 14 15 0 15 15
metricsToWalletReadyScreen 15 15 16 0 15 16
doneButtonToHomeScreen 639 556 724 65 688 724
openAccountMenuToAccountListLoaded 7049 7001 7080 35 7080 7080
total 7973 7889 8092 80 7999 8092
Onboarding New Wallet createWalletToSocialScreen 220 216 222 2 222 222
srpButtonToPwForm 112 104 127 8 116 127
createPwToRecoveryScreen 8 8 8 0 8 8
skipBackupToMetricsScreen 36 36 36 0 36 36
agreeButtonToOnboardingSuccess 16 16 16 0 16 16
doneButtonToAssetList 525 463 616 56 563 616
total 917 841 1021 65 961 1021
Asset Details assetClickToPriceChart 48 36 63 12 60 63
total 48 36 63 12 60 63
Solana Asset Details assetClickToPriceChart 48 47 49 1 49 49
total 48 47 49 1 49 49
Import Srp Home loginToHomeScreen 2004 1916 2136 78 2045 2136
openAccountMenuAfterLogin 46 39 56 6 51 56
homeAfterImportWithNewWallet 2210 2186 2259 29 2207 2259
total 4306 4193 4445 104 4404 4445
Send Transactions openSendPageFromHome 24 14 41 10 29 41
selectTokenToSendFormLoaded 20 20 21 0 21 21
reviewTransactionToConfirmationPage 863 846 888 15 872 888
total 899 880 913 12 907 913
Swap openSwapPageFromHome 116 94 130 14 128 130
fetchAndDisplaySwapQuotes 5283 4571 6390 844 6239 6390
total 5408 4685 6520 834 6333 6520

🌐 Dapp Page Load Benchmarks

Current Commit: f1dff9e | Date: 2/26/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.07s (±45ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
domContentLoaded-> current mean value: 751ms (±41ms) 🟢 | historical mean value: 740ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 84ms (±15ms) 🟢 | historical mean value: 83ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.07s	45ms	1.03s	1.42s	1.11s	1.42s
domContentLoaded	751ms	41ms	720ms	1.06s	794ms	1.06s
firstPaint	84ms	15ms	68ms	224ms	88ms	224ms
firstContentfulPaint	84ms	15ms	68ms	224ms	88ms	224ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs

background: 58 Bytes (0%)
ui: 717 Bytes (0.01%)
common: 20 Bytes (0%)

sonarqubecloud · 2026-02-27T23:02:59Z

Quality Gate failed

Failed conditions
65.2% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

metamaskbotv2 · 2026-02-27T23:21:32Z

Builds ready [e66ac24]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 307 275 341 22 319 341
total 307 275 341 22 319 341
Confirm Tx confirm_tx 6064 6061 6066 2 6066 6066
total 6064 6061 6066 2 6066 6066
Bridge User Actions bridge_load_page 243 198 306 41 262 306
bridge_load_asset_picker 241 229 260 14 260 260
bridge_search_token 734 716 748 11 745 748
total 1243 1207 1280 27 1254 1280

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1421 1188 1888 119 1470 1608
load 1195 1007 1588 100 1245 1371
domContentLoaded 1187 987 1560 98 1240 1346
domInteractive 28 17 99 18 24 75
firstPaint 161 69 1422 151 206 388
backgroundConnect 211 188 262 14 217 237
firstReactRender 20 13 52 7 21 33
initialActions 1 0 7 1 2 4
loadScripts 992 799 1362 96 1031 1153
setupStore 13 6 37 5 15 23
numNetworkReqs 31 22 83 18 31 79
Power User Home uiStartup 2071 1400 11272 1436 1834 3971
load 1160 1023 1659 147 1159 1535
domContentLoaded 1147 1009 1632 143 1149 1524
domInteractive 39 20 189 32 37 120
firstPaint 180 73 453 90 242 323
backgroundConnect 584 259 9702 1329 307 1822
firstReactRender 23 15 50 8 26 40
initialActions 1 0 8 1 1 4
loadScripts 937 811 1415 141 934 1284
setupStore 14 6 27 4 16 20
numNetworkReqs 64 36 149 28 69 138

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 220 219 223 2 221 223
srpButtonToSrpForm 94 92 97 2 95 97
confirmSrpToPwForm 22 22 23 0 22 23
pwFormToMetricsScreen 15 15 16 0 16 16
metricsToWalletReadyScreen 16 16 16 0 16 16
doneButtonToHomeScreen 722 610 821 90 798 821
openAccountMenuToAccountListLoaded 7798 7623 8031 158 7851 8031
total 8869 8786 9006 80 8881 9006
Onboarding New Wallet createWalletToSocialScreen 219 216 221 2 221 221
srpButtonToPwForm 108 106 111 2 109 111
createPwToRecoveryScreen 8 8 8 0 8 8
skipBackupToMetricsScreen 36 36 37 1 37 37
agreeButtonToOnboardingSuccess 16 16 16 0 16 16
doneButtonToAssetList 723 486 937 175 910 937
total 1111 875 1321 175 1302 1321
Asset Details assetClickToPriceChart 37 28 47 7 38 47
total 37 28 47 7 38 47
Solana Asset Details assetClickToPriceChart 46 45 48 1 47 48
total 46 45 48 1 47 48
Import Srp Home loginToHomeScreen 2158 1918 2444 226 2418 2444
openAccountMenuAfterLogin 47 34 60 9 53 60
homeAfterImportWithNewWallet 2433 2240 2681 154 2521 2681
total 4638 4296 5000 274 4819 5000
Send Transactions openSendPageFromHome 31 17 42 11 39 42
selectTokenToSendFormLoaded 21 17 23 2 23 23
reviewTransactionToConfirmationPage 856 851 861 4 859 861
total 912 885 936 18 922 936
Swap openSwapPageFromHome 141 134 148 5 142 148
fetchAndDisplaySwapQuotes 6382 6375 6388 5 6388 6388
total 6541 6509 6579 28 6554 6579

🌐 Dapp Page Load Benchmarks

Current Commit: e66ac24 | Date: 2/27/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±80ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
domContentLoaded-> current mean value: 746ms (±99ms) 🟢 | historical mean value: 739ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 85ms (±66ms) 🟢 | historical mean value: 83ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	80ms	1.02s	1.59s	1.27s	1.59s
domContentLoaded	746ms	99ms	709ms	1.55s	952ms	1.55s
firstPaint	85ms	66ms	60ms	736ms	88ms	736ms
firstContentfulPaint	85ms	66ms	60ms	736ms	88ms	736ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs

background: 58 Bytes (0%)
ui: 717 Bytes (0.01%)
common: 20 Bytes (0%)

micaelae temporarily deployed to pr-comment February 26, 2026 19:59 — with GitHub Actions Inactive

metamaskbot added the team-swaps-and-bridge Swaps and Bridge team label Feb 26, 2026

github-actions bot added the size-S label Feb 26, 2026

micaelae temporarily deployed to pr-comment February 26, 2026 20:26 — with GitHub Actions Inactive

micaelae temporarily deployed to pr-comment February 27, 2026 22:50 — with GitHub Actions Inactive

micaelae temporarily deployed to pr-comment February 27, 2026 23:16 — with GitHub Actions Inactive

micaelae temporarily deployed to pr-comment February 27, 2026 23:51 — with GitHub Actions Inactive

micaelae force-pushed the swaps4175-activity-details branch from ed477dd to 45473fa Compare February 27, 2026 23:52

micaelae temporarily deployed to pr-comment February 27, 2026 23:52 — with GitHub Actions Inactive

github-actions bot added size-XL and removed size-S labels Feb 27, 2026

micaelae temporarily deployed to pr-comment February 28, 2026 00:21 — with GitHub Actions Inactive

micaelae added 7 commits February 27, 2026 16:21

chore: lookup bridge transactions by hash

fe90da7

fix: bridge status page layout

99dc390

chore: read TransactionViewModel in bridge activity hooks

eea0b21

chore: look up tx details by hash instead of id

6383749

feat: handle TransactionViewModel data in tx details

2dfe779

fix: navigate to bridge details page

961cb5d

fix: show bridge activity item data if available

a5ec4e4

micaelae force-pushed the swaps4175-activity-details branch from 45473fa to a5ec4e4 Compare February 28, 2026 01:58

micaelae had a problem deploying to pr-comment February 28, 2026 01:58 — with GitHub Actions Failure

github-actions bot added size-M and removed size-XL labels Feb 28, 2026

micaelae temporarily deployed to pr-comment February 28, 2026 02:24 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: unified swaps activity list items#40459

fix: unified swaps activity list items#40459
micaelae wants to merge 7 commits intomainfrom
swaps4175-activity-details

micaelae commented Feb 26, 2026 •

edited

Loading

Uh oh!

metamaskbotv2 bot commented Feb 26, 2026 •

edited

Loading

Uh oh!

metamaskbotv2 bot commented Feb 26, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

sonarqubecloud bot commented Feb 27, 2026

Uh oh!

metamaskbotv2 bot commented Feb 27, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

micaelae commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before/After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

metamaskbotv2 bot commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

metamaskbotv2 bot commented Feb 26, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

sonarqubecloud bot commented Feb 27, 2026

Quality Gate failed

Uh oh!

metamaskbotv2 bot commented Feb 27, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

micaelae commented Feb 26, 2026 •

edited

Loading

metamaskbotv2 bot commented Feb 26, 2026 •

edited

Loading