test: split TypeScript configs for Jest unit and E2E typing#40500
Open
davidmurdoch wants to merge 6 commits intomainfrom
Open
test: split TypeScript configs for Jest unit and E2E typing#40500davidmurdoch wants to merge 6 commits intomainfrom
davidmurdoch wants to merge 6 commits intomainfrom
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
✨ Files requiring CODEOWNER review ✨🔑 @MetaMask/accounts-engineers (2 files, +0 -6)
✅ @MetaMask/confirmations (1 files, +0 -1)
💸 @MetaMask/transactions (1 files, +0 -1)
👨🔧 @MetaMask/wallet-integrations (3 files, +0 -4)
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Contributor
Builds ready [c731d87]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
Contributor
Builds ready [fc0495e]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
Contributor
Builds ready [6d5dfc0]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
tsconfig.unit.jsonfor app/unit typing andtsconfig.e2e.jsonfortest/e2etyping.lint:tscto run both configs.@ts-expect-errordirectives and adjusted affected parameterized test typings so both configs pass.expectedState = {}inui/hooks/bridge/useBridging.test.tsafter the callback refactor, which fixed the failing unit shard in CI.tsBuildInfoFileto avoid incremental cache collisions.Changelog
CHANGELOG entry: null
Related issues
Manual testing steps
yarn lint:changed:fix.yarn lint:tsc.yarn test:unit ui/hooks/bridge/useBridging.test.ts --runInBand.check-template-and-add-labelspasses in CI.Screenshots/Recordings
Pre-merge author checklist
CHANGELOG entry: null).Pre-merge reviewer checklist
test/e2eonly in e2e config).ui/hooks/bridge/useBridging.test.ts).Note
Low Risk
Low risk: config/typechecking-only changes that mainly affect lint/typecheck and test compilation, with no production runtime logic modified.
Overview
Splits TypeScript typechecking into separate composite projects (
tsconfig.source.json,tsconfig.unit.json,tsconfig.e2e.json) built viatsc -b, factoring shared options into a newtsconfig.base.jsonand giving each project its own incremental cache file.Updates ESLint’s TypeScript override to run per-project (using each tsconfig’s file list and
parserOptions.project) so Jest unit tests and Mocha/E2E tests get the correct global typings.Cleans up test files to typecheck under the split configs by removing stale
@ts-expect-errorsuppressions and loosening/adjusting parameter typings in variousit.each/describe.eachcases, and updates the TS migration dashboard’smadgeconfig to usetsconfig.base.json.Written by Cursor Bugbot for commit 971798a. This will update automatically on new commits. Configure here.