refactor: migrate useHistoricalPricesEvm by n3ps · Pull Request #40507 · MetaMask/metamask-extension

n3ps · 2026-02-27T22:20:27Z

Replace manual useState + useEffect + fetch pattern with useQuery

Built-in caching and deduplication of concurrent requests for same asset
No manual loading/setPrices/setMetadata state management
Metadata derived instead of a second useEffect

Description

Changelog

CHANGELOG entry: refactor: migrate useHistoricalPricesEvm to useQuery

Related issues

Fixes:

Manual testing steps

Go to a token detail page
See chart

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Touches the asset price chart data-fetching path by switching from manual fetch/state to useQuery + apiClient, which can subtly change loading/empty-state behavior and caching across assets/chains.

Overview
EVM historical price fetching is refactored from a manual useEffect + fetch + local state pattern to useQuery using apiClient.prices.getV1HistoricalPricesQueryOptions, including a select transform for prices and deriving metadata inline.

UI/tests are adjusted to reflect the new request path and states: AssetChartEmptyState now exposes data-testid="asset-chart-empty-state", asset page tests mock getBearerToken and broaden nock interception/cleanup, and snapshots/assertions update from a chart loading skeleton to the empty-state when the API returns no price data.

^{Written by Cursor Bugbot for commit 403be16. This will update automatically on new commits. Configure here.}

Replace manual useState + useEffect + fetch pattern with @tanstack/react-query useQuery. Benefits: - Built-in caching (staleTime: 60s, cacheTime: 5min) - Automatic deduplication of concurrent requests for same asset - No manual loading/setPrices/setMetadata state management - Metadata derived via useMemo instead of a second useEffect - Fetch logic extracted to pure async function Non-EVM hook (useHistoricalPricesNonEvm) is unchanged as it uses Redux dispatch, not direct fetch. Co-authored-by: Francis Nepomuceno <n3ps@users.noreply.github.com>

metamaskbotv2 · 2026-02-27T22:52:15Z

Builds ready [bf53a17]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 295 292 299 3 297 299
total 295 292 299 3 297 299
Confirm Tx confirm_tx 6033 6030 6036 2 6036 6036
total 6033 6030 6036 2 6036 6036
Bridge User Actions bridge_load_page 240 182 307 49 284 307
bridge_load_asset_picker 182 130 220 37 212 220
bridge_search_token 721 696 748 20 739 748
total 1171 1097 1266 69 1232 1266

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1434 1205 2045 121 1459 1645
load 1204 1010 1648 102 1235 1414
domContentLoaded 1198 1005 1630 100 1232 1406
domInteractive 30 17 142 22 25 81
firstPaint 159 74 407 73 213 272
backgroundConnect 211 192 334 18 213 236
firstReactRender 20 13 48 7 21 34
initialActions 1 0 6 1 2 4
loadScripts 1003 812 1401 98 1032 1204
setupStore 14 6 36 6 17 21
numNetworkReqs 31 22 87 19 23 84
Power User Home uiStartup 2245 1426 10778 1394 2168 4500
load 1188 1049 1687 157 1203 1617
domContentLoaded 1175 1040 1675 155 1196 1603
domInteractive 39 21 168 29 38 125
firstPaint 191 78 1322 137 259 320
backgroundConnect 626 253 7037 1024 317 2647
firstReactRender 25 16 47 8 29 41
initialActions 1 0 5 1 1 3
loadScripts 961 830 1457 150 973 1390
setupStore 16 7 39 6 18 26
numNetworkReqs 69 33 155 27 81 128

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 221 221 221 0 221 221
srpButtonToSrpForm 103 100 110 4 102 110
confirmSrpToPwForm 24 24 25 0 24 25
pwFormToMetricsScreen 16 16 17 1 17 17
metricsToWalletReadyScreen 18 17 18 1 18 18
doneButtonToHomeScreen 994 816 1272 204 1212 1272
openAccountMenuToAccountListLoaded 7397 7036 7662 220 7521 7662
total 8778 8628 8918 103 8864 8918
Onboarding New Wallet createWalletToSocialScreen 218 217 218 1 218 218
srpButtonToPwForm 107 107 108 0 108 108
createPwToRecoveryScreen 8 8 8 0 8 8
skipBackupToMetricsScreen 37 34 40 2 38 40
agreeButtonToOnboardingSuccess 17 16 17 0 17 17
doneButtonToAssetList 915 598 1453 320 1079 1453
total 1308 981 1873 330 1464 1873
Asset Details assetClickToPriceChart 62 37 86 21 79 86
total 62 37 86 21 79 86
Solana Asset Details assetClickToPriceChart 45 44 45 1 45 45
total 45 44 45 1 45 45
Import Srp Home loginToHomeScreen 2052 1980 2134 61 2085 2134
openAccountMenuAfterLogin 47 42 52 3 47 52
homeAfterImportWithNewWallet 2591 2448 2812 132 2668 2812
total 4690 4644 4725 34 4725 4725
Send Transactions openSendPageFromHome 36 34 38 2 38 38
selectTokenToSendFormLoaded 20 18 22 2 22 22
reviewTransactionToConfirmationPage 857 846 876 11 862 876
total 911 901 932 12 915 932
Swap openSwapPageFromHome 102 83 120 15 114 120
fetchAndDisplaySwapQuotes 4581 4561 4607 17 4596 4607
total 4684 4675 4690 6 4690 4690

🌐 Dapp Page Load Benchmarks

Current Commit: bf53a17 | Date: 2/27/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±46ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
domContentLoaded-> current mean value: 727ms (±42ms) 🟢 | historical mean value: 740ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 79ms (±11ms) 🟢 | historical mean value: 83ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	46ms	1.01s	1.35s	1.05s	1.35s
domContentLoaded	727ms	42ms	706ms	1.02s	742ms	1.02s
firstPaint	79ms	11ms	64ms	172ms	88ms	172ms
firstContentfulPaint	79ms	11ms	64ms	172ms	88ms	172ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚀 Bundle size reduced!]

background: 105.97 KiB (2.01%)
ui: -24.87 KiB (-0.3%)
common: -143.66 KiB (-1.27%)

github-actions · 2026-02-28T01:51:06Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

n3ps · 2026-02-28T02:21:37Z