test: stabilize dapp-interactions E2E tab targeting and add stress workflow#40512
Draft
davidmurdoch wants to merge 16 commits intomainfrom
Draft
test: stabilize dapp-interactions E2E tab targeting and add stress workflow#40512davidmurdoch wants to merge 16 commits intomainfrom
davidmurdoch wants to merge 16 commits intomainfrom
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
Builds ready [bf69cd8]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
Contributor
✨ Files requiring CODEOWNER review ✨🔑 @MetaMask/accounts-engineers (2 files, +99 -39)
👨🔧 @MetaMask/core-extension-ux (1 files, +2 -1)
🔔 @MetaMask/notifications (1 files, +2 -1)
👨🔧 @MetaMask/wallet-integrations (2 files, +228 -61)
|
|
Contributor
Builds ready [2cb6290]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Description
This PR addresses a flaky E2E failure in
dapp-interactions.spec.tsby removing ambiguous title-based tab switching in a multi-dapp scenario.In
should connect a second Dapp despite MetaMask being locked, we now switch back to the second dapp by URL (DAPP_ONE_URL) instead of title (E2E Test Dapp), which can match multiple tabs.This PR also adds a dedicated stress workflow that runs only this spec repeatedly (default 30 attempts) and fails on the first flaky occurrence.
Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
yarn lint:changed:fixE2E Dapp Interactions Stress) with default attempts, or run:gh workflow run e2e-dapp-interactions-stress.yml --ref chore/dapp-interactions-flake-stress -f attempts=30test/e2e/tests/dapp-interactions/dapp-interactions.spec.tsand passes all repeated attempts.Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist