feat: enable metamask pay in dapps via feature flag#40514
Open
matthewwalsh0 wants to merge 3 commits intomainfrom
Open
feat: enable metamask pay in dapps via feature flag#40514matthewwalsh0 wants to merge 3 commits intomainfrom
matthewwalsh0 wants to merge 3 commits intomainfrom
Conversation
Contributor
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (8 files, +194 -88)
|
Contributor
Builds ready [b52cce4]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Use alternate feature flag. Bump middleware.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Contributor
Builds ready [2836d7f]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Replace the
MM_PAY_DAPPS_ENABLEDbuild-time environment variable with adappsEnabledproperty under theconfirmations_payremote feature flag (defaults tofalse).Changelog
CHANGELOG entry: null
Related issues
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Changes the enablement mechanism for MetaMask Pay in dapps from build-time env to a runtime remote feature flag, which can affect rollout behavior and visibility. Also adjusts confirmation UI/test selectors for
PayWithRow, risking minor UI regressions in the confirmations flow.Overview
MetaMask Pay in dapps is no longer controlled by the build-time
MM_PAY_DAPPS_ENABLEDenv var;TransactionPaySectionnow renders only when the runtime remote flagconfirmations_pay_dapps.enabledis true via the new selectorselectIsMetaMaskPayDappsEnabled(defaulting to false), with updated unit tests.The confirmations UI updates
PayWithRowto support a smaller pill-style variant and a default inline row that usesConfirmInfoAlertRow(with new test ids likepay-with-pill), andCustomAmountInfonow renders the small variant. Dependency@metamask/eip-5792-middlewareis pinned/upgraded to3.0.0(lockfile updated), and the build config removes theMM_PAY_DAPPS_ENABLEDentry.Written by Cursor Bugbot for commit 2836d7f. This will update automatically on new commits. Configure here.