feat(gator-permissions): add Gator Permissions deep link#40995
Closed
feat(gator-permissions): add Gator Permissions deep link#40995
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
…ken-transfer path
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
Builds ready [bdbfb72]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
✨ Files requiring CODEOWNER review ✨🔒 @MetaMask/extension-security-team (1 files, +7 -0)
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 3 total unresolved issues (including 2 from previous reviews).
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
|
Contributor
Builds ready [3bea1d7]
⚡ Performance Benchmarks
Dapp page load benchmarks: data not available. Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
jeffsmale90
approved these changes
Mar 19, 2026
|
|
||
| const encodedSite = encodeURIComponent(site); | ||
| return { | ||
| path: `/gator-permissions/${type}/${encodedSite}`, |
Contributor
There was a problem hiding this comment.
This is definitely only a nit: should we lean into the public naming /advanced-permissions/ ?
6 tasks
Contributor
Author
|
Due to our decision to use a different approach to display existing permissions MetaMask/snap-7715-permissions#288, we are going to close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for the Gator Permissions deep link route, allowing users to navigate directly to the Gator Permissions page with specified parameters. The implementation includes a new route handler that validates and processes
typeandsitequery parameters, with comprehensive validation to ensure only valid URLs are passed through.Key features:
/gator-permissionsroute with query parameter validationtoken-transfertype parameterChangelog
CHANGELOG entry: Added Gator Permissions deep link support for token transfer operations
Related issues
Fixes:
Manual testing steps
yarn start:flaskor appropriate build commandhttps://link.metamask.io/gator-permissions?type=token-transfer&site=http://localhost:8000Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Low risk: adds a new deep-link route with strict parameter validation and test coverage, with no changes to existing routing behavior beyond registering the new path.
Overview
Adds a new deep link route
'/gator-permissions'that resolves to/gator-permissions/:type/:site, validating requiredtype(currently onlytoken-transfer) andsite(must be anhttp/httpsorigin) before constructing the destination path.Updates i18n strings for the new page title key and registers the route in the deep-link routes index, with comprehensive unit tests covering valid, missing, and invalid query parameter cases.
Extends
.github/CODEOWNERSto assign the Delegation team ownership for the new gator-permissions areas.Written by Cursor Bugbot for commit 3bea1d7. This will update automatically on new commits. Configure here.