feat(snaps): Add Snap export tracking hook to Snap controller init #14428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david0xd
added
No QA Needed
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
david0xd
force-pushed
the
dd/change-snap-export-tracking
branch
from
f762712 to
7cef38b
Compare
david0xd
force-pushed
the
dd/change-snap-export-tracking
branch
2 times, most recently
from
9d493f8 to
bb70f92
Compare
github-merge-queue bot
pushed a commit
to MetaMask/snaps
that referenced
this pull request
May 5, 2025
This PR moves MetaMetrics tracking of Snap export usage to Snap Controller. Related issue: #3259 Extension integration PR: MetaMask/metamask-extension#31553 Mobile integration PR: MetaMask/metamask-mobile#14428
Fix type error Update tracking props mapping Update temporary types for metrics params Fix unit tests Add small fix for tracking Snap event name Apply another fix
david0xd
force-pushed
the
dd/change-snap-export-tracking
branch
from
bb70f92 to
597da79
Compare
|
Mrtenz
approved these changes
May 13, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds MetaMetrics tracking hook to Snap controller init. This way we delegate Snap export tracking to Snap controller.
Related issues
Related PR:
MetaMask/snaps#3281
MetaMask/metamask-extension#31553
Notes
Manual testing steps
Screenshots/Recordings
Before
n/a
After
n/a
Pre-merge author checklist
Pre-merge reviewer checklist