Skip to content

Conversation

@GeorgeGkas
Copy link
Contributor

@GeorgeGkas GeorgeGkas commented Oct 24, 2025

Description

Fix the inconsistent size of the close button in the "Swap" page "Select Token" bottom sheet and "Select Network" bottom sheet. We also took some time to refactor BridgeNetworkSelectorBase to use components from the design system similar to how BridgeTokenSelectorBase does it.

Changelog

CHANGELOG entry: Fix the inconsistent size of the close button in the "Swap" page "Select Token" bottom sheet and "Select Network" bottom sheet.

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/SWAPS-3186

Manual testing steps

  When user navigates to swap page, the close icon button should much the size of the one presented in  "select network"and "select tokens" bottom sheets.

Screenshots/Recordings

Before

After

image image image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Standardizes close button size in bridge token/network selectors and refactors BridgeNetworkSelectorBase to use the design-system BottomSheetHeader.

  • Bridge UI:
    • Header Refactor: BridgeNetworkSelectorBase now uses BottomSheetHeader with onClose, removing custom Box/TouchableOpacity/Icon logic; simplified styles.
    • Close Button Consistency: Sets close button to ButtonIconSizes.Lg across selectors.
  • Token Selectors (BridgeSourceTokenSelector, BridgeDestTokenSelector):
    • Close button size increased to 32x32 with 24px icon.
  • Network Selectors (BridgeSourceNetworkSelector, BridgeDestNetworkSelector):
    • Header layout updated (row, padding, centered title, right-aligned close button); content wrapper/scroll structure simplified.
  • Tests:
    • Snapshots updated to reflect new header structure and close button dimensions.

Written by Cursor Bugbot for commit 1aa4a07. This will update automatically on new commits. Configure here.

@GeorgeGkas GeorgeGkas requested a review from a team as a code owner October 24, 2025 14:10
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-swaps-and-bridge Swaps and Bridge team label Oct 24, 2025
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size-S team-swaps-and-bridge Swaps and Bridge team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants