Skip to content

Conversation

@brianacnguyen
Copy link
Contributor

@brianacnguyen brianacnguyen commented Oct 24, 2025

Description

This PR adds the Tokens Full page to the wallet

Changelog

CHANGELOG entry: null

Related issues

Fixes: https://consensyssoftware.atlassian.net/jira/software/c/projects/DSYS/boards/1888?selectedIssue=DSYS-245

Manual testing steps

Feature: Tokens Full Page

  Scenario: user: null
    Given: null

    When user uncomments line 265 in `app/components/UI/Tokens/index.tsx` and clicks on View all Tokens
    Then it should lead them to the Tokens Full View page with a full view of tokens with preexisting behaviors still intact

Screenshots/Recordings

Before

After

Tokens Full View

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-10-24.at.09.18.25.mp4

Tokens Tab still functional

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-10-24.at.09.19.46.mp4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Adds a new full-screen Tokens view with navigation route and tests, removes the token list footer, enables control bar/list styling props, and switches AddAsset to a bottom-sheet header.

  • Wallet UI:
    • New TokensFullView screen: Full-screen tokens list with progressive loading, control bar, and back header (app/components/Views/TokensFullView/*).
    • Navigation: Registers route Routes.WALLET.TOKENS_FULL_VIEW and screen in MainNavigator.
    • Localization: Adds wallet.view_all_tokens string.
  • Tokens list refactor:
    • Removes TokenListFooter component and its tests/snapshots.
    • TokenList: adds optional flashListProps passthrough; removes ListFooterComponent usage.
    • TokenListControlBar and BaseControlBar: add optional style prop for layout customization.
    • Styles: add viewAllTokensButton.
  • AddAsset UX:
    • Replaces nav bar options with BottomSheetHeader and back handling in AddAsset.

Written by Cursor Bugbot for commit bd8fb40. This will update automatically on new commits. Configure here.

@brianacnguyen brianacnguyen requested a review from a team as a code owner October 24, 2025 16:41
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-design-system All issues relating to design system in Mobile label Oct 24, 2025
cursor[bot]

This comment was marked as outdated.

@brianacnguyen brianacnguyen self-assigned this Oct 24, 2025
@brianacnguyen brianacnguyen added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Oct 24, 2025
cursor[bot]

This comment was marked as outdated.

@github-actions github-actions bot added size-M and removed size-L labels Oct 24, 2025
}, [updateNavBar]);
const handleBackPress = useCallback(() => {
navigation.goBack();
}, [navigation]);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Import assets page was moved to the main stack to work with both the Tokens tab and tokens full page, so the header needs to be refactored to go inside the page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed size-M team-design-system All issues relating to design system in Mobile

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants