-
-
Couldn't load subscription status.
- Fork 1.4k
feat: Add NFTs full page #21647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
brianacnguyen
wants to merge
17
commits into
main
Choose a base branch
from
feat/nfts-full-page
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+709
−130
Open
feat: Add NFTs full page #21647
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
7622334
Added NFTsFullView page
brianacnguyen 96875e5
Removed unnecessary additions
brianacnguyen 4a5167a
Added maxitems to nftgrid
brianacnguyen 83a52a9
Reorgs nft folder structures
brianacnguyen b34b57f
Updated tests
brianacnguyen 391dd20
Updated snapshots
brianacnguyen 42ac14a
Reorg Nft structure
brianacnguyen 170be7e
Added test ids to nftgrid
brianacnguyen 08039c9
Reverted unnecessary changes
brianacnguyen 28f2ad3
Removed more unnecessary changes
brianacnguyen fa8cbbb
Reverted more unnecessary changes
brianacnguyen 19d5b4c
Removed double padding
brianacnguyen 28a2808
Merge branch 'main' of https://github.com/MetaMask/metamask-mobile in…
brianacnguyen fc3572e
Updated AddAsset tests
brianacnguyen baf5396
Updated addasset tests
brianacnguyen 549e2fa
Updated NftGrid tests
brianacnguyen 92ee691
Merge branch 'main' into feat/nfts-full-page
brianacnguyen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -51,7 +51,7 @@ const styleSheet = (params: { | |
| textContainer: { | ||
| alignItems: 'center', | ||
| justifyContent: 'flex-start', | ||
| backgroundColor: colors.background.alternative, | ||
| backgroundColor: colors.background.section, | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Updated based on design |
||
| borderRadius: 8, | ||
| }, | ||
| textWrapper: { | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be moved out to the main stack to work with the new asset full pages. Additionally, it should not have the bottom nav