Skip to content

Conversation

@Battambang
Copy link
Contributor

@Battambang Battambang commented Dec 1, 2025

Description

Updates bitcoin to 1.8.0, which removes onRpcRequest method.

Changelog

CHANGELOG entry: Removed onRpcRequest (#568)

Related issues

Fixes: Remove onRpcRequest.

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Upgrade @metamask/bitcoin-wallet-snap from ^1.7.0 to ^1.8.0.

  • Dependencies:
    • Upgrade @metamask/bitcoin-wallet-snap to ^1.8.0 in package.json.
    • Update yarn.lock to reflect the new version.

Written by Cursor Bugbot for commit 6b5cf54. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@aganglada aganglada changed the title fix: bump bitcoin fix: cp-7.60.1 bump bitcoin Dec 1, 2025
@socket-security
Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​@​metamask/​bitcoin-wallet-snap@​1.7.0 ⏵ 1.8.01001008398 +1100

View full report

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeAccounts, SmokeCore, SmokeConfirmationsRedesigned, SmokeIdentity, SmokeNetworkAbstractions, SmokeNetworkExpansion, SmokeTrade, SmokeWalletPlatform, SmokeWalletUX, SmokeAssets, SmokeSwaps, SmokeStake, SmokeCard, SmokeNotifications, SmokeRewards, SmokePerps, SmokeRamps, SmokeMultiChainPermissions, SmokeAnalytics, SmokeMultiChainAPI, SmokePredictions
  • Risk Level: high
  • AI Confidence: %
click to see 🤖 AI reasoning details

Fallback: AI analysis did not complete successfully. Running all tests.

View GitHub Actions results

@Battambang Battambang enabled auto-merge December 1, 2025 14:54
Copy link
Contributor

@aganglada aganglada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, rpc is disallowed ✅

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 1, 2025

@Battambang Battambang added this pull request to the merge queue Dec 1, 2025
Merged via the queue into main with commit 90ac48c Dec 1, 2025
91 of 93 checks passed
@Battambang Battambang deleted the chore/bitcoin-bump-1.8.0 branch December 1, 2025 15:57
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2025
@metamaskbot metamaskbot added the release-7.62.0 Issue or pull request that will be included in release 7.62.0 label Dec 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.62.0 Issue or pull request that will be included in release 7.62.0 size-XS team-network-enablement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants