-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
chore: remove legacy accounts component code (pre BIP-44) #24886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…to gar/chore/remove-legacy-bip44/components
…to gar/chore/remove-legacy-bip44/components
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #24886 +/- ##
==========================================
+ Coverage 75.42% 80.26% +4.84%
==========================================
Files 4263 4263
Lines 110111 110086 -25
Branches 23462 23456 -6
==========================================
+ Hits 83051 88364 +5313
+ Misses 21036 15519 -5517
- Partials 6024 6203 +179 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…thub.com/MetaMask/metamask-mobile into gar/chore/remove-legacy-bip44/components
|
Won't fix the quality gate failure since this is not introducing any new code |
app/components/Views/MultichainAccounts/AccountDetails/components/AccountInfo/AccountInfo.tsx
Show resolved
Hide resolved
sahar-fehri
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assets changes LGTM ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
…thub.com/MetaMask/metamask-mobile into gar/chore/remove-legacy-bip44/components
1d5030f
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - skip-smart-e2e-selection label found All E2E tests pre-selected. |
|



Description
This PR removes the usage of the selector
selectMultichainAccountsState2Enabledwhich gets the value for the BIP-44 feature flag. Moving forward, BIP-44 is the default behaviour and any alternative logic branch will be remove alongside tests.The scope of the changes is limited to files inside the
app/components/UI/directory.Changelog
CHANGELOG entry: null
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/MUL-1382
Manual testing steps
Not applicable
Screenshots/Recordings
Not applicable
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Removes legacy/flagged UI branches and changes user-visible behavior (e.g.,
AddressCopyno longer copies to clipboard and network selector defaults/sections change). Moderate risk of regressions in navigation, balance display, and tests due to widened unconditional paths.Overview
Standardizes UI on multichain/BIP-44 behavior by removing
selectMultichainAccountsState2Enabledgating.AddressCopyis simplified to no longer accept anaccountprop and no longer performs clipboard/toast/metrics/protect-wallet logic; pressing the icon now always navigates to the multichain address list (updated call sites inNavbarandAccountInfo, plus a simplified test).Network selection UI is de-flagged:
NetworkManager’s initial tab selection is now derived solely fromenabledNetworksByNamespace,NetworkMultiSelectoralways renders the custom network section for any namespace, andNetworkMultiSelectorListalways prepends the “select all networks” row when provided.AssetOverviewdrops the state2-specific balance shortcut and always usesasset.balancewhen present; tests are updated accordingly (mock selectors refactor, Solana balance expectation, and an updated “no balance” scenario).Written by Cursor Bugbot for commit 0516e6e. This will update automatically on new commits. Configure here.