Skip to content

Conversation

@gantunesr
Copy link
Member

@gantunesr gantunesr commented Jan 19, 2026

Description

This PR removes the usage of the selector selectMultichainAccountsState2Enabled which gets the value for the BIP-44 feature flag. Moving forward, BIP-44 is the default behaviour and any alternative logic branch will be remove alongside tests.

The scope of the changes is limited to files inside the app/components/UI/ directory.

Changelog

CHANGELOG entry: null

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MUL-1382

Manual testing steps

Not applicable

Screenshots/Recordings

Not applicable

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Removes legacy/flagged UI branches and changes user-visible behavior (e.g., AddressCopy no longer copies to clipboard and network selector defaults/sections change). Moderate risk of regressions in navigation, balance display, and tests due to widened unconditional paths.

Overview
Standardizes UI on multichain/BIP-44 behavior by removing selectMultichainAccountsState2Enabled gating.

AddressCopy is simplified to no longer accept an account prop and no longer performs clipboard/toast/metrics/protect-wallet logic; pressing the icon now always navigates to the multichain address list (updated call sites in Navbar and AccountInfo, plus a simplified test).

Network selection UI is de-flagged: NetworkManager’s initial tab selection is now derived solely from enabledNetworksByNamespace, NetworkMultiSelector always renders the custom network section for any namespace, and NetworkMultiSelectorList always prepends the “select all networks” row when provided.

AssetOverview drops the state2-specific balance shortcut and always uses asset.balance when present; tests are updated accordingly (mock selectors refactor, Solana balance expectation, and an updated “no balance” scenario).

Written by Cursor Bugbot for commit 0516e6e. This will update automatically on new commits. Configure here.

@metamaskbot metamaskbot added the team-accounts-framework Accounts Framework team label Jan 19, 2026
@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2026

Codecov Report

❌ Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.26%. Comparing base (93fba69) to head (0516e6e).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
app/components/UI/NetworkManager/index.tsx 25.00% 2 Missing and 1 partial ⚠️
...workMultiSelectorList/NetworkMultiSelectorList.tsx 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #24886      +/-   ##
==========================================
+ Coverage   75.42%   80.26%   +4.84%     
==========================================
  Files        4263     4263              
  Lines      110111   110086      -25     
  Branches    23462    23456       -6     
==========================================
+ Hits        83051    88364    +5313     
+ Misses      21036    15519    -5517     
- Partials     6024     6203     +179     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gantunesr gantunesr marked this pull request as ready for review January 27, 2026 18:54
@gantunesr gantunesr requested review from a team as code owners January 27, 2026 18:54
@gantunesr gantunesr added the skip-e2e-quality-gate Skips the E2E Quality gate (flakiness detection) label Jan 27, 2026
@gantunesr
Copy link
Member Author

Won't fix the quality gate failure since this is not introducing any new code

@gantunesr gantunesr added the skip-smart-e2e-selection Skip Smart E2E selection, i.e. select all E2E tests to run label Jan 27, 2026
sahar-fehri
sahar-fehri previously approved these changes Jan 28, 2026
Copy link
Contributor

@sahar-fehri sahar-fehri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assets changes LGTM ✅

ccharly
ccharly previously approved these changes Jan 29, 2026
mathieuartu
mathieuartu previously approved these changes Jan 29, 2026
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

sahar-fehri
sahar-fehri previously approved these changes Jan 29, 2026
@gantunesr gantunesr dismissed stale reviews from sahar-fehri, mathieuartu, and ccharly via 1d5030f January 30, 2026 00:12
@github-actions
Copy link
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - skip-smart-e2e-selection label found

All E2E tests pre-selected.

View GitHub Actions results

@sonarqubecloud
Copy link

@gantunesr gantunesr added this pull request to the merge queue Jan 30, 2026
Merged via the queue into main with commit 2cdcf0a Jan 30, 2026
101 checks passed
@gantunesr gantunesr deleted the gar/chore/remove-legacy-bip44/components branch January 30, 2026 15:52
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2026
@metamaskbot metamaskbot added the release-7.65.0 Issue or pull request that will be included in release 7.65.0 label Jan 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.65.0 Issue or pull request that will be included in release 7.65.0 size-M skip-e2e-quality-gate Skips the E2E Quality gate (flakiness detection) skip-smart-e2e-selection Skip Smart E2E selection, i.e. select all E2E tests to run team-accounts-framework Accounts Framework team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants