Skip to content

Conversation

@racitores
Copy link
Contributor

@racitores racitores commented Jan 30, 2026

Description

  • MusdConversionAssetOverviewCta: Align text assertions with current i18n (boost_title / boost_description); use MUSD_CONVERSION_APY and drop redundant getByText('mUSD').

  • EarnMusdConversionEducationView: Match description via regex (description is rendered with " Terms apply." in the same Text); assert APY percentage on children[0] instead of children.

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk: changes are limited to component-view test assertions and how text is matched/inspected, with no production logic modifications.

Overview
Updates mUSD conversion component-view tests to match the current rendered copy and i18n behavior.

The education view tests now match the description via regex (to tolerate the appended “Terms apply.” text) and adjust APY assertions to check the first child node. The asset overview CTA tests switch to asserting the new boost_title/boost_description strings using MUSD_CONVERSION_APY, and remove redundant checks for a separate mUSD text node.

Written by Cursor Bugbot for commit 03c42f6. This will update automatically on new commits. Configure here.

@racitores racitores requested a review from a team as a code owner January 30, 2026 10:24
@racitores racitores added no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed skip-e2e skip E2E test jobs labels Jan 30, 2026
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Jan 30, 2026
@racitores racitores enabled auto-merge January 30, 2026 10:27
@github-actions
Copy link
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 95%
click to see 🤖 AI reasoning details

E2E Test Selection:
Only Jest unit test files for Earn mUSD conversion views were modified, adjusting copy expectations and regex matches. No application runtime code, controllers, Engine, navigation, or UI components used in E2E flows were touched. No CI/workflow or test infrastructure changes. Therefore, there is no impact on E2E-covered user flows and it’s safe to skip all E2E tests.

Performance Test Selection:
No runtime code changes that affect rendering, data loading, navigation, or startup. Changes are limited to unit test expectations, so there is no potential performance impact.

View GitHub Actions results

@sonarqubecloud
Copy link

@racitores racitores added this pull request to the merge queue Jan 30, 2026
Merged via the queue into main with commit 7748289 Jan 30, 2026
91 of 94 checks passed
@racitores racitores deleted the raci/fix-component-view-test branch January 30, 2026 12:05
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2026
@metamaskbot metamaskbot added the release-7.65.0 Issue or pull request that will be included in release 7.65.0 label Jan 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.65.0 Issue or pull request that will be included in release 7.65.0 size-S skip-e2e skip E2E test jobs team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants