Skip to content

test: simplify the input in order to avoid flakiness#27060

Merged
christopherferreira9 merged 1 commit intomainfrom
cferreira/stabilize-flask-lookup-test
Mar 5, 2026
Merged

test: simplify the input in order to avoid flakiness#27060
christopherferreira9 merged 1 commit intomainfrom
cferreira/stabilize-flask-lookup-test

Conversation

@christopherferreira9
Copy link
Contributor

@christopherferreira9 christopherferreira9 commented Mar 5, 2026

Description

This PR aims to fix a flaky flask test where flakiness was being caused by the framework and the way typeText is implemented.
Because this change is only affecting this flask test for now, the change was done one the test itself and not on the page object until the actual root cause is found.

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk: changes are limited to an E2E smoke test, adjusting input/tap timing to reduce flakiness without affecting app runtime behavior.

Overview
Improves stability of the name-lookup snap smoke test by replacing RedesignedSendView.inputRecipientAddress() with a direct Gestures.replaceText() to avoid flaky newline/keyboard behavior.

Adds explicit gesture metadata and a 1s delayed waitAndTap when selecting the recipient domain in advanced details to reduce animation-related flakiness.

Written by Cursor Bugbot for commit 6d72450. This will update automatically on new commits. Configure here.

@christopherferreira9 christopherferreira9 requested a review from a team as a code owner March 5, 2026 14:14
@christopherferreira9 christopherferreira9 added team-qa QA team no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed labels Mar 5, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the size-S label Mar 5, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: FlaskBuildTests
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 95%
click to see 🤖 AI reasoning details

E2E Test Selection:
The change is isolated to a single test file tests/smoke/snaps/test-snap-name-lookup.spec.ts which is a Snaps E2E test. The modifications are purely to fix test flakiness:

  1. Replaced inputRecipientAddress() with Gestures.replaceText() to avoid flakiness from '\n' input that was hiding the keyboard
  2. Added a 1000ms delay to Gestures.waitAndTap() to handle animation-related flakiness
  3. Added elemDescription parameters for better test logging

No application code is modified - this is a test stability improvement. The test file is tagged with FlaskBuildTests as it tests the Name Lookup Snap functionality. Running FlaskBuildTests will validate that the test fix works correctly.

Performance Test Selection:
No performance tests needed. This change only modifies test code to fix flakiness - no application code is changed that could impact app performance. The modifications are timing adjustments and method replacements within the test itself.

View GitHub Actions results

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026

⚠️ E2E Fixture Validation — Structural changes detected

Category Count
New keys 68
Missing keys 11
Type mismatches 0
Value mismatches 7 (informational)

The committed fixture schema is out of date. To update, comment:

@metamaskbot update-mobile-fixture

View full details | Download diff report

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 5, 2026

@christopherferreira9 christopherferreira9 changed the title test: simplify the input in order to avoif flakiness test: simplify the input in order to avoid flakiness Mar 5, 2026
@christopherferreira9 christopherferreira9 added this pull request to the merge queue Mar 5, 2026
Merged via the queue into main with commit 3f9eb24 Mar 5, 2026
122 checks passed
@christopherferreira9 christopherferreira9 deleted the cferreira/stabilize-flask-lookup-test branch March 5, 2026 15:40
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2026
@metamaskbot metamaskbot added the release-7.69.0 Issue or pull request that will be included in release 7.69.0 label Mar 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.69.0 Issue or pull request that will be included in release 7.69.0 size-S team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants