release: 7.69.0

.claude/commands/create-bug.md

@@ -124,15 +124,43 @@ For `render: shell` fields, wrap the value in a code fence:
 - Output the issue URL so the user can view it
 - Ask the user: "Would you like me to investigate the codebase for the possible root cause? (yes/no)"
 - Default is **no** — only proceed if the user explicitly says yes
-- If yes, investigate the codebase (research only — no code changes) and add a comment using:
+- If yes, perform the full **Root Cause Analysis** (Step 6)
+
+## Step 6: Root Cause Analysis
+
+When the user opts in, perform all three phases below and post a single comment on the issue with the combined findings.
+
+### 6a: Investigate the root cause
+
+- Trace the bug through the code to identify the exact files, lines, and logic causing the issue
+- Research only — no code changes
+
+### 6b: Identify regression PRs
+
+- Check `git log` history of affected files, comparing the release branch against the previous release branch
+- Identify which PRs introduced or surfaced the bug (new code, removed compensating mechanisms, refactors, etc.)
+- Note whether the issue is a new regression or pre-existing
+
+### 6c: Scope analysis
+
+- Search the codebase for the same pattern, function, or anti-pattern causing the bug
+- Identify all affected areas beyond the originally reported bug
+- If other features are impacted, file separate bug issues for each and link them
+
+### Comment format
+
+Post findings as a comment using:
 
 ```bash
 gh issue comment <issue-number> --repo MetaMask/metamask-mobile --body "..."
 ```
 
 The comment should include:
 
-- A summary of the possible root cause
-- The error flow with relevant file paths and line numbers
-- Key files table (file, line(s), description)
-- A suggested fix approach
+- **Summary** of the root cause
+- **Likely Regression PR(s)** — PR numbers, titles, authors, and explanation of what changed (or note if pre-existing)
+- **Error flow** with relevant file paths and line numbers
+- **Full scope of impact** — all affected files, hooks, and components beyond the reported bug
+- **Key files table** (file, line(s), description)
+- **Suggested fix approach**
+- **Links to related bugs** filed from the scope analysis

.cursor/worktrees.json

@@ -0,0 +1,9 @@
+{
+  "setup-worktree": [
+    "cp $ROOT_WORKTREE_PATH/.js.env .js.env",
+    "cp $ROOT_WORKTREE_PATH/.ios.env .ios.env",
+    "cp $ROOT_WORKTREE_PATH/.android.env .android.env",
+    "cp $ROOT_WORKTREE_PATH/.e2e.env .e2e.env",
+    "cp -r $ROOT_WORKTREE_PATH/.cursor/plans .cursor/plans"
+  ]
+}

.e2e.env.example

@@ -27,6 +27,18 @@ export TEST_SRP_2=
 export TEST_SRP_3=
 export BROWSERSTACK_USERNAME=
 export BROWSERSTACK_ACCESS_KEY=
+
+# Appwright performance -> Sentry instrumentation
+# If E2E_PERFORMANCE_SENTRY_DSN is defined, each scenario uploads timers to Sentry.
+export E2E_PERFORMANCE_SENTRY_DSN=
+# Optional. Set to false to disable upload even when DSN is present.
+export E2E_PERFORMANCE_SENTRY_ENABLED=true
+# Optional sample rate between 0 and 1 (default: 1).
+export E2E_PERFORMANCE_SENTRY_SAMPLE_RATE=1
+# Optional metadata for Sentry events.
+export E2E_PERFORMANCE_SENTRY_ENVIRONMENT=e2e-performance
+export E2E_PERFORMANCE_SENTRY_RELEASE=
+
 # Set BROWSERSTACK_LOCAL=true when using run-appwright:mm-connect-android-bs-local (BrowserStack Local tunnel)
 # BROWSERSTACK_LOCAL=true
 export SEEDLESS_ONBOARDING_ENABLED=

.eslintignore

@@ -1,5 +1,8 @@
 /scripts/inpage-bridge
 /app/core/InpageBridgeWeb3.js
+/app/components/UI/Charts/AdvancedChart/webview/chartLogic.js
+/app/components/UI/Charts/AdvancedChart/webview/chartLogicString.ts
+/app/components/UI/Charts/AdvancedChart/webview/syncChartLogic.js
 /app/util/blockies.js
 __snapshots__
 android

.eslintrc.js

@@ -105,11 +105,29 @@ module.exports = {
       },
     },
     {
+      // Temporary rollout strategy:
+      // Keep color-no-hex disabled for all tests by default, then re-enable it
+      // for specific folders in small PR batches. Once migration is complete,
+      // remove this override and enforce across all tests in:
+      // - app/components/
+      // - app/component-library/
       files: ['**/*.test.{js,ts,tsx}', '**/*.stories.{js,ts,tsx}'],
       rules: {
         '@metamask/design-tokens/color-no-hex': 'off',
       },
     },
+    {
+      files: ['app/components/UI/Card/**/*.{js,jsx,ts,tsx}'],
+      rules: {
+        '@metamask/design-tokens/color-no-hex': 'error',
+      },
+    },
+    {
+      files: ['app/components/Snaps/**/*.{js,jsx,ts,tsx}'],
+      rules: {
+        '@metamask/design-tokens/color-no-hex': 'error',
+      },
+    },
     {
       files: [
         'app/components/UI/Name/**/*.{js,ts,tsx}',

.github/CODEOWNERS

@@ -70,8 +70,11 @@ app/selectors/rampsController                          @MetaMask/ramp
 **/ramps/**                                             @MetaMask/ramp
 
 # Card Team
-app/components/UI/Card/              @MetaMask/card
-app/core/redux/slices/card/          @MetaMask/card
+app/components/UI/Card/                                    @MetaMask/card
+app/core/redux/slices/card/                                @MetaMask/card
+app/core/Engine/controllers/card-controller                @MetaMask/card
+app/core/Engine/messengers/card-controller-messenger       @MetaMask/card
+app/selectors/cardController.ts                            @MetaMask/card
 
 # Confirmation Team
 app/components/Views/confirmations                          @MetaMask/confirmations
@@ -107,7 +110,6 @@ app/core/SnapKeyring                                        @MetaMask/accounts-e
 
 # Co-owned by accounts and mobile-core-ux
 app/components/Views/AccountSelector                        @MetaMask/accounts-engineers @MetaMask/mobile-core-ux
-app/components/UI/EvmAccountSelectorList                    @MetaMask/accounts-engineers @MetaMask/mobile-core-ux
 
 # Multichain Accounts
 **/multichain-accounts/**                                   @MetaMask/accounts-engineers

.github/scripts/collect-qa-stats.mjs

@@ -0,0 +1,176 @@
+#!/usr/bin/env node
+/**
+ *
+ * Downloads pre-aggregated QA stats artifacts from the triggering CI run via the
+ * GitHub API and writes a qa-stats.json file for consumption by downstream workflows.
+ *
+ * Required env vars:
+ *   GITHUB_TOKEN      — GitHub Actions token for API access
+ *   WORKFLOW_RUN_ID   — ID of the CI run that produced the artifacts
+ *
+ * Example of output format of qa-stats.json:
+ *   {
+ *     "component_view_tests_count": 34,
+ *     "unit_test_count": 679,
+ *   }
+ *
+ * How to add a new metric:
+ *   1. Add a collector function below (see existing example)
+ *   2. Call it in main() and assign the result to stats
+ */
+
+import { readFile, writeFile, mkdir } from 'fs/promises';
+import { execSync } from 'child_process';
+import { join } from 'path';
+
+const GITHUB_TOKEN = process.env.GITHUB_TOKEN;
+const WORKFLOW_RUN_ID = process.env.WORKFLOW_RUN_ID;
+
+if (!WORKFLOW_RUN_ID) throw new Error('Missing required WORKFLOW_RUN_ID env var');
+if (!GITHUB_TOKEN) throw new Error('Missing required GITHUB_TOKEN env var');
+
+
+// ---------------------------------------------------------------------------
+// GitHub artifact helpers
+// ---------------------------------------------------------------------------
+
+let _artifactList = null;
+
+/**
+ * Fetches (and caches) the list of artifacts for the triggering CI run.
+ * First call fetches and stores, every subsequent call returns the cached value.
+ * 
+ * @returns {Promise<Array>}
+ */
+async function getArtifactList() {
+  if (_artifactList) return _artifactList;
+
+  const artifacts = [];
+  let page = 1;
+
+  while (true) {
+    const url = `https://api.github.com/repos/MetaMask/metamask-mobile/actions/runs/${WORKFLOW_RUN_ID}/artifacts?per_page=100&page=${page}`;
+    const res = await fetch(url, {
+      headers: {
+        Authorization: `Bearer ${GITHUB_TOKEN}`,
+        Accept: 'application/vnd.github+json',
+      },
+    });
+
+    if (!res.ok) {
+      throw new Error(`Failed to list artifacts (page ${page}): ${res.status} ${res.statusText}`);
+    }
+
+    const data = await res.json();
+    artifacts.push(...data.artifacts);
+
+    if (data.artifacts.length < 100) break;
+    page++;
+  }
+
+  _artifactList = artifacts;
+  return _artifactList;
+}
+
+/**
+ * Downloads a named artifact from the triggering CI run, extracts it into a
+ * local directory named after the artifact, and returns that directory path.
+ *
+ * @param {string} artifactName
+ * @returns {Promise<string>} Path to the directory containing the extracted files
+ */
+async function downloadArtifact(artifactName) {
+  const artifacts = await getArtifactList();
+  const artifact = artifacts.find((a) => a.name === artifactName);
+
+  if (!artifact) {
+    throw new Error(
+      `Artifact "${artifactName}" not found in run ${WORKFLOW_RUN_ID}`,
+    );
+  }
+
+  // GitHub redirects to a pre-signed S3 URL. Follow manually so the
+  // Authorization header is not forwarded to S3.
+  const redirectRes = await fetch(artifact.archive_download_url, {
+    headers: {
+      Authorization: `Bearer ${GITHUB_TOKEN}`,
+      Accept: 'application/vnd.github+json',
+    },
+    redirect: 'manual',
+  });
+
+  const downloadUrl = redirectRes.headers.get('location');
+  if (!downloadUrl) {
+    throw new Error(`No redirect URL returned for artifact "${artifactName}"`);
+  }
+
+  const zipRes = await fetch(downloadUrl);
+  if (!zipRes.ok) {
+    throw new Error(
+      `Failed to download artifact "${artifactName}": ${zipRes.status} ${zipRes.statusText}`,
+    );
+  }
+
+  const destDir = `./${artifactName}`;
+  await mkdir(destDir, { recursive: true });
+  const zipPath = join(destDir, `${artifactName}.zip`);
+  await writeFile(zipPath, Buffer.from(await zipRes.arrayBuffer()));
+  execSync(`unzip -q "${zipPath}" -d "${destDir}"`);
+
+  return destDir;
+}
+
+// ---------------------------------------------------------------------------
+// Collectors — one async function per metric source
+// ---------------------------------------------------------------------------
+
+async function collectComponentViewTestCount() {
+  const destDir = await downloadArtifact('cv-test-stats');
+  const raw = await readFile(join(destDir, 'cv-test-stats.json'), 'utf8');
+  const data = JSON.parse(raw);
+  return data.component_view_test_number;
+}
+
+async function collectUnitTestCount() {
+  const destDir = await downloadArtifact('unit-test-stats');
+  const raw = await readFile(join(destDir, 'unit-test-stats.json'), 'utf8');
+  const data = JSON.parse(raw);
+  return data.unit_test_number;
+}
+
+// ---------------------------------------------------------------------------
+// Main
+// ---------------------------------------------------------------------------
+
+async function main() {
+  const stats = {};
+
+  const collectors = [
+    {
+      key: 'component_view_tests_count',
+      collect: collectComponentViewTestCount,
+    },
+    {
+      key: 'unit_tests_count',
+      collect: collectUnitTestCount,
+    },
+  ];
+
+  for (const { key, collect } of collectors) {
+    try {
+      stats[key] = await collect();
+    } catch (err) {
+      // stat will not be present in the output file if the collector fails
+      console.error(`[${key}] collector failed, skipping stat:`, err.message);
+    }
+  }
+
+  const outputPath = './qa-stats.json';
+  await writeFile(outputPath, JSON.stringify(stats, null, 2), 'utf8');
+  console.log(`✅ QA stats written to ${outputPath}:`, stats);
+}
+
+main().catch((err) => {
+  console.error('\n❌ Unexpected error:', err);
+  process.exit(1);
+});