Downgrade eslint-plugin-import to ~2.26.0 #231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
mcmire
reviewed
Nov 3, 2023
| @@ -55,7 +55,7 @@ | |||
| "depcheck": "^1.4.3", | |||
| "eslint": "^8.44.0", | |||
| "eslint-config-prettier": "^8.8.0", | |||
| "eslint-plugin-import": "^2.27.5", | |||
| "eslint-plugin-import": "~2.26.0", | |||
There was a problem hiding this comment.
Can we go ahead and bump to ^2.29.0? It looks like there is a fix for something in 2.28.1, but I'm not sure if it's what you're referring to: https://github.com/import-js/eslint-plugin-import/blob/main/CHANGELOG.md#fixed
There was a problem hiding this comment.
I checked 2.29.0 but it does not fix the issue. There are several open issues about it:
- Regression in nested group order after v2.26 import-js/eslint-plugin-import#2909
- [import/order] Regression in
typebehavior withparentandsiblingimport-js/eslint-plugin-import#2683 - import/order relative import sorting order changed in 2.27.0 import-js/eslint-plugin-import#2682
- And more...
It looks like this PR will fix it: import-js/eslint-plugin-import#2721
There was a problem hiding this comment.
I see. Thanks for following up!
david0xd
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Versions >=2.27.0 of
eslint-plugin-importhave a regression, causing the import order to change. The recommended version in the ESLint config is~2.26.0for now.