Implement MetaMask/action-checkout-and-setup
#262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| cache: 'yarn' | ||
| - name: Install dependencies via Yarn | ||
| run: yarn --immutable | ||
| cache-node-modules: ${{ matrix.node-version == '22.x' }} |
Member
There was a problem hiding this comment.
Why do we only want to cache on a specific version?
Member
Author
There was a problem hiding this comment.
The cache key is the same, so it would show warnings that the cache could not be saved if we enable caching for all versions.
Member
There was a problem hiding this comment.
So do we not have caching for the other versions or we use the same cache?
Member
Author
There was a problem hiding this comment.
We use the same cache. AFAIK node_modules is the same for different Node.js versions.
FrederikBolding
approved these changes
Mar 5, 2025
mcmire
approved these changes
Mar 5, 2025
Contributor
mcmire
left a comment
mcmire
left a comment
There was a problem hiding this comment.
Looks good! Thanks for taking care of this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements
MetaMask/action-checkout-and-setup, which replaces the checkout and Node.js setup steps in CI.