-
-
Notifications
You must be signed in to change notification settings - Fork 16
Update tsconfig lib, module, and target options
#266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| "lib": ["ES2020"], | ||
| "module": "CommonJS", | ||
| "moduleResolution": "node", | ||
| "lib": ["ES2023"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can use a ECMAScript version here that's newer than the target, in which case TypeScript will transpile newer features if necessary.
| "module": "Node16", | ||
| "moduleResolution": "Node16", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting these to Node16 is recommended by the TypeScript team, and also speeds up ts-bridge.
cdae016 to
f9dc878
Compare
mcmire
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This updates the
lib,module,moduleResolution, andtargetoptions intsconfig.Note
Updates
tsconfig.jsonto uselibES2023,module/moduleResolutionNode16, and normalizestargetcasing.tsconfig.json):libfromES2020toES2023.moduletoNode16andmoduleResolutiontoNode16.targetcasing toES2020.Written by Cursor Bugbot for commit 7884311. This will update automatically on new commits. Configure here.