Skip to content

Conversation

@Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Jun 6, 2025

This fixes an issue in the compatibility tests workflow in CI (example here) since the latest version of eslint-plugin-import-x uses unrs-resolver, which needs to be added to the allow-scripts configuration. I've bumped it in the lockfile here and added the allow-scripts configuration to resolve the CI error.

@socket-security
Copy link

socket-security bot commented Jun 6, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​unrs/​resolver-binding-win32-x64-msvc@​1.7.111001003795100
Added@​unrs/​resolver-binding-win32-arm64-msvc@​1.7.111001003795100
Added@​unrs/​resolver-binding-win32-ia32-msvc@​1.7.111001003795100
Added@​unrs/​resolver-binding-linux-x64-gnu@​1.7.111001003793100
Added@​unrs/​resolver-binding-linux-x64-musl@​1.7.111001003794100
Added@​unrs/​resolver-binding-freebsd-x64@​1.7.111001003795100
Added@​unrs/​resolver-binding-linux-arm64-gnu@​1.7.111001003795100
Added@​unrs/​resolver-binding-linux-arm64-musl@​1.7.111001003795100
Added@​unrs/​resolver-binding-linux-arm-gnueabihf@​1.7.111001003795100
Added@​unrs/​resolver-binding-linux-arm-musleabihf@​1.7.111001003795100
Added@​unrs/​resolver-binding-linux-ppc64-gnu@​1.7.111001003795100
Added@​unrs/​resolver-binding-linux-riscv64-gnu@​1.7.111001003795100
Added@​unrs/​resolver-binding-linux-riscv64-musl@​1.7.111001003795100
Added@​unrs/​resolver-binding-linux-s390x-gnu@​1.7.111001003795100
Added@​unrs/​resolver-binding-darwin-arm64@​1.7.111001003795100
Added@​unrs/​resolver-binding-darwin-x64@​1.7.111001003795100
Added@​unrs/​resolver-binding-wasm32-wasi@​1.7.111001006695100
Added@​napi-rs/​wasm-runtime@​0.2.101001007292100
Added@​emnapi/​runtime@​1.4.3991007388100
Added@​emnapi/​core@​1.4.31001007588100
Added@​tybys/​wasm-util@​0.9.010010010080100
Updatedget-tsconfig@​4.8.1 ⏵ 4.10.1100 +11009980100
Addedunrs-resolver@​1.7.11911008194100
Addedstable-hash-x@​0.1.110010010083100
Updatedsemver@​7.6.3 ⏵ 7.7.2100 +1100100 +185100
Added@​emnapi/​wasi-threads@​1.0.210010010086100
Addednapi-postinstall@​0.2.49910010090100
Addedeslint-import-context@​0.1.81001009490100
Updatedeslint-plugin-import-x@​4.4.0 ⏵ 4.15.199 +2100100 +194 +4100

View full report

@socket-security
Copy link

socket-security bot commented Jun 6, 2025

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring alerts on:

View full report

@Mrtenz Mrtenz marked this pull request as ready for review August 8, 2025 13:56
@Mrtenz Mrtenz requested a review from a team August 8, 2025 13:56
@Gudahtt
Copy link
Member

Gudahtt commented Aug 8, 2025

@SocketSecurity ignore npm/@emnapi/[email protected]
@SocketSecurity ignore npm/@tybys/[email protected]
@SocketSecurity ignore npm/@unrs/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]

These packages have a really concerningly broad set of permissions 🤔. It does make sense given what they do, but it's really unfortunate that we need to use these for our ESLint plugin. We've crossed that bridge already so I won't suggest we reverse course here, and I understand this resolves some egregious performance issues in the original eslint-plugin-import package. But it's unfortunate. Ah well.

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt enabled auto-merge (squash) August 8, 2025 14:23
Copy link

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit 19a2d63 into main Aug 8, 2025
22 checks passed
@Gudahtt Gudahtt deleted the mrtenz/bump-eslint-plugin-import-x branch August 8, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants