-
-
Notifications
You must be signed in to change notification settings - Fork 16
Bump eslint-plugin-import-x in lockfile
#267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring alerts on:
|
|
@SocketSecurity ignore npm/@emnapi/[email protected] These packages have a really concerningly broad set of permissions 🤔. It does make sense given what they do, but it's really unfortunate that we need to use these for our ESLint plugin. We've crossed that bridge already so I won't suggest we reverse course here, and I understand this resolves some egregious performance issues in the original |
Gudahtt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
cryptodev-2s
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This fixes an issue in the compatibility tests workflow in CI (example here) since the latest version of
eslint-plugin-import-xusesunrs-resolver, which needs to be added to theallow-scriptsconfiguration. I've bumped it in the lockfile here and added theallow-scriptsconfiguration to resolve the CI error.