Skip to content

Conversation

@ecp4224
Copy link
Contributor

@ecp4224 ecp4224 commented Feb 22, 2025

Explanation

This PR reverts the socket server main code to match prod, and adds some configuration improvements for prod

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@ecp4224 ecp4224 self-assigned this Feb 22, 2025
@ecp4224 ecp4224 requested a review from a team as a code owner February 22, 2025 01:47
@codecov
Copy link

codecov bot commented Feb 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.16%. Comparing base (b99e473) to head (747b726).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1215      +/-   ##
==========================================
+ Coverage   74.05%   74.16%   +0.11%     
==========================================
  Files         182      182              
  Lines        4351     4351              
  Branches     1066     1066              
==========================================
+ Hits         3222     3227       +5     
+ Misses       1129     1124       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@christopherferreira9 christopherferreira9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

Copy link
Collaborator

@christopherferreira9 christopherferreira9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ecp4224 ecp4224 merged commit bc0a9a7 into main Feb 22, 2025
37 checks passed
@ecp4224 ecp4224 deleted the edkek/fix/socket branch February 22, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants