-
-
Notifications
You must be signed in to change notification settings - Fork 221
Socket Server Fixes #1215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Socket Server Fixes #1215
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1215 +/- ##
==========================================
+ Coverage 74.05% 74.16% +0.11%
==========================================
Files 182 182
Lines 4351 4351
Branches 1066 1066
==========================================
+ Hits 3222 3227 +5
+ Misses 1129 1124 -5 ☔ View full report in Codecov by Sentry. |
christopherferreira9
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
christopherferreira9
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM



Explanation
This PR reverts the socket server main code to match prod, and adds some configuration improvements for prod
References
Checklist