refactor: kernel-store into smaller units #456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirtimid
changed the title
grypez
reviewed
Mar 31, 2025
Comment on lines
13
to
18
| it('returns the index of the first key greater than the search key', () => { | ||
| const arr = ['a', 'c', 'e', 'g', 'i']; | ||
| expect(keySearch(arr, 'b')).toBe(1); | ||
| expect(keySearch(arr, 'd')).toBe(1); | ||
| expect(keySearch(arr, 'f')).toBe(-1); | ||
| }); |
Contributor
There was a problem hiding this comment.
This doesn't seem right.
Suggested change
| it('returns the index of the first key greater than the search key', () => { | |
| const arr = ['a', 'c', 'e', 'g', 'i']; | |
| expect(keySearch(arr, 'b')).toBe(1); | |
| expect(keySearch(arr, 'd')).toBe(1); | |
| expect(keySearch(arr, 'f')).toBe(-1); | |
| }); | |
| it('returns the index of the first key greater than the search key', () => { | |
| const arr = ['a', 'c', 'e', 'g', 'i']; | |
| expect(keySearch(arr, 'b')).toBe(1); | |
| expect(keySearch(arr, 'd')).toBe(2); | |
| expect(keySearch(arr, 'z')).toBe(-1); | |
| }); |
sirtimid
force-pushed
the
sirtimid/refactor-kernel-store
branch
from
d0140df to
3955435
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #454
Refactor the kernel store by breaking the current big file into smaller, easier-to-manage pieces.
Also added lots of missing unit tests.