feat: Add garbage collection finalization capability #457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirtimid
changed the title
sirtimid
force-pushed
the
sirtimid/trigger-garbage-collection
branch
2 times, most recently
from
d19cf9e to
a78930f
Compare
FUDCo
reviewed
Apr 2, 2025
sirtimid
force-pushed
the
sirtimid/trigger-garbage-collection
branch
from
c5c60fb to
3a88830
Compare
sirtimid
force-pushed
the
sirtimid/trigger-garbage-collection
branch
from
2b8c6b3 to
d1d6e38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #452
This PR adds reliable garbage collection and finalization capabilities to the kernel, enabling deterministic testing of GC-dependent behavior. swingset-liveslots expects a gcAndFinalize function to trigger GC and finalization when possible, using Node’s V8 capabilities (similar to Agoric’s implementation).
It also implements the previously missing final garbage collection logic. 🫣
An integration test has been added (not an end-to-end test, since GC is manually triggered via the new Kernel.reapVats() method).
You can observe the syscalls by running the test with verbosity:
yarn test packages/kernel-test/src/garbage-collection.test.ts --silent=falsewhich yields something like:
Lastly, vats in the kernel-test folder were moved into a dedicated subfolder for better organization.