refactor: Replace VatWorkerManager message types with new RPC pattern #481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttern - Standardize naming of VatWorkClient / Service types and classes across monorepo - Forego use of RpcService in extension due to exceptional nature of its VatWorkerService (passing message ports around)
5 tasks
rekmarks
added a commit
that referenced
this pull request
Apr 22, 2025
…#487) Closes: #369 Replaces all kernel and vat "message" types with the new `RpcClient` / `RpcService` pattern. For related work and the justification for this, see: - #369 - #474 - #481 Note that, in the course of implementing this refactor, it was discovered that we are never returning _any_ responses to syscalls originating from vat supervisors. This PR maintains a provisional solution using the new pattern, and #488 tracks the work to actually fix this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progresses: #369
Continues the work of #369 by replacing the "vat worker" command / reply types with the pattern introduced in #474. This primarily affects the extension, since only its
VatWorkerManager(so renamed fromVatWorkerService) logically crosses process boundaries. Its Node.js counterpart is just a class that lives next to the kernel, and is only affected by some renamed types.