feat(cli): Use @ocap/utils logger #485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grypez
force-pushed
the
grypez/cli-touchup
branch
from
eb9c24c to
8b0ad6f
Compare
rekmarks
requested changes
Apr 16, 2025
Member
rekmarks
left a comment
rekmarks
left a comment
There was a problem hiding this comment.
Looks good. A couple of inline items, and also:
The name of this PR should be feat(cli): Use @ocap/utils logger. If we were only adding tests the current name would be fine, but we're modifying the behavior of the module.
Comment on lines
63
to
66
| export async function bundleSource( | ||
| logger: Logger, | ||
| target: string, | ||
| ): Promise<void> { |
Member
There was a problem hiding this comment.
Ditto re: logger param position.
packages/cli/src/file.test.ts
Outdated
Comment on lines
82
to
84
| // Note: the behavior of fileExists is negotiable. The current implementation | ||
| // is a guess at a platform-independent behavior. This test suite documents | ||
| // the behavior of the current implementation. |
Member
There was a problem hiding this comment.
This comment should be moved to the implementation of the function, perhaps phrased along the lines of "may not work on Windows".
grypez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #217
@ocap/utilslogger