TS version of the libp2p browser-to-browser proof of concept #501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as off-topic.
This comment was marked as off-topic.
Contributor
Author
|
@SocketSecurity ignore-all |
Contributor
|
TBH I don't really get why we need this demo package inside our repo. |
Member
|
@sirtimid we don't need this package in the monorepo, but we don't have a compelling reason to separate it either. |
Contributor
Author
The primary motivation for me was making sure that all the libp2p voodoo got along with the rest of our build, test, & CI stuff (and there were some rough edges that got smoothed out in the process of doing that). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previously demonstrated libp2p browser-to-browser communications demo (found in https://github.com/FUDCo/brow-2-brow) was written in simple JavaScript since it was derived directly from the thing that https://docs.libp2p.io/guides/getting-started/webrtc/ walks you through, which was itself written in simple JS.
This version has been converted to TypeScript, hammered into compliance with our local eslint rules and other fussinesses, and integrated with the rest of our repo tooling so that you can build and run it in our environment.
While this now lives within our repo, it should be functionally independent of and operationally decoupled from all our other stuff.