feat(streams): Add stream splitting #503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rekmarks
force-pushed
the
rekm/stream-splicing
branch
from
3a21204 to
d19e1be
Compare
sirtimid
reviewed
Apr 29, 2025
Contributor
sirtimid
left a comment
sirtimid
left a comment
There was a problem hiding this comment.
Nice! I have some minor TS comments and a more important one with that harden
sirtimid
reviewed
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We removed stream multiplexing in #349 because we no longer had a use for it. With some of the plans we have for our logger, we once again find ourselves in a position where we'd like to differentiate traffic over a single stream. Multiplexing was pretty complex, so we'd prefer not to go back to it if possible. With these requirements in mind, this PR introduces "stream splitting" via the function
split()exported from@ocap/streams.The idea is simple: pass
split()a duplex stream and a number of type predicates, and receive an array of streams in return. Each stream represents the subset of the parent stream's traffic satisfying the corresponding predicate. Not very efficient for large numbers of channels or complex predicates, but our usage should be simple enough.