generated from MetaMask/metamask-module-template
-
Notifications
You must be signed in to change notification settings - Fork 7
feat(ocap-kernel): Implement hierarchical logging #504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e7be85f to
dd4973a
Compare
e7042df to
4e04c6b
Compare
sirtimid
reviewed
May 5, 2025
sirtimid
reviewed
May 5, 2025
sirtimid
reviewed
May 5, 2025
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw I noticed that the log methods (log, debug, info, etc.) are created using function binding but aren't hardened. We should alter the constructor of the Logger like so:
const bind = (level: LogLevel): LogMethod =>
harden(this.#dispatch.bind(this, {
...this.#options,
level,
}) as LogMethod);Thought this will probably brake some tests, so we should use the mocked SES environment there
sirtimid
reviewed
May 5, 2025
sirtimid
previously approved these changes
May 5, 2025
sirtimid
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #217
This PR constitutes the majority of the lift for the referenced logging ticket.
@metamask/logger@metamask/streamsDuplexStreaminjectStreammethod to theLoggerfor subscribing to logger notificationsmakeArrayTransportwhich returns a transport which appends log entries to the supplied array argument@metamask/ocap-kernelKernelconstructor is plumbed to subcomponents all the way to the vat user code's console endowment and logger power.@ocap/kernel-testprocess.stdoutto assert expected test vat operations