lint:fix reproduction #506
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rekmarks
reviewed
Apr 30, 2025
Comment on lines
+5
to
+9
| const mocks = vi.hoisted(() => { | ||
| const Foo = vi.fn(); | ||
| Foo.prototype.baz = vi.fn().mockResolvedValue('Hello fizz'); | ||
| return { Foo }; | ||
| }); |
Member
There was a problem hiding this comment.
It sucks that --fix is broken for this, but for future reference, this is semantically equivalent and keeps the linter happy:
Suggested change
| const mocks = vi.hoisted(() => { | |
| const Foo = vi.fn(); | |
| Foo.prototype.baz = vi.fn().mockResolvedValue('Hello fizz'); | |
| return { Foo }; | |
| }); | |
| const mocks = vi.hoisted(() => { | |
| class Foo { | |
| baz = vi.fn().mockResolvedValue('Hello fizz'); | |
| } | |
| return { Foo }; | |
| }); |
Member
There was a problem hiding this comment.
(Don't ask me why the linter is happy with this and not the other formulation.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A demonstration that the rule
vitest/prefer-spy-onoutputs code which is not semantically equivalent to the input.