Skip to content

feat: Send messages to vats from the control panel and remove sendVatCommand #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sirtimid merged 9 commits into from
May 5, 2025
Merged

feat: Send messages to vats from the control panel and remove sendVatCommand #508

sirtimid merged 9 commits into from
May 5, 2025

Conversation

@sirtimid
Copy link
Contributor

@sirtimid sirtimid commented May 2, 2025

Closes #489

With this PR

  • the sendVatCommand kernel method is removed
  • we now send messages to vats through the queueMessage kernel command (it was renamed from queueMessageFromKernel) from a form located at Object Registry tab
  • In anticipation of Move kernel ping method to platform packages #490 a placeholder for the ping call was preserved in the UI.
  • Added/fixed several tests

Preview

Screenshot 2025-05-02 at 17 45 56
queue-messages.mov

@sirtimid sirtimid requested a review from a team as a code owner May 2, 2025 15:51
@sirtimid sirtimid force-pushed the sirtimid/ui-queue-message branch from 60775dc to e57303f Compare May 2, 2025 16:13
@sirtimid sirtimid changed the title feat: Remove sendCommand and queue messages from control panel feat: Send messages to vats from the control panel and remove sendVatCommand May 2, 2025
@sirtimid sirtimid force-pushed the sirtimid/ui-queue-message branch from 7a83f6f to 42ed118 Compare May 2, 2025 22:10
@sirtimid sirtimid mentioned this pull request May 5, 2025
Merged
rekmarks
rekmarks requested changes May 5, 2025
View reviewed changes
Copy link
Member

@rekmarks rekmarks left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a minor thing and a CSS issue in the send form on the object registry tab:
image

@sirtimid sirtimid force-pushed the sirtimid/ui-queue-message branch from d53c93a to ef46769 Compare May 5, 2025 22:46
@sirtimid sirtimid enabled auto-merge (squash) May 5, 2025 22:46
@sirtimid sirtimid requested a review from rekmarks May 5, 2025 22:46
rekmarks
rekmarks approved these changes May 5, 2025
View reviewed changes
Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sirtimid sirtimid merged commit 521272f into main May 5, 2025
22 checks passed
@sirtimid sirtimid deleted the sirtimid/ui-queue-message branch May 5, 2025 23:39
sirtimid added a commit that referenced this pull request May 6, 2025
@sirtimid
feat: Add ping vat command (#509)
f415369 
Closes #490 

Changed in this PR:
- Added a `kernel.pingVat` command since it was removed from #508 
- Used the new command to the control panel 
- Added tests and covered some more lines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rekmarks rekmarks rekmarks approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove sendVatCommand and enqueue vat calls in Control Panel

3 participants

@sirtimid @rekmarks