fix: Restore Kernel hardening #510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirtimid
force-pushed
the
sirtimid/harden-kernel
branch
from
a184280 to
d0ebe2e
Compare
sirtimid
commented
May 6, 2025
| return this.queueMessage(bootstrapRoot, 'bootstrap', [roots]); | ||
| } | ||
| const bootstrapRoot = rootIds[config.bootstrap]; | ||
| if (bootstrapRoot) { |
Contributor
Author
There was a problem hiding this comment.
The isClusterConfig(config) above makes bootstrap required so this is not needed.
Contributor
There was a problem hiding this comment.
Wouldn't this apply to the if (config.bootstrap && !config.vats[config.bootstrap]) check above, too?
sirtimid
force-pushed
the
sirtimid/harden-kernel
branch
from
42247fa to
dc5bddd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-enables hardening for the Kernel class, which was previously disabled to facilitate testing. With the recent architectural improvements that split out components like KernelQueue, we can now properly test the Kernel without compromising security. The PR adopts a dependency-based mocking approach (properly mocking KernelQueue via vi.hoisted, injecting mock databases, etc.) instead of attempting to modify hardened objects directly. This ensures tests respect object capability security principles while still providing comprehensive coverage. Several new tests have been added for previously untested methods.