Skip to content

chore: Update vite & vitest dependencies to latest versions #717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sirtimid merged 5 commits into from
Jan 7, 2026
Merged

chore: Update vite & vitest dependencies to latest versions #717

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
65ee112
Upgrade vitest to v4
sirtimid Jan 5, 2026
d55fdcc
fix peerId mismatch
sirtimid Jan 5, 2026
89719e4
fix e2e platformservices test by silencing ses exit errors
sirtimid Jan 6, 2026
c6f57d3
clear mocks automatically
sirtimid Jan 6, 2026
b6d2104
fix lint and add comment
sirtimid Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,8 @@ const config = createConfig([
// We should enable this instead, but the rule is unreleased.
// See https://github.com/vitest-dev/eslint-plugin-vitest/issues/591
// 'vitest/unbound-method': 'error',
'vitest/no-alias-methods': 'off',
'vitest/prefer-called-exactly-once-with': 'off',
Comment on lines +135 to +136
Copy link
Member

@rekmarks rekmarks Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume these are new. Are they good? Should we add TODOs to enable them?

Copy link
Contributor Author

@sirtimid sirtimid Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a comment that these are temporary and should be removed when @metamask/eslint-config-vitest is updated

},
},

Expand Down
10 changes: 5 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,8 @@
"@typescript-eslint/eslint-plugin": "^8.29.0",
"@typescript-eslint/parser": "^8.29.0",
"@typescript-eslint/utils": "^8.29.0",
"@vitest/coverage-v8": "^3.2.4",
"@vitest/eslint-plugin": "^1.3.4",
"@vitest/coverage-v8": "^4.0.16",
"@vitest/eslint-plugin": "^1.6.5",
"@yarnpkg/types": "^4.0.1",
"depcheck": "^1.4.7",
"eslint": "^9.23.0",
Expand All @@ -97,9 +97,9 @@
"typedoc": "^0.28.1",
"typescript": "~5.8.2",
"typescript-eslint": "^8.29.0",
"vite": "^7.1.2",
"vite-tsconfig-paths": "^5.1.4",
"vitest": "^3.2.4",
"vite": "^7.3.0",
"vite-tsconfig-paths": "^6.0.3",
"vitest": "^4.0.16",
"vitest-fetch-mock": "^0.4.5"
},
"packageManager": "yarn@4.2.2",
Expand Down
2 changes: 1 addition & 1 deletion packages/brow-2-brow/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
"turbo": "^2.5.6",
"typescript": "~5.8.2",
"typescript-eslint": "^8.29.0",
"vitest": "^3.2.4"
"vitest": "^4.0.16"
},
"eslintConfig": {
"extends": "ipfs",
Expand Down
8 changes: 4 additions & 4 deletions packages/cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
"@typescript-eslint/eslint-plugin": "^8.29.0",
"@typescript-eslint/parser": "^8.29.0",
"@typescript-eslint/utils": "^8.29.0",
"@vitest/eslint-plugin": "^1.3.4",
"@vitest/eslint-plugin": "^1.6.5",
"depcheck": "^1.4.7",
"eslint": "^9.23.0",
"eslint-config-prettier": "^10.1.1",
Expand All @@ -82,16 +82,16 @@
"eslint-plugin-n": "^17.17.0",
"eslint-plugin-prettier": "^5.2.6",
"eslint-plugin-promise": "^7.2.1",
"jsdom": "^26.0.0",
"jsdom": "^27.4.0",
"prettier": "^3.5.3",
"rimraf": "^6.0.1",
"ses": "^1.14.0",
"turbo": "^2.5.6",
"typedoc": "^0.28.1",
"typescript": "~5.8.2",
"typescript-eslint": "^8.29.0",
"vite": "^7.1.2",
"vitest": "^3.2.4"
"vite": "^7.3.0",
"vitest": "^4.0.16"
},
"engines": {
"node": "^20.11 || >=22"
Expand Down
1 change: 1 addition & 0 deletions packages/cli/src/commands/watch.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ describe('watch', () => {

beforeEach(() => {
logger = new Logger('test');
vi.mocked(bundleFile).mockClear();
});

describe('watchDir', () => {
Expand Down
18 changes: 12 additions & 6 deletions packages/cli/src/file.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { dirname, join } from 'node:path';
import { describe, it, expect, vi } from 'vitest';
import { describe, it, expect, vi, beforeEach } from 'vitest';

import { cp, fileExists, isDirectory } from './file.ts';

Expand All @@ -24,6 +24,12 @@ const makeTestError = (code?: string): Error & { code?: string } => {
};

describe('file', () => {
beforeEach(() => {
mocks.access.mockClear();
mocks.lstat.mockClear();
mocks.copyFile.mockClear();
});
Copy link
Member

@rekmarks rekmarks Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We now have to do some of this manually? Seems like an unfortunate regression.

Copy link
Contributor Author

@sirtimid sirtimid Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I can add clearMocks: true to prevent this (In Vitest 4, restoreMocks only restores spies created with vi.spyOn(), not mocks created with vi.fn()) I'll change it.


describe('isDirectory', () => {
it('should return true if the path is a directory', async () => {
mocks.lstat.mockResolvedValue({ isDirectory: () => true });
Expand All @@ -48,14 +54,14 @@ describe('file', () => {
it('should throw an error if lstat throws an error with unknown code', async () => {
const error = makeTestError('UNKNOWN');
mocks.lstat.mockRejectedValue(error);
await expect(isDirectory('test')).rejects.toThrow(error);
await expect(isDirectory('test')).rejects.toThrowError(error);
expect(mocks.lstat).toHaveBeenCalledOnce();
});

it('should throw an error if lstat throws an error with no code', async () => {
const error = makeTestError();
mocks.lstat.mockRejectedValue(error);
await expect(isDirectory('test')).rejects.toThrow(error);
await expect(isDirectory('test')).rejects.toThrowError(error);
expect(mocks.lstat).toHaveBeenCalledOnce();
});
});
Expand All @@ -70,7 +76,7 @@ describe('file', () => {

it('should throw an error if the source is a directory', async () => {
mocks.lstat.mockResolvedValue({ isDirectory: () => true });
await expect(cp('source', 'destination')).rejects.toThrow(
await expect(cp('source', 'destination')).rejects.toThrowError(
/not implemented/u,
);
});
Expand Down Expand Up @@ -98,14 +104,14 @@ describe('file', () => {
it('should throw an error if access throws an error with unknown code', async () => {
const error = makeTestError('UNKNOWN');
mocks.access.mockRejectedValue(error);
await expect(fileExists('source')).rejects.toThrow(error);
await expect(fileExists('source')).rejects.toThrowError(error);
expect(mocks.access).toHaveBeenCalledOnce();
});

it('should throw an error if access throws an error with no code', async () => {
const error = makeTestError();
mocks.access.mockRejectedValue(error);
await expect(fileExists('source')).rejects.toThrow(error);
await expect(fileExists('source')).rejects.toThrowError(error);
expect(mocks.access).toHaveBeenCalledOnce();
});
});
Expand Down
6 changes: 3 additions & 3 deletions packages/create-package/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
"@typescript-eslint/eslint-plugin": "^8.29.0",
"@typescript-eslint/parser": "^8.29.0",
"@typescript-eslint/utils": "^8.29.0",
"@vitest/eslint-plugin": "^1.3.4",
"@vitest/eslint-plugin": "^1.6.5",
"depcheck": "^1.4.7",
"eslint": "^9.23.0",
"eslint-config-prettier": "^10.1.1",
Expand All @@ -76,8 +76,8 @@
"typedoc": "^0.28.1",
"typescript": "~5.8.2",
"typescript-eslint": "^8.29.0",
"vite": "^7.1.2",
"vitest": "^3.2.4",
"vite": "^7.3.0",
"vitest": "^4.0.16",
"yargs": "^17.7.2"
},
"engines": {
Expand Down
9 changes: 7 additions & 2 deletions packages/create-package/src/utils.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,11 @@ describe('create-package/utils', () => {

beforeEach(() => {
consoleErrorSpy = vi.spyOn(console, 'error');
vi.mocked(execa).mockClear();
vi.mocked(fs.writeFile).mockClear();
vi.mocked(fs.mkdir).mockClear();
vi.mocked(fs.access).mockClear();
vi.mocked(fsUtils.writeFiles).mockClear();
});

it('should write the expected files', async () => {
Expand Down Expand Up @@ -222,7 +227,7 @@ describe('create-package/utils', () => {

await expect(
finalizeAndWriteData(packageData, monorepoFileData),
).rejects.toThrow(/^The package directory already exists:/u);
).rejects.toThrowError(/^The package directory already exists:/u);

expect(fs.mkdir).not.toHaveBeenCalled();
expect(fs.writeFile).not.toHaveBeenCalled();
Expand All @@ -236,7 +241,7 @@ describe('create-package/utils', () => {

await expect(
finalizeAndWriteData(packageData, monorepoFileData),
).rejects.toThrow(/^foo$/u);
).rejects.toThrowError(/^foo$/u);
});
});
});
10 changes: 5 additions & 5 deletions packages/extension/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,8 @@
"@typescript-eslint/eslint-plugin": "^8.29.0",
"@typescript-eslint/parser": "^8.29.0",
"@typescript-eslint/utils": "^8.29.0",
"@vitejs/plugin-react": "^4.3.4",
"@vitest/eslint-plugin": "^1.3.4",
"@vitejs/plugin-react": "^5.1.2",
"@vitest/eslint-plugin": "^1.6.5",
"depcheck": "^1.4.7",
"eslint": "^9.23.0",
"eslint-config-prettier": "^10.1.1",
Expand All @@ -82,7 +82,7 @@
"eslint-plugin-n": "^17.17.0",
"eslint-plugin-prettier": "^5.2.6",
"eslint-plugin-promise": "^7.2.1",
"jsdom": "^26.0.0",
"jsdom": "^27.4.0",
"playwright": "^1.54.2",
"prettier": "^3.5.3",
"rimraf": "^6.0.1",
Expand All @@ -91,10 +91,10 @@
"typedoc": "^0.28.1",
"typescript": "~5.8.2",
"typescript-eslint": "^8.29.0",
"vite": "^7.1.2",
"vite": "^7.3.0",
"vite-plugin-checker": "^0.9.1",
"vite-plugin-static-copy": "^2.3.0",
"vitest": "^3.2.4"
"vitest": "^4.0.16"
},
"engines": {
"node": "^20.11 || >=22"
Expand Down
6 changes: 3 additions & 3 deletions packages/kernel-agents/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@
"@typescript-eslint/eslint-plugin": "^8.29.0",
"@typescript-eslint/parser": "^8.29.0",
"@typescript-eslint/utils": "^8.29.0",
"@vitest/eslint-plugin": "^1.3.4",
"@vitest/eslint-plugin": "^1.6.5",
"depcheck": "^1.4.7",
"eslint": "^9.23.0",
"eslint-config-prettier": "^10.1.1",
Expand All @@ -95,8 +95,8 @@
"typedoc": "^0.28.1",
"typescript": "~5.8.2",
"typescript-eslint": "^8.29.0",
"vite": "^7.1.2",
"vitest": "^3.2.4"
"vite": "^7.3.0",
"vitest": "^4.0.16"
},
"engines": {
"node": "^20.11 || >=22"
Expand Down
6 changes: 3 additions & 3 deletions packages/kernel-browser-runtime/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@
"@typescript-eslint/eslint-plugin": "^8.29.0",
"@typescript-eslint/parser": "^8.29.0",
"@typescript-eslint/utils": "^8.29.0",
"@vitest/eslint-plugin": "^1.3.4",
"@vitest/eslint-plugin": "^1.6.5",
"depcheck": "^1.4.7",
"eslint": "^9.23.0",
"eslint-config-prettier": "^10.1.1",
Expand All @@ -109,10 +109,10 @@
"typedoc": "^0.28.1",
"typescript": "~5.8.2",
"typescript-eslint": "^8.29.0",
"vite": "^7.1.2",
"vite": "^7.3.0",
"vite-plugin-checker": "^0.9.1",
"vite-plugin-static-copy": "^2.3.0",
"vitest": "^3.2.4"
"vitest": "^4.0.16"
},
"engines": {
"node": "^20.11 || >=22"
Expand Down
4 changes: 4 additions & 0 deletions packages/kernel-browser-runtime/src/internal-comms/internal-connections.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,10 @@ describe('internal-connections', () => {
: undefined,
);

beforeEach(() => {
mockHandleMessage.mockClear();
});

it('should handle new internal process connections', async () => {
receiveInternalConnections({
handleInternalMessage: mockHandleMessage,
Expand Down
9 changes: 7 additions & 2 deletions packages/kernel-browser-runtime/src/kernel-worker/middleware/panel-message.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,11 @@ describe('makePanelMessageMiddleware', () => {
let engine: JsonRpcEngineV2;

beforeEach(() => {
// Clear mocks before each test
mockExecute.mockClear();
mockAssertHasMethod.mockClear();
mockAssertHasMethod.mockImplementation(() => undefined);

// Set up mocks
mockKernel = {} as Kernel;
mockKernelDatabase = {
Expand Down Expand Up @@ -112,7 +117,7 @@ describe('makePanelMessageMiddleware', () => {
params: { foo: 'bar' },
} as JsonRpcRequest;

await expect(engine.handle(request)).rejects.toThrow(error);
await expect(engine.handle(request)).rejects.toThrowError(error);
expect(mockExecute).toHaveBeenCalledWith('testMethod1', { foo: 'bar' });
});

Expand Down Expand Up @@ -157,7 +162,7 @@ describe('makePanelMessageMiddleware', () => {
throw new Error('The method does not exist / is not available.');
});

await expect(engine.handle(request)).rejects.toThrow(
await expect(engine.handle(request)).rejects.toThrowError(
'The method does not exist / is not available.',
);
expect(mockExecute).not.toHaveBeenCalled();
Expand Down
10 changes: 6 additions & 4 deletions packages/kernel-browser-runtime/src/utils/relay-query-string.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,12 @@ import {

// Mock the logger module
vi.mock('@metamask/logger', () => ({
Logger: vi.fn().mockImplementation(() => ({
error: vi.fn(),
warn: vi.fn(),
})),
Logger: vi.fn().mockImplementation(function () {
return {
error: vi.fn(),
warn: vi.fn(),
};
}),
}));

describe('relay-query-string', () => {
Expand Down
8 changes: 4 additions & 4 deletions packages/kernel-errors/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
"@typescript-eslint/eslint-plugin": "^8.29.0",
"@typescript-eslint/parser": "^8.29.0",
"@typescript-eslint/utils": "^8.29.0",
"@vitest/eslint-plugin": "^1.3.4",
"@vitest/eslint-plugin": "^1.6.5",
"depcheck": "^1.4.7",
"eslint": "^9.23.0",
"eslint-config-prettier": "^10.1.1",
Expand All @@ -82,16 +82,16 @@
"eslint-plugin-n": "^17.17.0",
"eslint-plugin-prettier": "^5.2.6",
"eslint-plugin-promise": "^7.2.1",
"jsdom": "^26.0.0",
"jsdom": "^27.4.0",
"prettier": "^3.5.3",
"rimraf": "^6.0.1",
"ses": "^1.14.0",
"turbo": "^2.5.6",
"typedoc": "^0.28.1",
"typescript": "~5.8.2",
"typescript-eslint": "^8.29.0",
"vite": "^7.1.2",
"vitest": "^3.2.4"
"vite": "^7.3.0",
"vitest": "^4.0.16"
},
"engines": {
"node": "^20.11 || >=22"
Expand Down
6 changes: 3 additions & 3 deletions packages/kernel-language-model-service/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@
"@typescript-eslint/eslint-plugin": "^8.29.0",
"@typescript-eslint/parser": "^8.29.0",
"@typescript-eslint/utils": "^8.29.0",
"@vitest/eslint-plugin": "^1.3.4",
"@vitest/eslint-plugin": "^1.6.5",
"depcheck": "^1.4.7",
"eslint": "^9.23.0",
"eslint-config-prettier": "^10.1.1",
Expand All @@ -96,8 +96,8 @@
"typedoc": "^0.28.1",
"typescript": "~5.8.2",
"typescript-eslint": "^8.29.0",
"vite": "^7.1.2",
"vitest": "^3.2.4"
"vite": "^7.3.0",
"vitest": "^4.0.16"
},
"engines": {
"node": "^20.11 || >=22"
Expand Down
6 changes: 3 additions & 3 deletions packages/kernel-platforms/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@
"@typescript-eslint/eslint-plugin": "^8.29.0",
"@typescript-eslint/parser": "^8.29.0",
"@typescript-eslint/utils": "^8.29.0",
"@vitest/eslint-plugin": "^1.3.4",
"@vitest/eslint-plugin": "^1.6.5",
"depcheck": "^1.4.7",
"eslint": "^9.23.0",
"eslint-config-prettier": "^10.1.1",
Expand All @@ -95,8 +95,8 @@
"typedoc": "^0.28.1",
"typescript": "~5.8.2",
"typescript-eslint": "^8.29.0",
"vite": "^7.1.2",
"vitest": "^3.2.4"
"vite": "^7.3.0",
"vitest": "^4.0.16"
},
"engines": {
"node": "^20.11 || >=22"
Expand Down
Loading
Loading