Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/lint-build-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ jobs:
run: yarn test:e2e:ci
- name: Upload test artifacts
if: ${{ failure() && steps.e2e.conclusion == 'failure' }}
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v6
with:
name: playwright-traces
path: packages/extension/test-results
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- run: yarn build
- name: Upload build artifacts
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v6
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version mismatch between upload and download artifact actions

Medium Severity

The PR updates actions/upload-artifact from v4 to v6 but leaves actions/download-artifact at v4. In the publish-release workflow, artifacts are uploaded with v6 and then downloaded with v4 in the publish-npm-dry-run and publish-npm jobs. Since v6 uses @actions/artifact v5.x internally while v4 uses an older version, this version mismatch could cause compatibility issues and break the release publishing workflow. The download-artifact action may need to be updated to a compatible version (e.g., v6) alongside this change.

Additional Locations (2)

Fix in Cursor Fix in Web

with:
name: publish-release-artifacts-${{ github.sha }}
include-hidden-files: true
Expand Down
Loading