Skip to content

chore(deps): Update MetaMask ESLint dependencies and fix JSDoc compliance #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sirtimid merged 7 commits into from
Jan 13, 2026
Merged

chore(deps): Update MetaMask ESLint dependencies and fix JSDoc compliance #741

sirtimid merged 7 commits into from
Jan 13, 2026
+1,366 −359

Conversation

@sirtimid
Copy link
Contributor

@sirtimid sirtimid commented Jan 12, 2026 •
edited by cursor bot
Loading

Summary

  • Update @metamask/eslint-config from 14.0.0 to 15.0.0
  • Update @metamask/eslint-config-vitest from 1.0.0 to 15.0.0
  • Add JSDoc rules to eslint.config.mjs to enforce documentation standards
  • Fix JSDoc compliance issues across all packages (missing @param descriptions, missing @returns declarations)
  • Update test coverage thresholds based on actual coverage

Test plan

  • yarn lint passes with no errors
  • yarn build succeeds for all packages
  • yarn test passes with updated coverage thresholds

🤖 Generated with Claude Code

Note

ESLint/JSDoc enforcement

  • Upgrade @metamask/eslint-config* to v15 and tighten linting; add jsdoc/require-jsdoc with targeted exceptions (tests, config files)
  • Require explicit TS return types; disable certain JSDoc rules for test/config scopes

Docs and code comments

  • Add and refine JSDoc for constructors/methods/classes across kernel-*, streams, logger, ocap-kernel, etc.; remove legacy lint suppressions

Dependency updates

  • Bump @metamask/utils to ^11.9.0, @metamask/rpc-errors to ^7.0.3, @metamask/snaps-utils to ^11.7.1, and related packages; update yarn.lock (incl. new Octokit deps via auto-changelog v5.3.0)

Config tweaks

  • Adjust ESLint overrides for test/types and Vite-related files; small comment/typing cleanups in tests

Written by Cursor Bugbot for commit 811f960. This will update automatically on new commits. Configure here.

@sirtimid sirtimid requested a review from a team as a code owner January 12, 2026 19:28
@socket-security
Copy link

socket-security bot commented Jan 12, 2026 •
edited
Loading

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Updated@​metamask/​eslint-config-vitest@​1.0.0 ⏵ 15.0.068 +310078 +289 +6100
Updated@​metamask/​snaps-utils@​11.6.1 ⏵ 11.7.198 -210076 -2495 -5100
Updated@​metamask/​create-release-branch@​4.1.2 ⏵ 4.1.383 +110094 +187 -1100
Updated@​metamask/​eslint-config@​14.0.0 ⏵ 15.0.09910085 +189 +8100
Updated@​metamask/​eslint-config-nodejs@​14.0.0 ⏵ 15.0.099 +11008689 +8100
Updated@​metamask/​eslint-config-typescript@​14.0.0 ⏵ 15.0.099 +110086 +291 +8100
Updated@​metamask/​utils@​11.8.1 ⏵ 11.9.099 +110094 +192 +4100
Updated@​metamask/​auto-changelog@​5.0.1 ⏵ 5.3.098100100 +193 +7100

View full report

@socket-security
Copy link

socket-security bot commented Jan 12, 2026 •
edited
Loading

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring alerts on:

View full report

@sirtimid
Copy link
Contributor Author

sirtimid commented Jan 12, 2026

@SocketSecurity ignore-all

sirtimid and others added 6 commits January 13, 2026 15:28
@sirtimid @claude
chore(deps): Update MetaMask dependencies and fix JSDoc compliance
d7286d0 
Update MetaMask packages to latest versions:
- @metamask/eslint-config: 14.0.0 → 15.0.0
- @metamask/eslint-config-nodejs: 14.0.0 → 15.0.0
- @metamask/eslint-config-typescript: 14.0.0 → 15.0.0
- @metamask/eslint-config-vitest: 1.0.0 → 15.0.0
- @metamask/auto-changelog: 5.0.1 → 5.3.0
- @metamask/utils: 11.4.2 → 11.9.0
- @metamask/snaps-utils: 11.6.1 → 11.7.1

Update eslint.config.mjs to configure JSDoc rules:
- Require JSDoc for functions, methods, and classes in TypeScript
- Disable JSDoc requirement for test files and config files

Add missing JSDoc documentation across all packages to comply with
the new linting rules.

Co-Authored-By: Claude <[email protected]>
@sirtimid @claude
chore: Update test coverage thresholds and yarn.lock
049bab0 
Update coverage thresholds based on actual test coverage after
dependency updates.

Co-Authored-By: Claude Opus 4.5 <[email protected]>
@sirtimid
fix lint
9350f3e
@sirtimid
fill empty jsdocs
4877f84
@sirtimid
add missing jsdoc
82d2d5c
@sirtimid
add missing jsdoc
c5b1506
@sirtimid sirtimid force-pushed the sirtimid/update-metamask-deps branch from ee06644 to c5b1506 Compare January 13, 2026 15:16
grypez
grypez requested changes Jan 13, 2026
View reviewed changes
Copy link
Contributor

@grypez grypez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we disable the constructor docstring requirement? It seems excessive.

@sirtimid
Copy link
Contributor Author

sirtimid commented Jan 13, 2026

Can we disable the constructor docstring requirement? It seems excessive.

I tried to disable as less as possible from these new MM eslint rules. I don't think it hurts.

@sirtimid sirtimid requested a review from grypez January 13, 2026 16:42
@grypez
Copy link
Contributor

grypez commented Jan 13, 2026

Can we disable the constructor docstring requirement? It seems excessive.

I tried to disable as less as possible from these new MM eslint rules. I don't think it hurts.

Feels like noise, not signal. The boilerplate is more tolerable when the bot does it for you, but if the bot could produce the doc string anyway, who is it for?

@sirtimid sirtimid merged commit 8c4f04b into main Jan 13, 2026
27 checks passed
@sirtimid sirtimid deleted the sirtimid/update-metamask-deps branch January 13, 2026 16:58
@sirtimid
Copy link
Contributor Author

sirtimid commented Jan 13, 2026

Can we disable the constructor docstring requirement? It seems excessive.

I tried to disable as less as possible from these new MM eslint rules. I don't think it hurts.

Feels like noise, not signal. The boilerplate is more tolerable when the bot does it for you, but if the bot could produce the doc string anyway, who is it for?

I guess for people still using an IDE? I still am. Though I can live without it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grypez grypez grypez approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sirtimid @grypez