Skip to content

feat: Enhance CAIP-294 wallet announcement for mobile flask builds #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
abretonc7s wants to merge 1 commit into from
Closed

feat: Enhance CAIP-294 wallet announcement for mobile flask builds #418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/extension-provider/createExternalExtensionProvider.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,9 @@ describe('getBuildType', () => {
{ payload: 'io.metamask.beta', expected: 'beta' },
{ payload: 'io.metamask', expected: 'stable' },
{ payload: 'io.metamask.flask', expected: 'flask' },
{ payload: 'io.metamask.mobile', expected: 'stable' },
{ payload: 'io.metamask.mobile.beta', expected: 'beta' },
{ payload: 'io.metamask.mobile.flask', expected: 'flask' },
{ payload: 'io.metamask.unknown', expected: undefined },
];

Expand Down
3 changes: 3 additions & 0 deletions src/extension-provider/createExternalExtensionProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,9 @@ export function getBuildType(rdns: string): string | undefined {
'io.metamask': 'stable',
'io.metamask.beta': 'beta',
'io.metamask.flask': 'flask',
'io.metamask.mobile': 'stable',
'io.metamask.mobile.beta': 'beta',
'io.metamask.mobile.flask': 'flask',
};
return rndsToIdDefinition[rdns];
}
36 changes: 36 additions & 0 deletions src/initializeInpageProvider.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,19 @@ describe('announceCaip294WalletData', () => {
expect(getBuildType).toHaveBeenCalledWith(mockProviderInfo.rdns);
expect(announceWallet).not.toHaveBeenCalled();
});

it('should not announce wallet if mobile build type is not flask', async () => {
const mobileMockProviderInfo = {
...mockProviderInfo,
rdns: 'io.metamask.mobile',
};
(getBuildType as jest.Mock).mockReturnValue('stable');

await announceCaip294WalletData(mockProvider, mobileMockProviderInfo);

expect(getBuildType).toHaveBeenCalledWith(mobileMockProviderInfo.rdns);
expect(announceWallet).not.toHaveBeenCalled();
});
});

describe('build type is flask', () => {
Expand Down Expand Up @@ -101,5 +114,28 @@ describe('announceCaip294WalletData', () => {
targets: [],
});
});

it('should announce wallet with caip-348 target for mobile flask', async () => {
const extensionId = 'test-extension-id';
Copy link
Contributor

@jiexi jiexi Apr 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit. mobile won't have an extension id, so a caip-348 target won't be announced.

const mobileMockProviderInfo = {
...mockProviderInfo,
rdns: 'io.metamask.mobile.flask',
};
(getBuildType as jest.Mock).mockReturnValue('flask');
(mockProvider.request as jest.Mock).mockReturnValue({ extensionId });

await announceCaip294WalletData(mockProvider, mobileMockProviderInfo);

expect(getBuildType).toHaveBeenCalledWith(mobileMockProviderInfo.rdns);
expect(announceWallet).toHaveBeenCalledWith({
...mobileMockProviderInfo,
targets: [
{
type: 'caip-348',
value: extensionId,
},
],
});
});
});
});
Loading