Detect usage of npx in yaml & JS code #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
reviewed
Jan 6, 2026
Member
There was a problem hiding this comment.
Is there an easy way to ignore this warning for vendored code? We have some third-party minified code in mobile and extension that would contain the string npx (e.g. a fixture of a snap bundle used by e2e tests)
Contributor
Author
Gudahtt
reviewed
Jan 6, 2026
| // Using yarn dlx | ||
| function goodYarnDlx() { | ||
| // ok: npx-usage-js | ||
| const cmd = `yarn dlx create-react-app my-app`; |
Member
There was a problem hiding this comment.
Maybe worth considering adding a warning about yarn dlx as well (it also doesn't update the lockfile, though at least it wouldn't bypass a pre-existing one).
But we can consider that in a separate PR
joaoloureirop
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #10 we added detection for
npxusage in shell / JSON scripts. However, there are other cases where we are usingnpxin javascript files, as well as in GitHub workflows. This PR adds support for detection in those languages to ensure that potential supply chain issues are detected.Note that we intentionally match all strings using
npxin JS/TS so that even error messages prompting people to run npx scripts are flagged.Note
Introduces detection of unsafe
npxexecution outside lockfiles across JS/TS code and CI YAML.npx-usage-js.yml(JavaScript/TypeScript) andnpx-usage-yml.yml(YAML) rules with WARNING severity,securitytag, rationale/help, and remediation messagenpxin JS/TS string/template literals and in YAMLrun:steps (including scoped packages, flags, env vars, and command chains)jest,eslint,prettier,create-react-app; allowyarn,npm run,yarn dlx)Written by Cursor Bugbot for commit 075f928. This will update automatically on new commits. Configure here.