Retry attempts to close the dialog

[jeffsmale90]

Description

Sometimes after clicking "Grant" on the Permission Picker, sometimes the dialog does not close before loading the Sign Permission Confirmation.

This PR adds retry logic to the attempt to close the dialog:

• if the first attempt fails, we check whether the dialog exists (by calling snap_getInterfaceContext)
• if the dialog does exist, we try again
• if the second attempt fails, we just resolve for now

This is difficult to test, as we do not have reproduction steps yet.

Pre-merge author checklist

• I've followed MetaMask 7715 Permissions Snaps Contributor Docs and MetaMask 7715 Permissions Snaps Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Medium Risk
Changes dialog teardown behavior by adding retries and interface-existence checks, which could affect UI flow timing and state cleanup if snap RPC calls behave unexpectedly. Covered by expanded unit tests, but still touches user-facing confirmation transitions.

Overview
Improves DialogInterface.close() to be best-effort and more resilient: it now retries snap_resolveInterface up to 3 times, checks for interface existence via snap_getInterfaceContext, and always clears local dialog state without throwing.

Updates unit tests to cover success, retry, already-closed, and repeated-failure scenarios, and removes an unused auth argument from the createProfileSyncManager call.

^{Written by Cursor Bugbot for commit 73cc32d. This will update automatically on new commits. Configure here.}

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}