Improve clarity of justification field in Permission Picker#282
Merged
jeffsmale90 merged 3 commits intomainfrom Mar 15, 2026
Merged
Improve clarity of justification field in Permission Picker#282jeffsmale90 merged 3 commits intomainfrom
jeffsmale90 merged 3 commits intomainfrom
Conversation
- Change label from 'Reason' to 'Justification' - Increase max length from 120 to 300 - Increase max length that will be shown without ellipsis from 20 to 165 - Stack components vertically to reduce whitespace
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
mj-kiwi
approved these changes
Mar 12, 2026
mj-kiwi
previously approved these changes
Mar 12, 2026
mj-kiwi
approved these changes
Mar 15, 2026
Co-authored-by: jeffsmale90 <jeffsmale90@users.noreply.github.com>
…cationLabel and justificationTooltip
636af3e to
6514f64
Compare
7 tasks
github-merge-queue bot
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
Mar 17, 2026
…-13.23.0 (#40933) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Bump @metamask/gator-permissions-snap from ^1.2.0 to ^1.3.0 https://github.com/MetaMask/snap-7715-permissions/releases/tag/v18.0.0 ### Changed - `justification` field may now be longer (up to 300 chars), and will be more prominently displayed in the UI ([#282](MetaMask/snap-7715-permissions#282)) ### Fixed - Improve display of existing permissions before granting a new permission ([#284](MetaMask/snap-7715-permissions#284), [#283](MetaMask/snap-7715-permissions#283)) - Show all permissions from all chains granted to the requesting origin - Group existing permissions by granting account - Improved validation and asyncronous loading with caching, and skeleton UI [](https://codespaces.new/MetaMask/metamask-extension/pull/40933?quickstart=1) ## **Changelog** Changes to unreleased feature, and slight change to `justification` field formatting. <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: Advanced Permissions `justification` parameter now accepts up to 300 chars, shown more clearly in confirmation. ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk dependency-only bump; primary risk is behavioral changes inside the updated snap affecting permission flows at runtime. > > **Overview** > Updates the `@metamask/gator-permissions-snap` dependency from `^1.2.0` to `^1.3.0`, with corresponding `yarn.lock` resolution/checksum changes to pull the new package version. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit e3a10c9. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
runway-github bot
added a commit
to MetaMask/metamask-extension
that referenced
this pull request
Mar 17, 2026
….0 cp-13.23.0 (#40933) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Bump @metamask/gator-permissions-snap from ^1.2.0 to ^1.3.0 https://github.com/MetaMask/snap-7715-permissions/releases/tag/v18.0.0 ### Changed - `justification` field may now be longer (up to 300 chars), and will be more prominently displayed in the UI ([#282](MetaMask/snap-7715-permissions#282)) ### Fixed - Improve display of existing permissions before granting a new permission ([#284](MetaMask/snap-7715-permissions#284), [#283](MetaMask/snap-7715-permissions#283)) - Show all permissions from all chains granted to the requesting origin - Group existing permissions by granting account - Improved validation and asyncronous loading with caching, and skeleton UI [](https://codespaces.new/MetaMask/metamask-extension/pull/40933?quickstart=1) ## **Changelog** Changes to unreleased feature, and slight change to `justification` field formatting. <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: Advanced Permissions `justification` parameter now accepts up to 300 chars, shown more clearly in confirmation. ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk dependency-only bump; primary risk is behavioral changes inside the updated snap affecting permission flows at runtime. > > **Overview** > Updates the `@metamask/gator-permissions-snap` dependency from `^1.2.0` to `^1.3.0`, with corresponding `yarn.lock` resolution/checksum changes to pull the new package version. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit e3a10c9. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
runway-github bot
added a commit
to MetaMask/metamask-extension
that referenced
this pull request
Mar 17, 2026
….0 cp-13.23.0 (#40933) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Bump @metamask/gator-permissions-snap from ^1.2.0 to ^1.3.0 https://github.com/MetaMask/snap-7715-permissions/releases/tag/v18.0.0 ### Changed - `justification` field may now be longer (up to 300 chars), and will be more prominently displayed in the UI ([#282](MetaMask/snap-7715-permissions#282)) ### Fixed - Improve display of existing permissions before granting a new permission ([#284](MetaMask/snap-7715-permissions#284), [#283](MetaMask/snap-7715-permissions#283)) - Show all permissions from all chains granted to the requesting origin - Group existing permissions by granting account - Improved validation and asyncronous loading with caching, and skeleton UI [](https://codespaces.new/MetaMask/metamask-extension/pull/40933?quickstart=1) ## **Changelog** Changes to unreleased feature, and slight change to `justification` field formatting. <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: Advanced Permissions `justification` parameter now accepts up to 300 chars, shown more clearly in confirmation. ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk dependency-only bump; primary risk is behavioral changes inside the updated snap affecting permission flows at runtime. > > **Overview** > Updates the `@metamask/gator-permissions-snap` dependency from `^1.2.0` to `^1.3.0`, with corresponding `yarn.lock` resolution/checksum changes to pull the new package version. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit e3a10c9. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
runway-github bot
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
Mar 17, 2026
…snap from ^1.2.0 to ^1.3.0 cp-13.23.0 (#40933) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Bump @metamask/gator-permissions-snap from ^1.2.0 to ^1.3.0 https://github.com/MetaMask/snap-7715-permissions/releases/tag/v18.0.0 ### Changed - `justification` field may now be longer (up to 300 chars), and will be more prominently displayed in the UI ([#282](MetaMask/snap-7715-permissions#282)) ### Fixed - Improve display of existing permissions before granting a new permission ([#284](MetaMask/snap-7715-permissions#284), [#283](MetaMask/snap-7715-permissions#283)) - Show all permissions from all chains granted to the requesting origin - Group existing permissions by granting account - Improved validation and asyncronous loading with caching, and skeleton UI [](https://codespaces.new/MetaMask/metamask-extension/pull/40933?quickstart=1) ## **Changelog** Changes to unreleased feature, and slight change to `justification` field formatting. <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: Advanced Permissions `justification` parameter now accepts up to 300 chars, shown more clearly in confirmation. ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk dependency-only bump; primary risk is behavioral changes inside the updated snap affecting permission flows at runtime. > > **Overview** > Updates the `@metamask/gator-permissions-snap` dependency from `^1.2.0` to `^1.3.0`, with corresponding `yarn.lock` resolution/checksum changes to pull the new package version. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit e3a10c9. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
7 tasks
chloeYue
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
Mar 17, 2026
…snap from ^1.2.0 to ^1.3.0 cp-13.23.0 (#40942) - chore: Bump @metamask/gator-permissions-snap from ^1.2.0 to ^1.3.0 cp-13.23.0 (#40933) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Bump @metamask/gator-permissions-snap from ^1.2.0 to ^1.3.0 https://github.com/MetaMask/snap-7715-permissions/releases/tag/v18.0.0 ### Changed - `justification` field may now be longer (up to 300 chars), and will be more prominently displayed in the UI ([#282](MetaMask/snap-7715-permissions#282)) ### Fixed - Improve display of existing permissions before granting a new permission ([#284](MetaMask/snap-7715-permissions#284), [#283](MetaMask/snap-7715-permissions#283)) - Show all permissions from all chains granted to the requesting origin - Group existing permissions by granting account - Improved validation and asyncronous loading with caching, and skeleton UI [](https://codespaces.new/MetaMask/metamask-extension/pull/40933?quickstart=1) ## **Changelog** Changes to unreleased feature, and slight change to `justification` field formatting. <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: Advanced Permissions `justification` parameter now accepts up to 300 chars, shown more clearly in confirmation. ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk dependency-only bump; primary risk is behavioral changes inside the updated snap affecting permission flows at runtime. > > **Overview** > Updates the `@metamask/gator-permissions-snap` dependency from `^1.2.0` to `^1.3.0`, with corresponding `yarn.lock` resolution/checksum changes to pull the new package version. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit e3a10c9. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> [7d516fc](7d516fc) --------- Co-authored-by: jeffsmale90 <6363749+jeffsmale90@users.noreply.github.com> Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Low risk UI/i18n and validation limit updates; primary risk is a missing/incorrect locale key causing the label/tooltip to render improperly.
Overview
Improves clarity of the permission justification field by renaming the i18n keys and UI label/tooltip from Reason to Justification across the permission request flow and existing-permissions formatting.
Increases the allowed justification length in
zSanitizedJustificationfrom 120 to 300 characters and updates tests accordingly, while also showing more text before truncation (ShowMoreText20 → 165) and stacking the justification label/value vertically to reduce whitespace.Written by Cursor Bugbot for commit 6514f64. This will update automatically on new commits. Configure here.