Skip to content

feat: existing permission banner on permission picker #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mj-kiwi wants to merge 9 commits into from
Closed

feat: existing permission banner on permission picker #286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8885057
feat: implement existing permissions service and update UI to handle …
mj-kiwi Mar 19, 2026
04c11ba
test: update permission handler tests to include undefined values for…
mj-kiwi Mar 19, 2026
070d55a
feat: refactor existing permissions handling to use a single status f…
mj-kiwi Mar 19, 2026
782e4f9
feat: load existing permissions status in parallel during confirmatio…
mj-kiwi Mar 19, 2026
8e7224e
feat: enhance existing permissions service with category extraction a…
mj-kiwi Mar 19, 2026
c4e9157
feat: refactor existing permissions handling to use enum for state ma…
mj-kiwi Mar 19, 2026
cecefaf
feat: update existing permissions messages for clarity and consistency
mj-kiwi Mar 19, 2026
a9e1ae3
feat: refine similar permissions check to ensure category recognition
mj-kiwi Mar 19, 2026
d44f14f
feat: improve existing permissions handling with error management and…
mj-kiwi Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions packages/gator-permissions-snap/locales/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,11 +256,14 @@
"existingPermissionsTitle": {
"message": "Existing permissions"
},
"existingPermissionsDescription": {
"message": "You've already granted permissions for this site. Do you want to continue?"
"existingPermissionsExistingMessage": {
"message": "You have granted permissions to this site in the past. Review them "
},
"existingPermissionsConfirmButton": {
"message": "Continue"
"existingPermissionsSimilarMessage": {
Copy link
Contributor

@jeffsmale90 jeffsmale90 Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still requires that the link is the final part of the message, which will be problematic for some languages.

I think we can skip over this, but it might come back to bit us later.

"message": "You have granted similar permissions to this site in the past. Review them "
},
"existingPermissionsLink": {
"message": "here"
},
"chainLabel": {
"message": "Network"
Expand Down
154 changes: 0 additions & 154 deletions packages/gator-permissions-snap/src/core/existingpermissions/existingPermissionsContent.tsx
View file
Open in desktop

This file was deleted.

193 changes: 0 additions & 193 deletions packages/gator-permissions-snap/src/core/existingpermissions/existingPermissionsService.ts
View file
Open in desktop

This file was deleted.

14 changes: 0 additions & 14 deletions packages/gator-permissions-snap/src/core/existingpermissions/index.ts
View file
Open in desktop

This file was deleted.

Loading
Loading