Skip to content

Taproot feature support#578

Open
Battambang wants to merge 19 commits intomainfrom
feat/taproot
Open

Taproot feature support#578
Battambang wants to merge 19 commits intomainfrom
feat/taproot

Conversation

@Battambang
Copy link
Contributor

@Battambang Battambang commented Feb 2, 2026

Note

Medium Risk
Expands supported address/derivation types and changes account discovery/creation validation and index resolution, which could affect account derivation and discovery results across networks despite strong test coverage.

Overview
Adds Taproot (P2TR) support to the snap’s keyring by allowing createAccount to accept/derive p2tr from BIP-86 derivation paths, validating addressType/path consistency, and auto-incrementing indices per (entropySource, network, addressType).

discoverAccounts now probes both P2WPKH and P2TR for each scope and still returns only accounts with transaction history. Extensive integration/unit test updates cover P2TR account creation, UTXO ops, PSBT fill/sign/broadcast, fee computation, transfers, and message signing; test utilities/constants were expanded (shared TEMPLATE_PSBT, P2TR test vectors, getNewAddress helper).

Written by Cursor Bugbot for commit 7372244. This will update automatically on new commits. Configure here.

@Battambang Battambang requested a review from a team as a code owner February 2, 2026 22:26
@Battambang Battambang changed the title Feat/taproot Taperoot feature support Feb 2, 2026
@Battambang Battambang marked this pull request as draft February 3, 2026 09:12
@Battambang Battambang marked this pull request as ready for review February 6, 2026 14:14
Copy link
Member

@mikesposito mikesposito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on this! The implementation itself looks good, but I added some suggestions to improve readability, and avoid some type casts

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

@Battambang Battambang changed the title Taperoot feature support Taproot feature support Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants