Open
Conversation
mikesposito
reviewed
Feb 9, 2026
Member
mikesposito
left a comment
There was a problem hiding this comment.
Nice work on this! The implementation itself looks good, but I added some suggestions to improve readability, and avoid some type casts
…unt with less nested conditions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Expands supported address/derivation types and changes account discovery/creation validation and index resolution, which could affect account derivation and discovery results across networks despite strong test coverage.
Overview
Adds Taproot (P2TR) support to the snap’s keyring by allowing
createAccountto accept/derivep2trfrom BIP-86 derivation paths, validating addressType/path consistency, and auto-incrementing indices per (entropySource, network, addressType).discoverAccountsnow probes bothP2WPKHandP2TRfor each scope and still returns only accounts with transaction history. Extensive integration/unit test updates cover P2TR account creation, UTXO ops, PSBT fill/sign/broadcast, fee computation, transfers, and message signing; test utilities/constants were expanded (sharedTEMPLATE_PSBT, P2TR test vectors,getNewAddresshelper).Written by Cursor Bugbot for commit 7372244. This will update automatically on new commits. Configure here.