Update ESLint config to flat format #3107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/[email protected] |
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
Mrtenz
force-pushed
the
mrtenz/eslint-9/update-configs
branch
2 times, most recently
from
d1f7437 to
5811f63
Compare
Mrtenz
force-pushed
the
mrtenz/eslint-9/update-configs
branch
from
afbdfc0 to
67b797f
Compare
hmalik88
reviewed
Feb 17, 2025
| rules: { | ||
| // This rule is too strict for test files. | ||
| // TODO: Upstream this change to `@metamask/eslint-config-jest`. | ||
| '@typescript-eslint/unbound-method': 'off', |
Contributor
There was a problem hiding this comment.
I think we can remove some comments in some of the controllers with this change
Member
Author
There was a problem hiding this comment.
Done in #3112. I split them up to keep it reviewable.
hmalik88
approved these changes
Feb 17, 2025
david0xd
approved these changes
Feb 17, 2025
Mrtenz
added a commit
that referenced
this pull request
Feb 17, 2025
This either replaces or removes inline comments disabling ESLint rules following the configuration changes in #3107 and rule changes in `@metamask/eslint-config`.
Mrtenz
added a commit
that referenced
this pull request
Feb 19, 2025
This rewrites the existing ESLint config to the flat config format, with minimal modifications to the original config, other than those required by the new format. In addition to that, there are some other minor changes: - I updated the Prettier config to use Prettier 3. - I removed ESLint and related dependencies from all non-root workspace packages. These are no longer required, and removing them makes dependency maintenance a bit easier. Closes #3099.
Mrtenz
added a commit
that referenced
this pull request
Feb 19, 2025
This either replaces or removes inline comments disabling ESLint rules following the configuration changes in #3107 and rule changes in `@metamask/eslint-config`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rewrites the existing ESLint config to the flat config format, with minimal modifications to the original config, other than those required by the new format.
In addition to that, there are some other minor changes:
Closes #3099.