Replace or remove rules following breaking changes #3112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mrtenz
force-pushed
the
mrtenz/eslint-9/replace-rules
branch
from
a04dd59 to
728d0f0
Compare
Mrtenz
commented
Feb 17, 2025
Comment on lines
+5
to
+12
| "composite": false, | ||
| "module": "CommonJS", | ||
| "moduleResolution": "Node10", | ||
| "paths": { | ||
| "@metamask/snaps-sdk/jsx-dev-runtime": ["../../../snaps-sdk/src/jsx/jsx-dev-runtime.ts", "../snaps-sdk/src/jsx/jsx-dev-runtime.ts"], | ||
| "@metamask/snaps-sdk/jsx": ["../../../snaps-sdk/src/jsx", "../snaps-sdk/src/jsx"], | ||
| "@metamask/snaps-sdk": ["../../../snaps-sdk/src", "../snaps-sdk/src"], | ||
| } |
Member
Author
There was a problem hiding this comment.
These changes make the // eslint-disable-next-line @typescript-eslint/no-throw-literal comments in the examples unnecessary. Before, it would depend on build output whether these comments were necessary or not.
hmalik88
approved these changes
Feb 17, 2025
Mrtenz
added a commit
that referenced
this pull request
Feb 19, 2025
This either replaces or removes inline comments disabling ESLint rules following the configuration changes in #3107 and rule changes in `@metamask/eslint-config`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This either replaces or removes inline comments disabling ESLint rules following the configuration changes in #3107 and rule changes in
@metamask/eslint-config.