feat: Add Snap export handler usage tracking #3281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 3, 2025
david0xd
force-pushed
the
dd/add-handler-tracking
branch
2 times, most recently
from
0683058 to
8bd8e34
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3281 +/- ##
=======================================
Coverage 98.06% 98.06%
=======================================
Files 397 397
Lines 10898 10929 +31
Branches 1714 1720 +6
=======================================
+ Hits 10687 10718 +31
Misses 211 211 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
david0xd
changed the title
FrederikBolding
previously approved these changes
May 2, 2025
david0xd
force-pushed
the
dd/add-handler-tracking
branch
from
035e985 to
943ff00
Compare
Use registry for metadata Replace controller with hook approach Fix broken unit tests Add unit tests Fix coverage after rebase Remove category Remove async from registry metadata and tracking Update throttling logic and tests Rearrange unit tests Update call to get registry metadata Remove unused getRegistryMetadata Refactor tracking call Add logic optimization for throttling function Skip preinstalled Snaps tracking Add error handling for MetaMetrics hook Add unit test for preinstalled snap
david0xd
force-pushed
the
dd/add-handler-tracking
branch
from
943ff00 to
6848f81
Compare
FrederikBolding
approved these changes
May 5, 2025
Mrtenz
pushed a commit
to MetaMask/metamask-mobile
that referenced
this pull request
May 13, 2025
…14428) ## **Description** This PR adds MetaMetrics tracking hook to Snap controller init. This way we delegate Snap export tracking to Snap controller. ## **Related issues** Related PR: MetaMask/snaps#3281 MetaMask/metamask-extension#31553 ## **Notes** - Requires Snaps release. - Snaps PR: MetaMask/snaps#3281 - Targets Snaps release when ready. ## **Manual testing steps** 1. TBD ## **Screenshots/Recordings** ### **Before** n/a ### **After** n/a ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Mrtenz
pushed a commit
to MetaMask/metamask-mobile
that referenced
this pull request
May 13, 2025
…14428) ## **Description** This PR adds MetaMetrics tracking hook to Snap controller init. This way we delegate Snap export tracking to Snap controller. ## **Related issues** Related PR: MetaMask/snaps#3281 MetaMask/metamask-extension#31553 ## **Notes** - Requires Snaps release. - Snaps PR: MetaMask/snaps#3281 - Targets Snaps release when ready. ## **Manual testing steps** 1. TBD ## **Screenshots/Recordings** ### **Before** n/a ### **After** n/a ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Mrtenz
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
May 13, 2025
## **Description** This PR is the next step in moving Snap export tracking away from the extension and transferring its functionality and responsibility to Snap Controller. ## **Notes** - Requires Snaps release. - Snaps PR: MetaMask/snaps#3281 - Targets Snaps release when ready. [](https://codespaces.new/MetaMask/metamask-extension/pull/31553?quickstart=1) ## **Related issues** Fixes: MetaMask/snaps#3259 ## **Manual testing steps** 1. Find a way to verify that events are tracked (test locally, add console log, etc.) ## **Screenshots/Recordings** ### **Before** n/a ### **After** n/a ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
](https://codespaces.new/MetaMask/metamask-extension/pull/31553?quickstart=1){kind=link}
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves MetaMetrics tracking of Snap export usage to Snap Controller.
Related issue: #3259
Extension integration PR: MetaMask/metamask-extension#31553
Mobile integration PR: MetaMask/metamask-mobile#14428